CR feedback

This commit is contained in:
Geoffrey Goh
2016-08-01 16:17:46 -07:00
parent 67f211a06a
commit 4326515f28
3 changed files with 205 additions and 193 deletions

View File

@@ -23,9 +23,9 @@ export type SyncStatusChangedCallback = (status: CodePush.SyncStatus) => void;
export interface CodePushOptions extends SyncOptions {
/**
* Specifies when you would like to synchronize updates with the CodePush server.
* Defaults to codePush.SyncMode.ON_APP_START.
* Defaults to codePush.CheckFrequency.ON_APP_START.
*/
syncMode: CodePush.SyncMode;
checkFrequency: CodePush.CheckFrequency;
}
export interface DownloadProgress {
@@ -400,9 +400,9 @@ declare namespace CodePush {
}
/**
* Indicates when you would like to synchronize updates with the CodePush server.
* Indicates when you would like to check for (and install) updates from the CodePush server.
*/
enum SyncMode {
enum CheckFrequency {
/**
* When the app is fully initialized (or more specifically, when the root component is mounted).
*/
@@ -411,7 +411,12 @@ declare namespace CodePush {
/**
* When the app re-enters the foreground.
*/
ON_APP_RESUME
ON_APP_RESUME,
/**
* Don't automatically check for updates, but only do it when codePush.sync() is manully called inside app code.
*/
MANUAL
}
}