From a65f97ff24fcfaa76c911389b893b7894e3931ed Mon Sep 17 00:00:00 2001 From: Jonathan Carter Date: Tue, 8 Dec 2015 15:03:53 -0800 Subject: [PATCH 1/2] Adding logging to unknown error case --- CodePush.js | 1 + 1 file changed, 1 insertion(+) diff --git a/CodePush.js b/CodePush.js index 6b95b1a..9d1433a 100644 --- a/CodePush.js +++ b/CodePush.js @@ -294,6 +294,7 @@ function sync(options = {}, syncStatusChangeCallback, downloadProgressCallback) }) .catch((error) => { syncStatusChangeCallback(CodePush.SyncStatus.UNKNOWN_ERROR); + log(error.message); reject(error); }) .done(); From d4ff75d41506dd9d1ddd8bea88cae9b5ddfb353a Mon Sep 17 00:00:00 2001 From: Jonathan Carter Date: Tue, 8 Dec 2015 18:09:54 -0800 Subject: [PATCH 2/2] Adding logging to download and install --- CodePush.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/CodePush.js b/CodePush.js index 9d1433a..cadd8d1 100644 --- a/CodePush.js +++ b/CodePush.js @@ -219,6 +219,12 @@ function sync(options = {}, syncStatusChangeCallback, downloadProgressCallback) }; return new Promise((resolve, reject) => { + var rejectPromise = (error) => { + syncStatusChangeCallback(CodePush.SyncStatus.UNKNOWN_ERROR); + log(error.message); + reject(error); + }; + CodePush.notifyApplicationReady() .then(() => { syncStatusChangeCallback(CodePush.SyncStatus.CHECKING_FOR_UPDATE); @@ -235,7 +241,7 @@ function sync(options = {}, syncStatusChangeCallback, downloadProgressCallback) resolve(CodePush.SyncStatus.UPDATE_INSTALLED); }); }) - .catch(reject) + .catch(rejectPromise) .done(); } @@ -292,11 +298,7 @@ function sync(options = {}, syncStatusChangeCallback, downloadProgressCallback) doDownloadAndInstall(); } }) - .catch((error) => { - syncStatusChangeCallback(CodePush.SyncStatus.UNKNOWN_ERROR); - log(error.message); - reject(error); - }) + .catch(rejectPromise) .done(); }); };