From 360fb334d0a3cc32f00b4b577c91afc5046e0788 Mon Sep 17 00:00:00 2001 From: Geoffrey Goh Date: Sat, 6 Feb 2016 13:55:20 -0800 Subject: [PATCH] feedback --- CodePush.m | 2 +- CodePushPackage.m | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CodePush.m b/CodePush.m index 1500f48..87e44ea 100644 --- a/CodePush.m +++ b/CodePush.m @@ -507,7 +507,7 @@ RCT_EXPORT_METHOD(notifyApplicationReady:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) { // We only mark a pending update as succeeded only if it has been booted up - // successfully, during which `didUpdate` is set to true. + // successfully, during which `_isFirstRunAfterUpdate` is set to true. if (_isFirstRunAfterUpdate) { [CodePush removePendingUpdate]; } diff --git a/CodePushPackage.m b/CodePushPackage.m index ae0b973..7e6328f 100644 --- a/CodePushPackage.m +++ b/CodePushPackage.m @@ -459,7 +459,7 @@ NSString * const UnzippedFolderName = @"unzipped"; return; } - if (!removePendingUpdate) { + if (removePendingUpdate) { NSString *currentPackageFolderPath = [self getCurrentPackageFolderPath:error]; if (!*error && currentPackageFolderPath) { // Error in deleting pending package will not cause the entire operation to fail.