From 2e7d3cb4d3b555659de571873cdf39a54da5b0ca Mon Sep 17 00:00:00 2001 From: tcbyrd Date: Thu, 5 Apr 2018 17:39:00 -0400 Subject: [PATCH 1/6] Add stack overflow button --- community.html | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/community.html b/community.html index 8b464fa..cbb3f27 100644 --- a/community.html +++ b/community.html @@ -21,9 +21,13 @@ redirect_from: Contribute on GitHub - + Follow on Twitter + + + Probot on Stack Overflow +
From 14292dc7eada50841a0f8da88c9fdc94284fa87d Mon Sep 17 00:00:00 2001 From: tcbyrd Date: Fri, 6 Apr 2018 07:38:53 -0400 Subject: [PATCH 2/6] Updates to clean up tests Ignore links to localhost in tests This org doesn't exist Removing unmaintained app (returning 503) Use `/ping` for tests since there is an option to disable stats --- _apps/settings.md | 1 - _apps/untrivializer.md | 60 ------------------------------------------ script/html-proofer | 1 + test/lint_test.rb | 2 +- 4 files changed, 2 insertions(+), 62 deletions(-) delete mode 100644 _apps/untrivializer.md diff --git a/_apps/settings.md b/_apps/settings.md index 9c10532..2de603c 100644 --- a/_apps/settings.md +++ b/_apps/settings.md @@ -13,7 +13,6 @@ host: https://github-configurer.herokuapp.com installations: 128 organizations: - apollographql -- CNXTEoEorg - denysdovhan - bkeepers - chaijs diff --git a/_apps/untrivializer.md b/_apps/untrivializer.md deleted file mode 100644 index 04e9631..0000000 --- a/_apps/untrivializer.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -title: Untrivializer -description: An app that asks if you're really sure something is trivial when you - make a comment in Github issues. -slug: https://github.com/apps/untrivializer -screenshots: -- https://raw.githubusercontent.com/entendu/untrivializer/master/docs/ss.png -authors: -- entendu -repository: entendu/untrivializer -host: https://puffy-aftermath.glitch.me -stars: 5 -updated: 2017-12-15 23:13:31 UTC -installations: 3 -organizations: -- red-eclipse -- entendu ---- - -# untrivializer - -> a GitHub App built with [probot](https://github.com/probot/probot) that asks in Github comments if you're really sure something is trivial. - -![screenshot](https://raw.githubusercontent.com/entendu/untrivializer/master/docs/ss.png) - -## But why tho - -A lot of times we'll write up an issue without really thinking it through: - -> We want _X_. Just do thing _Y_ to get it, that should be really simple. - -> Make change _Z_, it should be trivial. - -> Do thing _Foo_, it's super easy. - -Doing those things (almost without fail) takes way, way more time than we think it will. Why? A couple reasons: - -* If we're making a comment like that we're probably not thinking through all the little details anyway, -* We're all just [terrible at estimating, _even when we know we're terrible at estimating_](https://en.wikipedia.org/wiki/Planning_fallacy) (it's truly incredible), -* We often forget the downstream repercussions of "simple" changes -- one line of code for you might mean 3 hours or more of code review, testing, etc. - -So this little robot tries to detect when you've said something "should be simple" and asks if that's really the case. The default reply is: - -> Did you mean, "_might be straightforward, but could have unforseen complexities that would completely change the prioritization of the issue, so we should let it go through the normal planning and estimation process_"[?](https://en.wikipedia.org/wiki/Planning_fallacy) - -Detection is an ugly regex. - -## Running - -I think you can run this as a Github app here: https://github.com/apps/untrivializer but no guarantees that the backend will stay up. If you'd rather run it yourself (I don't blame you) look below. - -## Setup - -``` -# Install dependencies -npm install - -# Run the bot -npm start -``` diff --git a/script/html-proofer b/script/html-proofer index ae1d50b..dee1c0c 100755 --- a/script/html-proofer +++ b/script/html-proofer @@ -9,6 +9,7 @@ url_ignores = [ %r{https://github.com/apps/.*/installations/new}, "https://mochajs.org/", %r{mit-license\.org}, # misconfigured SSL or old certs on Travis CI? + %r{https://localhost:*/*}, # Ignore links to localhost in documentation ] begin diff --git a/test/lint_test.rb b/test/lint_test.rb index be2093d..a2a2ea5 100644 --- a/test/lint_test.rb +++ b/test/lint_test.rb @@ -53,7 +53,7 @@ describe "lint test" do end it "host returns 200" do - uri = URI(data["host"] + '/probot/stats') + uri = URI(data["host"] + '/ping') res = Net::HTTP.get_response(uri) assert_equal "200", res.code, "Expected 200 response from #{uri}" end From e3e494fba883dcb7684c4e8fefa520f32863b05e Mon Sep 17 00:00:00 2001 From: Tommy Byrd Date: Fri, 6 Apr 2018 12:01:47 -0400 Subject: [PATCH 3/6] Ask on stack overflow --- community.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/community.html b/community.html index cbb3f27..4e03229 100644 --- a/community.html +++ b/community.html @@ -26,7 +26,7 @@ redirect_from: - Probot on Stack Overflow + Ask on Stack Overflow
From 8828e6486063b995eec9d9d3e6dd95930fb1a5d4 Mon Sep 17 00:00:00 2001 From: Brandon Keepers Date: Sat, 14 Apr 2018 09:58:46 -0500 Subject: [PATCH 4/6] Update docs to latest master --- _submodules/probot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_submodules/probot b/_submodules/probot index 05e063f..450b42c 160000 --- a/_submodules/probot +++ b/_submodules/probot @@ -1 +1 @@ -Subproject commit 05e063f02a8c5e082fe6640bc31051193d850359 +Subproject commit 450b42c0903d8a3135590e93044010e2b1731ac4 From c9b90c9735e78022453e019f7bee08213efaf8bc Mon Sep 17 00:00:00 2001 From: Brandon Keepers Date: Sat, 14 Apr 2018 10:21:32 -0500 Subject: [PATCH 5/6] Avoid verifying SSL #yolo --- script/html-proofer | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/script/html-proofer b/script/html-proofer index dee1c0c..eb62e63 100755 --- a/script/html-proofer +++ b/script/html-proofer @@ -19,7 +19,12 @@ begin :file_ignore => [%r{_site/api/}], :verbose => !!ENV["VERBOSE"], :check_html => true, - :empty_alt_ignore => true + :empty_alt_ignore => true, + :typhoeus => { + # Work around SSL errors: https://github.com/gjtorikian/html-proofer/issues/376 + :ssl_verifypeer => false, + :ssl_verifyhost => 0 + } ).run rescue => e puts "\n", e From 6e322fe6f497a48a1bb4f87bc7428ffeea2b8987 Mon Sep 17 00:00:00 2001 From: Brandon Keepers Date: Sat, 14 Apr 2018 12:13:32 -0500 Subject: [PATCH 6/6] Try adding libcurl4-openssl-dev package --- .travis.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.travis.yml b/.travis.yml index 52ffe98..b569392 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,6 +3,10 @@ script: "./script/cibuild" language: ruby rvm: - 2.4.0 +addons: + apt: + packages: + - libcurl4-openssl-dev notifications: email: false env: