Deprecation guidelines mention that contributors should add a console warning for deprecated tags.
This PR adds a link to guidelines that will help the contributor write a good console message.
Ran with the same command (`yarn dev`) this contains all the
functionality you know and love - hot reloading, a playground, percy
snapshots just with a different veneer
Tophatting is now done through the playground server instead of being a
separate thing. Examples are now hot reloadable - modifications to
README files and components will be reflected in your browser without
needing to save due to markdown files being imported via webpack loader.
This makes the examples part of the build pipeline instead of something
that gets serialised into the page. This makes individual pages smaller
at the expense of a larger bundle (which is shared amongst pages).
* Updated based on feedback from last week
- Added more detail to items about keyboard accessibility and focus.
- Added CTA for requesting help on Slack or GitHub, for internal use.
- Clarified resizing/reflowing.
- Added exemptions for color contrast.
- Clarified text resizing.
- Added more detail to images.
- Introduced the notion of accessibility guidelines in the style guide.
- Clarified the definition of "accessible".
- Moved 3.2.2 and 4.1.2 related items to the Dynamic content section.
- Renamed mobile-related sections.
* Updated language and navigation
- Added language around impairments
- Firmed up verbs
- Added links to test checklist sections
- Added note on SVG best practice
- Removed reference to internal-only resources.
* Fixed a formatting typo
* Added a11y doc update
* add appBridge to polaris context
* implement app bridge for loading and update tests
* add tests
* use appBridge in toast
* update tests
* update prop with default value, set to dismissable, and unmount safely
* render page components with app bridge
* add callback support, move to private methods
* add lifecycle handlers
* bump app-bridge version and update isDismissible option
* generate redirect callbacks based on url
* add target type to actions, remove logic to infer target
* add tests
* dev up
* [Modal] App Bridge (#2320)
* stop exporting embedded modal and export normal modal with modal props instead
* get a working app bridge modal
* better type for size and pull title
* get all props working, needs refactor with page
* easdk action is already part of the complex action type
* move modal app bridge transforms into shared utility
* refactor page to use shared transformers
* rebase off beta/app-bridge, respond to feedback, and fix modal typing
* add tests
* refactor transforms
* add transformer tests, refactor transformer to use overload, and subsequent refactors of page and modal and their tests
* add test for modal not opening on mount
* respond to feedback
* [Resource picker] App bridge (#2443)
* upgrade resource picker to use app bridge
* refactor toast and loading based on app bridge version bump
* change close callback to cancel callback, fix subscribed select action
* tweak docs
* set defaults to keep them in sync with our docs, add showVariants
* add tests
* fix tests
* not true is also known as false
* cast action as Action.ADMIN_PATH to avoid casting as any
* use enum instead of string for argument to subscribe
* The EASDK is dead, long live the Shopify App Bridge
* fix tests
* replace type cast with overload function
* safe guard against calls to set unless something has changed
* add tests for safe guards to set
* support the danger button
* document all the changes
* ignore tophat examples if hidePlayground is true
* burn handle warning from Modal
* use default toast duration in tests
* stop typing as any in overloaded transformer function
* add note about shopOrigin to not have https://
* update history example
* dynamically generate types for target and modal size
* update prop docs for shopOrigin
* no no no
Added the guide modified for the public repo, and altered it slightly to link to the test checklist.
Added a link to the checklist to link to the intro doc.
This document adds a manual accessibility checklist for submitting pull requests to polaris-react, and more broadly talks about accessibility testing that should be done when contributing.
