From b7d8e1de84adebdd144867ba6fd8a526ad878bfa Mon Sep 17 00:00:00 2001 From: Miru Alves Date: Thu, 25 Jul 2019 13:36:22 -0400 Subject: [PATCH 1/2] Added underline on hover to plain button and default links --- src/components/Button/Button.scss | 1 + src/components/Link/Link.scss | 1 + 2 files changed, 2 insertions(+) diff --git a/src/components/Button/Button.scss b/src/components/Button/Button.scss index 8798d6da..aeded118 100644 --- a/src/components/Button/Button.scss +++ b/src/components/Button/Button.scss @@ -147,6 +147,7 @@ $spinner-size: rem(20px); border: 0; box-shadow: none; color: color('blue', 'dark'); + text-decoration: underline; } &:focus { diff --git a/src/components/Link/Link.scss b/src/components/Link/Link.scss index 67278c3f..512fba22 100644 --- a/src/components/Link/Link.scss +++ b/src/components/Link/Link.scss @@ -15,6 +15,7 @@ &:hover, &:active { color: color('blue', 'dark'); + text-decoration: underline; } } From 2a0a35ede49a42f612e744cccd13e5a1fc558ae8 Mon Sep 17 00:00:00 2001 From: Miru Alves Date: Mon, 12 Aug 2019 09:19:43 -0400 Subject: [PATCH 2/2] unreleased --- UNRELEASED.md | 1 + 1 file changed, 1 insertion(+) diff --git a/UNRELEASED.md b/UNRELEASED.md index c7a7d261..226f4894 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -35,6 +35,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f - Added a new create-react-app example in typescript demonstrating polaris and react-testing ([#1937](https://github.com/Shopify/polaris-react/pull/1937)) - Exported `AppliedFilterInterface` and `FilterInterface` from `Filters` ([#1924](https://github.com/Shopify/polaris-react/pull/1924)) - Improved color contrast of links inside `Banner` ([#1651](https://github.com/Shopify/polaris-react/pull/1651)) +- Add underline to Links and Plain button on hover, so it doesn't rely on color alone for accessibility ([#1885](https://github.com/Shopify/polaris-react/pull/1885)) ### Bug fixes