From 0edc07c2b9b5e7c5dd6472ffddea1d4b3cbddacb Mon Sep 17 00:00:00 2001
From: francesco <francesco@camberi.com>
Date: Tue, 10 Aug 2021 19:02:47 +0200
Subject: [PATCH] Minor type fixes

---
 src/collection/internal/popup_field/PopupFormField.tsx | 4 ++--
 src/form/validation.ts                                 | 2 +-
 src/models/firestore.ts                                | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/collection/internal/popup_field/PopupFormField.tsx b/src/collection/internal/popup_field/PopupFormField.tsx
index 79d2b3c..25d0ba1 100644
--- a/src/collection/internal/popup_field/PopupFormField.tsx
+++ b/src/collection/internal/popup_field/PopupFormField.tsx
@@ -153,8 +153,8 @@ function PopupFormField<S extends EntitySchema<Key>, Key extends string>({
 
     const validationSchema = getYupEntitySchema(
         name ?
-            { [name]: schema.properties[name] } as Partial<PropertiesOrBuilder<S, Key>>
-            : {},
+            { [name]: schema.properties[name] } as PropertiesOrBuilder<S, Key>
+            : {} as PropertiesOrBuilder<S, Key>,
         entity?.values ?? {},
         collectionPath,
         customFieldValidator,
diff --git a/src/form/validation.ts b/src/form/validation.ts
index 56ea2f8..43f9a0e 100644
--- a/src/form/validation.ts
+++ b/src/form/validation.ts
@@ -82,7 +82,7 @@ export function mapPropertyToYup(propertyContext: PropertyContext<any>): AnySche
 }
 
 export function getYupEntitySchema<T extends CMSType, S extends EntitySchema<Key>, Key extends string>
-(properties: Partial<PropertiesOrBuilder<S, Key>>,
+(properties: PropertiesOrBuilder<S, Key>,
  values: Partial<EntityValues<S, Key>>,
  collectionPath: string,
  customFieldValidator?: CustomFieldValidator,
diff --git a/src/models/firestore.ts b/src/models/firestore.ts
index cc1d886..de991ef 100644
--- a/src/models/firestore.ts
+++ b/src/models/firestore.ts
@@ -278,6 +278,7 @@ function sanitizeData<S extends EntitySchema<Key>,
  *
  * @param doc
  * @param schema
+ * @param collectionPath
  * @category Firestore
  */
 export function createEntityFromSchema<S extends EntitySchema<Key>,