From 9799ac0302863eb81045eb8380554fee90514bfa Mon Sep 17 00:00:00 2001 From: Bryan Kendall Date: Tue, 15 Jan 2019 10:44:12 -0800 Subject: [PATCH] Update Functions init templates (#1093) * init template updates * add noImplicitReturns * add line to changelog * Update index.js * Update index.ts --- changelog.txt | 1 + templates/init/functions/javascript/package.lint.json | 4 ++-- templates/init/functions/typescript/package.lint.json | 4 ++-- templates/init/functions/typescript/package.nolint.json | 2 +- templates/init/functions/typescript/tsconfig.json | 5 +++-- templates/init/functions/typescript/tslint.json | 3 --- 6 files changed, 9 insertions(+), 10 deletions(-) diff --git a/changelog.txt b/changelog.txt index 77f9a785..1f7ee5ab 100644 --- a/changelog.txt +++ b/changelog.txt @@ -12,3 +12,4 @@ changed - Clearer empty state when pretty-printing Firestore indexes changed - JavasSript functions template now includes gitignore changed - Added node_modules/ to TypeScript functions template gitignore fixed - Fixed the link to the Google Cloud Console when opening Functions logs +changed - Updated Typescript and other dependencies in newly initalized folders containing Functions diff --git a/templates/init/functions/javascript/package.lint.json b/templates/init/functions/javascript/package.lint.json index 73ec0efe..e86ba762 100644 --- a/templates/init/functions/javascript/package.lint.json +++ b/templates/init/functions/javascript/package.lint.json @@ -14,8 +14,8 @@ "firebase-functions": "^2.1.0" }, "devDependencies": { - "eslint": "^4.12.0", - "eslint-plugin-promise": "^3.6.0" + "eslint": "^5.12.0", + "eslint-plugin-promise": "^4.0.1" }, "private": true } diff --git a/templates/init/functions/typescript/package.lint.json b/templates/init/functions/typescript/package.lint.json index 4b95d6ae..85777770 100644 --- a/templates/init/functions/typescript/package.lint.json +++ b/templates/init/functions/typescript/package.lint.json @@ -15,8 +15,8 @@ "firebase-functions": "^2.1.0" }, "devDependencies": { - "tslint": "~5.8.0", - "typescript": "~2.8.3" + "tslint": "^5.12.0", + "typescript": "^3.2.2" }, "private": true } diff --git a/templates/init/functions/typescript/package.nolint.json b/templates/init/functions/typescript/package.nolint.json index 158a1110..0b843439 100644 --- a/templates/init/functions/typescript/package.nolint.json +++ b/templates/init/functions/typescript/package.nolint.json @@ -14,7 +14,7 @@ "firebase-functions": "^2.1.0" }, "devDependencies": { - "typescript": "~2.8.3" + "typescript": "^3.2.2" }, "private": true } diff --git a/templates/init/functions/typescript/tsconfig.json b/templates/init/functions/typescript/tsconfig.json index d098421a..75bf38d7 100644 --- a/templates/init/functions/typescript/tsconfig.json +++ b/templates/init/functions/typescript/tsconfig.json @@ -1,11 +1,12 @@ { "compilerOptions": { - "lib": ["es6"], "module": "commonjs", "noImplicitReturns": true, + "noUnusedLocals": true, "outDir": "lib", "sourceMap": true, - "target": "es6" + "strict": true, + "target": "es2015" }, "compileOnSave": true, "include": [ diff --git a/templates/init/functions/typescript/tslint.json b/templates/init/functions/typescript/tslint.json index be2c5f4b..befb9f4c 100644 --- a/templates/init/functions/typescript/tslint.json +++ b/templates/init/functions/typescript/tslint.json @@ -107,9 +107,6 @@ // Warns if function overloads could be unified into a single function with optional or rest parameters. "unified-signatures": {"severity": "warning"}, - // Warns if code has an import or variable that is unused. - "no-unused-variable": {"severity": "warning"}, - // Prefer const for values that will not change. This better documents code. "prefer-const": {"severity": "warning"},