kylefang/firebase-tools
1
0
Fork 0
mirror of https://github.com/zhigang1992/firebase-tools.git synced 2026-04-30 04:45:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Minor fixes to how emulators are downloaded + run

Browse Source
This commit is contained in:
Ryan P. Brewster
2018-12-07 10:28:51 -08:00
parent 1a70e45ec3
commit 88d6c2cd06
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/emulator/download.js
View File

@@ -1,5 +1,6 @@
"use strict"; "use strict";
const FirebaseError = require("../error");
const fs = require("fs-extra"); const fs = require("fs-extra");
const request = require("request"); const request = require("request");
const emulatorConstants = require("./constants"); const emulatorConstants = require("./constants");
@@ -13,6 +14,11 @@ module.exports = (name) => {
let req = request.get(emulator.remoteUrl); let req = request.get(emulator.remoteUrl);
let writeStream = fs.createWriteStream(emulator.localPath); let writeStream = fs.createWriteStream(emulator.localPath);
req.on("error", (err) => reject(err)); req.on("error", (err) => reject(err));
req.on('response', response => {
if (response.statusCode != 200) {
reject(new FirebaseError(`download failed, status ${response.statusCode}`, { exit: 1 }));
}
});
req.on("end", () => { req.on("end", () => {
writeStream.close(); writeStream.close();
fs.chmodSync(emulator.localPath, 0o755); fs.chmodSync(emulator.localPath, 0o755);

3
src/serve/javaEmulators.js
View File

@@ -23,7 +23,7 @@ function _runBinary(emulator, command) {
stdio: ["inherit", "pipe", "pipe"], stdio: ["inherit", "pipe", "pipe"],
}); });
emulator.instance.stdout.on("data", (data) => { emulator.instance.stdout.on("data", (data) => {
console.log(data.toString()); process.stdout.write(data.toString());
emulator.stdout.write(data.toString()); emulator.stdout.write(data.toString());
}); });
emulator.instance.stderr.on("data", (data) => { emulator.instance.stderr.on("data", (data) => {
@@ -51,7 +51,6 @@ function _runBinary(emulator, command) {
utils.logLabeledBullet(emulator.name, "emulator has exited"); utils.logLabeledBullet(emulator.name, "emulator has exited");
} }
}); });
utils.logLabeledSuccess(emulator.name, "started on http://localhost:" + emulator.port);
resolve(); resolve();
}); });
} }