Summary: It makes sense to wait until we have more pressing breaking changes to release a major version.
Reviewed By: KylinChang
Differential Revision: D26796073
fbshipit-source-id: f01d622bb7f8451a67309d8c3f62284ceda9a678
Summary: Updating major version to match Graph API release.
Reviewed By: linmx0130
Differential Revision: D26711406
fbshipit-source-id: 2ba166ff86b0d97aececa630e6ee4585ff520aae
Summary: Minor cleanup - Removes some paths in `public_header_files` that were being clobbered anyway by `private_header_files`.
Reviewed By: Oliverccccct
Differential Revision: D26429454
fbshipit-source-id: 6d84edc48b74e9bf35e366b0c659b155b12007b6
Summary:
The main goal of this diff is to remove OHHTPStubs from the FBSDKAppLinkResolver test code.
The easiest way to do that has been to extract the request building part from FBSDKAppLinkResolver to it own class.
These allows us to:
- Assert correctness over some parts of the request independently
- Inject a builder mock in FBSDKAppLinkResolver so we can control the FBSDKGraphRequest and inject the response we want, without having to mock the http layer at all.
Reviewed By: joesus
Differential Revision: D24077192
fbshipit-source-id: 54141fe1a0533bc97503e7a241387c0d0c4da5e3
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1367
Bumping version to 7.0
Bumping Graph API version to 7.0
Reviewed By: jingping2015
Differential Revision: D21405159
fbshipit-source-id: 7ee479aff3ed663210ae0adb13840280d373d9da
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
Updates for v7.0.
Main change is that the SDK can not be developed using Swift. Default will be to build and distribute with Xcode11 using Swift5.
**Migration Concerns**
* CocoaPods
If you were using the 'Swift' subspec of CocoaPods, ex:
`pod 'FBSDKCoreKit/Swift'`
you can now simply use:
`pod 'FBSDKCoreKit`
* Carthage
You will need to use Xcode 11 or later but no other changes should be necessary. The binaries will include the enhanced Swift interfaces by default.
* SPM
No changes
* xcodebuild
No real changes. The '-Swift' targets are deleted. ex:
target `FBSDKCoreKitSwift-Dynamic` is gone. You can simply use `FBSDKCoreKit-Dynamic` and it will include Swift files
* BUCK
Buck will continue to exclude Swift files for the moment. This is an ongoing effort.
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1355
Test Plan: CI and extensive manual testing to make sure we haven't broken any channels.
Reviewed By: dreamolight
Differential Revision: D21239951
Pulled By: joesus
fbshipit-source-id: 325e2049c5fb1b55769c066998dd4b50e0ccaccc
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1268
Not sure why we were weak-linking core location. I am assuming this was related in some way to the deprecated PlacesKit but am not positive.
Reviewed By: Oliverccccct
Differential Revision: D20167000
fbshipit-source-id: 4b8e69d3e263667cb29ac6ecebb87c0da3ba93bb
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1220
Bumps sdk version to 6.0.0
Bumps api version to v6.0
Reviewed By: jingping2015, ZebingZong, KylinChang
Differential Revision: D19698716
fbshipit-source-id: 165ad3f3ac0f5c686e965f521e9d807f9f21d523
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
Updates Package file and Podspecs to rely on file-level platform checks.
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1186
Test Plan:
Sample project using this branch should build for iOS, tvOS, Mac Catalyst
Also checked size implications. This change causes a 16 byte increase in size which seems like more than a fair trade-off for the gains in simplicity.
Reviewed By: ZebingZong
Differential Revision: D19499591
Pulled By: joesus
fbshipit-source-id: 50122a6cbeca0e24f9813cde1907affd9dbfa8c4
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
What we have is similar to this issue here. https://github.com/CocoaPods/CocoaPods/issues/9101
Basically we need to expose FBSDKCOCOAPODS for static libs to work with other kits. There may be other convoluted workarounds but I'd argue it's worth taking the chance that few people are
using the SDK from CocoaPods as a static library AND are unable to avoid a macro collision with `FBSDKCOCOAPODS`
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1184
Test Plan: `pod lib lint FBSDKLoginKit.podspec --allow-warnings --use-libraries --include-podspecs=FBSDKCoreKit.podspec`
Reviewed By: Mxiim
Differential Revision: D19425678
Pulled By: joesus
fbshipit-source-id: 756121ee8cc90a5d9fc2a8b7e7e5ace3b8613394
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
Should be able to declare `FBSDKCOCOAPODS` more granularly.
See: https://github.com/CocoaPods/CocoaPods/issues/3309
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1180
Test Plan: N/A
Reviewed By: ZebingZong
Differential Revision: D19386668
Pulled By: joesus
fbshipit-source-id: 043bd715aadf466ac8403543ca6fea43827fda45
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1177
D19247723 moved relative files to a new folder named GraphAPI but haven't updated the requires_arc setting for this folder, so add back requires_arc setting back to avoid crash on sdk launch.
Reviewed By: joesus
Differential Revision: D19357327
fbshipit-source-id: 21e3c2577d2a26b5386d76a42fa283078d75adcb
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1173
When I tried to integrate FBSDK with cocoapods, getting undefined symbol errors in files of `FBSDKEventInferencer.mm` and `FBSDKAddressInferencer.mm`. This is because FBSDKCoreKit.podspec hasn't specified c++ library to compile.
{F226154380}
Reviewed By: joesus
Differential Revision: D19326280
fbshipit-source-id: a070fc22a56e245f6c7193f13f5adfd34c88c624
Summary:
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1139
- move ViewHierarchy.{h,m} and macros to folder ViewHierarchy
- delete unused FBSDKFunctionEventBinding.h in MarketingKit. The interface FBSDKFunctionEventBinding doesn't have the implementaion but just a .h.
Reviewed By: joesus
Differential Revision: D18674274
fbshipit-source-id: 24c555a2adf0ae04899ffce4a2c73edec688b759
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
Fixing import errors when using Unity.
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1122
Test Plan: Open a new unity project that includes the SDK. Open the generated Xcode workspace. It should compile without error about improper header import syntax.
Reviewed By: Mxiim
Differential Revision: D18572442
Pulled By: joesus
fbshipit-source-id: bddea9a5b97d18f8b27b583dfcce6866c382aea0
Summary:
as title
Following diffs will include:
* add old version file clear function
* for loop to enable each feature/usecase
Reviewed By: dreamolight
Differential Revision: D18362851
fbshipit-source-id: 322823fbfe9308f8522d44768aa78d19aae234e7
