Summary:
FBSDKCoreKit_Basics is currently a module for Swift Package Manager and BUCK but not for CocoaPods or Xcodebuild.
This aims to bring the four in line by separating it into its own module for Xcode builds.
Reviewed By: dreamolight
Differential Revision: D28312787
fbshipit-source-id: b31136de9eb98b31d061d289cd0ea7116acf1c14
Summary: This will make it easier for teams to share resources and avoid rework as they backfill unit tests.
Reviewed By: jingping2015
Differential Revision: D26870942
fbshipit-source-id: 0ccf08facef386e547aea19987cb682337c35ee6
Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
First crack at cleaning up xcconfig files. Noticed that GamingServicesKit was not applying config files.
Also added more robust static analysis and compiler warnings to the config that is shared amongst kits.
Also fixed some of the warnings that this created
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1338
Test Plan: CI. Also can manually check the project settings for FBSDKGamingServicesKit to see where values are coming from (they should be coming from the xcconfig files)
Reviewed By: dreamolight
Differential Revision: D21021155
Pulled By: joesus
fbshipit-source-id: 954824b1dbca234d27f14b38a935e9ac40a8f395
Summary:
PlacesKit is predicated on the existence of two endpoints:
`GET /search?type=place`
and
`GET /{place-information-id}`
These endpoints were removed in GraphAPI v6.0 so this kit is entirely non-functioning.
Reviewed By: jingping2015
Differential Revision: D19858088
fbshipit-source-id: 5cde7f04c6d6d6229175c75557d26043da546ec1
Summary: Asked in the iOS SDK chat and afaict nobody is using or maintaining this sample project. It should be replaced by an updated integration test at some point if we deem it necessary.
Reviewed By: dreamolight
Differential Revision: D18351596
fbshipit-source-id: f743e36f51b45d5d6be0f82f5cf626cba456bf05
