Summary:
Thanks for proposing a pull request!
To help us review the request, please complete the following:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
## Pull Request Details
First crack at cleaning up xcconfig files. Noticed that GamingServicesKit was not applying config files.
Also added more robust static analysis and compiler warnings to the config that is shared amongst kits.
Also fixed some of the warnings that this created
Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1338
Test Plan: CI. Also can manually check the project settings for FBSDKGamingServicesKit to see where values are coming from (they should be coming from the xcconfig files)
Reviewed By: dreamolight
Differential Revision: D21021155
Pulled By: joesus
fbshipit-source-id: 954824b1dbca234d27f14b38a935e9ac40a8f395