21 Commits

Author SHA1 Message Date
naveen
b0c58e0fe2 chore: Set permissions for GitHub actions (#2072)
Summary:
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>

Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/2072

Reviewed By: joesus

Differential Revision: D40737684

Pulled By: jawwad

fbshipit-source-id: b0a40666855308f60714e48d49ac8ae3e4277150
2022-10-28 11:43:05 -07:00
Jawwad Ahmad
897d66be0d Remove support for tvOS
Summary: tvOS is no longer supported

Reviewed By: samodom

Differential Revision: D40691780

fbshipit-source-id: f189dc7a95825ac04c9e87cb98b990ea29eaebf4
2022-10-26 09:02:20 -07:00
Xabi Losada
0c2d8698c7 Main (#1923)
Summary:
Thanks for proposing a pull request!

To help us review the request, please complete the following:

- [x ] sign [contributor license agreement](https://code.facebook.com/cla)
- [ x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [ x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x ] I've added the proper label to this pull request (e.g. `bug` for bug fixes)

## Pull Request Details

Enable 'needs-attention' github action. This action uses the labels 'needs-triage' and 'needs-feedback' to indicate the state of the issue. 'needs-feedback' is used when more information is required to start the resolution. 'needs-triage' indicates that a repo administrator has to triage the issue. This pull request also prevents stale action to close issues tagged with 'needs-triage' and 'acknowledged' labels.

Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1923

Reviewed By: jawwad

Differential Revision: D31898810

Pulled By: xilosada

fbshipit-source-id: 4fcc2f098593fbdded63fd6e946c0e16dd9c1e97
2021-10-26 09:11:59 -07:00
Jing Ping
c930e9b86b Create stale.yml
Summary: Moving stale issue functionality from https://github.com/probot/stale to https://github.com/actions/stale

Reviewed By: jawwad

Differential Revision: D31517022

fbshipit-source-id: 59cd3c7840da0fcdd2baad51341fd3452d490ef4
2021-10-11 00:09:24 -07:00
Jawwad Ahmad
742acd5a74 Update the package manager question to be a drop-down that shows choices
Summary: This will make it easier for users to mention what package manager they are using.

Reviewed By: samodom

Differential Revision: D31463530

fbshipit-source-id: 9cd0c3002d4cd7468ed731459f1181abd0fb4e9f
2021-10-07 12:02:50 -07:00
Sam Odom
062cf197e2 Add SDK version input to GitHub issue template (#1899)
Summary: Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1899

Reviewed By: jawwad

Differential Revision: D31308980

fbshipit-source-id: 6b583a574bc82dc1abe7bd5c16f2949b0829582a
2021-09-30 21:03:35 -07:00
Jawwad Ahmad
925a413057 Update references to the "master" branch to use "main" instead
Summary: This is in preparation for the renaming of the default branch from master to main.

Differential Revision: D30888439

fbshipit-source-id: 0a2a492918a70d7bce0154c4356e1aa2a40b2900
2021-09-15 09:09:26 -07:00
Xabier Losada
596cceb424 Update config.yml (#1825)
Summary:
Fix typo

Thanks for proposing a pull request!

To help us review the request, please complete the following:

- [x] sign [contributor license agreement](https://code.facebook.com/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)

## Pull Request Details

Describe what you accomplished in this pull request (for example, what happens before the change, and after the change)

Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1825

Test Plan: **Add your test plan here**

Reviewed By: xilosada

Differential Revision: D30616402

Pulled By: jawwad

fbshipit-source-id: 633734656c29de473bf9a50eb7669ddaa0df8fbf
2021-08-27 15:47:13 -07:00
Mengxiao Lin
7e32a29895 Setup issue forms and link to developer support in Github
Summary: As title. The configuration is almost the same as Android SDK.

Reviewed By: jingping2015

Differential Revision: D29441332

fbshipit-source-id: 0c7d0b7dac199955cce4772d09f434d3b4434028
2021-06-28 18:06:48 -07:00
Peter Kristensen
9bf746529b Fix broken link to contributor license agreement (#1669)
Summary:
Thanks for proposing a pull request!

To help us review the request, please complete the following:

- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [ ] I've added the proper label to this pull request (e.g. `bug` for bug fixes)

## Pull Request Details

The `CONTRIBUTING.md` had a outdated link for the contributor agreement. This change fixes that.

Pull Request resolved: https://github.com/facebook/facebook-ios-sdk/pull/1669

Test Plan:
1. Clink the "contributor license agreement" link
2. Enjoy seeing a working page instead of a 404

Reviewed By: jvlyn

Differential Revision: D26891735

Pulled By: joesus

fbshipit-source-id: e6757dabcd1e2f003d78f3d81f19c8615dc43689
2021-03-08 20:34:31 -08:00
Joe Susnick
ab88d0daaf Fix code of conduct link in readme
Summary: $title

Reviewed By: jingping2015

Differential Revision: D24149903

fbshipit-source-id: 565ddf6844a650b560d0ea346e5ca6d21f5d98a7
2020-10-06 22:01:51 -07:00
Maxim Goretskyy
c94eae5631 Upload stale config
Summary: Automating closure of stale issues using stalebot.

Reviewed By: joesus

Differential Revision: D19374150

fbshipit-source-id: 31075ce0b8e0f51381fb9edb7e73c2a0301de79f
2020-01-13 10:09:13 -08:00
Joe Susnick
16b7633e2d Renamed ObjC SDK as iOS SDK
Summary: The GitHub repo has been renamed from facebook-ios-sdk to facebook-objc-sdk

Reviewed By: jingping2015

Differential Revision: D17630050

fbshipit-source-id: 4fa7a3c4859af7fead71c4700a1151903d4734cc
2019-09-30 16:11:34 -07:00
joesusnick
2d5f1e1d58 Community forums (#1047)
Summary:
Thanks for proposing a pull request!

To help us review the request, please complete the following:

- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)

## Pull Request Details

This will make it easier to triage issues and help spread the word about the community forums.
Pull Request resolved: https://github.com/facebook/facebook-objc-sdk/pull/1047

Test Plan: N/A

Reviewed By: dreamolight

Differential Revision: D17333033

Pulled By: joesus

fbshipit-source-id: a405e359ee46bc548142e86b823f5276a36c4345
2019-09-11 16:25:59 -07:00
joesusnick
bd8ac94090 Updating PR template (#1040)
Summary:
Thanks for proposing a pull request.

To help us review the request, please complete the following:

- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] describe the change (for example, what happens before the change, and after the change)
Pull Request resolved: https://github.com/facebook/facebook-objc-sdk/pull/1040

Test Plan: N/A

Reviewed By: jingping2015

Differential Revision: D17234264

Pulled By: joesus

fbshipit-source-id: f914a7c4fe38e7a765b092b9c8754edf42881821
2019-09-09 16:05:45 -07:00
Joe Susnick
b014fddd8e Update CODEOWNERS for ios-sdk
Summary: Only current employees should be codeowners

Reviewed By: jingping2015

Differential Revision: D16742344

fbshipit-source-id: ff27f1e6b99bf70044175c9c8b4de3ff451d8078
2019-08-09 13:42:05 -07:00
Rob Hudson
5b87471534 Add robtimp to codeowners
Summary: elmo_shrug

Reviewed By: codytwinton

Differential Revision: D14514400

fbshipit-source-id: d4589ad76b9513f40a0b57b04a4f3b7cbbeaeadf
2019-03-18 18:29:59 -07:00
Cody Winton
0cf26e9aa6 Added CODEOWNERS file (#948)
Summary:
Thanks for proposing a pull request.

To help us review the request, please complete the following:

- [X] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [X] describe the change (for example, what happens before the change, and after the change)

As detailed here: https://github.blog/2017-07-06-introducing-code-owners/
Pull Request resolved: https://github.com/facebook/facebook-objc-sdk/pull/948

Reviewed By: jingping2015

Differential Revision: D14108343

Pulled By: codytwinton

fbshipit-source-id: cf7c0663f36a97e72abce6cafbd5f69b883db4ee
2019-02-15 14:45:20 -08:00
Cody Winton
94cfe6cdd8 Moved CONTRIBUTING.md to Root
Summary: For visibility

Reviewed By: stoyan

Differential Revision: D10452482

fbshipit-source-id: 001ba84c2c33214e0bdc90c942ca7fc1a5187b54
2018-10-19 09:37:17 -07:00
Takeru Chuganji
f0ab69a2fb Update GitHub PR template (#916)
Summary:
- [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
- [x] describe the change (for example, what happens before the change, and after the change)
Pull Request resolved: https://github.com/facebook/facebook-objc-sdk/pull/916

Reviewed By: jingping2015

Differential Revision: D10152072

Pulled By: codytwinton

fbshipit-source-id: a5cc3d89f61a713844b595bb602ccb1e40bf8a68
2018-10-09 12:07:31 -07:00
Cody Winton
1436a13fbf Facebook iOS SDK 4.35 2018-07-26 12:47:42 -07:00