kylefang/facebook-ios-sdk
1
0
Fork 0
mirror of https://github.com/zhigang1992/facebook-ios-sdk.git synced 2026-04-30 10:22:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add a swiftlint rule to prefer final classes

Browse Source 
Summary:
There were only 2 instances in which I had to add a disable comment for prefer_final_classes due to subclassing

Used the following to add the final keyword (Adds final to any class that doesn't have final or open before it and doesn't have func after it)
```
find . -name '*.swift' | xargs perl -pi -e 's/(?<!final )(?<!open )(class (?!func).*\{)/final \1/g'
```

Reviewed By: samodom

Differential Revision: D34119233

fbshipit-source-id: 963d64fefc1686095d0bfe18ac7cb9677606f4e6
This commit is contained in:
Jawwad Ahmad
2022-02-09 23:08:16 -08:00
committed by Facebook GitHub Bot
parent d48c929e53
commit 624db61799
219 changed files with 242 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
testing/TestXcodeIntegration/TestXcodeIntegration/AppDelegate.swift
View File

@@ -14,7 +14,7 @@ import FBSDKLoginKit
import FBSDKShareKit
@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {
final class AppDelegate: UIResponder, UIApplicationDelegate {
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
// Override point for customization after application launch.

2
testing/TestXcodeIntegration/TestXcodeIntegration/SceneDelegate.swift
View File

@@ -8,7 +8,7 @@
import UIKit
class SceneDelegate: UIResponder, UIWindowSceneDelegate {
final class SceneDelegate: UIResponder, UIWindowSceneDelegate {
var window: UIWindow?

2
testing/TestXcodeIntegration/TestXcodeIntegration/ViewController.swift
View File

@@ -8,7 +8,7 @@
import UIKit
class ViewController: UIViewController {
final class ViewController: UIViewController {
override func viewDidLoad() {
super.viewDidLoad()

2
testing/XCFrameworkSPMIntegration/XCFrameworkSPMIntegration/AppDelegate.swift
View File

@@ -10,7 +10,7 @@ import UIKit
import FacebookCore
@main
class AppDelegate: UIResponder, UIApplicationDelegate {
final class AppDelegate: UIResponder, UIApplicationDelegate {
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {

2
testing/XCFrameworkSPMIntegration/XCFrameworkSPMIntegration/SceneDelegate.swift
View File

@@ -8,7 +8,7 @@
import UIKit
class SceneDelegate: UIResponder, UIWindowSceneDelegate {
final class SceneDelegate: UIResponder, UIWindowSceneDelegate {
var window: UIWindow?

2
testing/XCFrameworkSPMIntegration/XCFrameworkSPMIntegration/ViewController.swift
View File

@@ -8,7 +8,7 @@
import UIKit
class ViewController: UIViewController {
final class ViewController: UIViewController {
override func viewDidLoad() {
super.viewDidLoad()