Brent Vatne 4843dd0faa Generalize svg import script and use for maps, add key (to be replaced) to manifest, add maps to exponent-sdk [maps] Run script to import maps [maps] Add exp.json entry for maps api key and use it in app builder ...

Summary:
- I did not test the shell app builder, shell app expert people please do and let me know how it goes or if I missed something.
- We should probably use a shared debug keystore (tell me if this is stupid and I don't know what I'm talking about) so we can just have one maps api key that we can use in development, and we need to generate an api key with the sha1 fingerprint for our release keystore (@jesse plis).
- We need a way for users to get the sha1 fingerprint for keystore for their shell app so that they're able to register their own API key. (@skevy plis).  - iOS was pretty straightforward, no api keys necessary, but @ben you will need to add support for the prefixes SM (https://github.com/lelandrichardson/react-native-maps/blob/master/ios/AirMaps/Callout/SMCalloutView.m) and AIR (https://github.com/lelandrichardson/react-native-maps/blob/master/ios/AirMaps/AIRMap.m) to the iOS versioning script.
- I don't know how we handle versioning of dependencies like Google Play Services Maps, which is required by this lib.

Test Plan:
- Create an Android API key: https://developers.google.com/maps/documentation/android-api/signup
  - You will need your sha1 keystore fingerprint, something like this: `keytool -list -v -keystore ~/.android/debug.keystore -alias androiddebugkey -storepass android -keypass android`
  - Put the API key into exponent/__internal__/keys.json, GOOGLE_MAPS_API_KEY
- Build in debug mode and try adding a map somewhere:
```
  import MapView from 'react-native-maps';
  // or Exponent.Components.MapView

  // in your render fn:
  <MapView
    initialRegion={{
      latitude: 37.78825,
      longitude: -122.4324,
      latitudeDelta: 0.0922,
      longitudeDelta: 0.0421,
    }}
  />
```
- Test it out in shell app builder

Reviewers: skevy, jesse, ben

Reviewed By: ben

Subscribers: jesse, ben, skevy, nikki, ide

Differential Revision: D3026

fbshipit-source-id: 73172f4

2016-09-04 21:16:26 +00:00

2.1 KiB

Raw Permalink History

View Raw