From 63aa6296cd9f29ce9ff4a8716375e65d4eecfbb7 Mon Sep 17 00:00:00 2001 From: Nikhilesh Sigatapu Date: Sat, 5 Nov 2016 06:47:36 +0000 Subject: [PATCH] No need to `glFlush()` right before `glReadPixels(...)` fbshipit-source-id: 185da7c --- cpp/EXGL.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/cpp/EXGL.cpp b/cpp/EXGL.cpp index bf571816d2..4e586f0731 100644 --- a/cpp/EXGL.cpp +++ b/cpp/EXGL.cpp @@ -720,14 +720,12 @@ private: size_t byteLength = width * height * bytesPerPixel(type, format); auto pixels = std::shared_ptr(malloc(byteLength), free); addBlockingToNextBatch([&] { - glFlush(); glReadPixels(x, y, width, height, format, type, pixels.get()); }); JSObjectSetTypedArrayData(jsCtx, (JSObjectRef) jsArgv[6], pixels.get(), byteLength); } else { void *pixels = JSObjectGetTypedArrayBytesPtr(jsCtx, (JSObjectRef) jsArgv[6], NULL); addBlockingToNextBatch([&] { - glFlush(); glReadPixels(x, y, width, height, format, type, pixels); }); }