kylefang/esbuild
1
0
Fork 0
mirror of https://github.com/zhigang1992/esbuild.git synced 2026-04-30 02:16:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

forbid "arguments" in class field initializers

Browse Source
This commit is contained in:
Evan Wallace
2020-09-05 19:45:06 -07:00
parent d360056686
commit 7b6b89eaf3
7 changed files with 49 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/api/api_impl.go
View File

@@ -282,8 +282,8 @@ func validateDefines(log logging.Log, defines map[string]string, pureFns []strin
if _, ok := lexer.Keywords[value]; !ok {
name := value // The closure must close over a variable inside the loop
rawDefines[key] = config.DefineData{
DefineFunc: func(findSymbol config.FindSymbol) ast.E {
return &ast.EIdentifier{Ref: findSymbol(name)}
DefineFunc: func(loc ast.Loc, findSymbol config.FindSymbol) ast.E {
return &ast.EIdentifier{Ref: findSymbol(loc, name)}
},
}
continue
@@ -302,13 +302,13 @@ func validateDefines(log logging.Log, defines map[string]string, pureFns []strin
var fn config.DefineFunc
switch e := expr.Data.(type) {
case *ast.ENull:
fn = func(config.FindSymbol) ast.E { return &ast.ENull{} }
fn = func(ast.Loc, config.FindSymbol) ast.E { return &ast.ENull{} }
case *ast.EBoolean:
fn = func(config.FindSymbol) ast.E { return &ast.EBoolean{Value: e.Value} }
fn = func(ast.Loc, config.FindSymbol) ast.E { return &ast.EBoolean{Value: e.Value} }
case *ast.EString:
fn = func(config.FindSymbol) ast.E { return &ast.EString{Value: e.Value} }
fn = func(ast.Loc, config.FindSymbol) ast.E { return &ast.EString{Value: e.Value} }
case *ast.ENumber:
fn = func(config.FindSymbol) ast.E { return &ast.ENumber{Value: e.Value} }
fn = func(ast.Loc, config.FindSymbol) ast.E { return &ast.ENumber{Value: e.Value} }
default:
log.AddError(nil, ast.Loc{}, fmt.Sprintf("Invalid define value: %q", value))
continue