From a227c0175f01bc4614a8d82b79902bd3b0c8afa3 Mon Sep 17 00:00:00 2001 From: Dallon Feldner Date: Tue, 4 Dec 2012 17:12:03 -0700 Subject: [PATCH 1/7] Fixed bug where changing a property type from "number" to "string" made existing properties uneditable. --- HISTORY.md | 3 +++ README.md | 2 +- lib/resources/collection/dashboard/js/data.js | 2 +- lib/resources/dashboard/bootstrap | 2 +- package.json | 2 +- 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/HISTORY.md b/HISTORY.md index 89216ea..2e3b03a 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -1,5 +1,8 @@ # History +## 0.6.10 +- Fixed bug where changing a property type from "number" to "string" made existing properties uneditable. + ## 0.6.9 - Fixed bug where `internal-client` was not accessible from modules diff --git a/README.md b/README.md index 2f71f41..084bfb6 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# deployd v0.6.9 +# deployd v0.6.10 [![Build Status](https://secure.travis-ci.org/deployd/deployd.png)](http://travis-ci.org/deployd/deployd) diff --git a/lib/resources/collection/dashboard/js/data.js b/lib/resources/collection/dashboard/js/data.js index b4c3b2d..ce588ca 100644 --- a/lib/resources/collection/dashboard/js/data.js +++ b/lib/resources/collection/dashboard/js/data.js @@ -207,7 +207,7 @@ var val = vm.selectedRow()[vm.selectedProp().name](); if (type === 'string') { - return !val || val.indexOf('\n') === -1; + return !val || val.toString().indexOf('\n') === -1; } return true; diff --git a/lib/resources/dashboard/bootstrap b/lib/resources/dashboard/bootstrap index bb57155..357154b 160000 --- a/lib/resources/dashboard/bootstrap +++ b/lib/resources/dashboard/bootstrap @@ -1 +1 @@ -Subproject commit bb57155a7b66f9f784e4db6f420333e328159533 +Subproject commit 357154b78e474e3a2b893d3bf3804697814bcb57 diff --git a/package.json b/package.json index 28f9027..811f0ae 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "author": "Ritchie Martori", "name": "deployd", - "version": "0.6.9", + "version": "0.6.10", "description": "the simplest way to build realtime APIs for web and mobile apps", "repository": { "url": "git://github.com/deployd/deployd.git" From 3ea33a19556e853695ef521dc640d575c7f22405 Mon Sep 17 00:00:00 2001 From: Ritchie Martori Date: Mon, 10 Dec 2012 18:30:39 -0800 Subject: [PATCH 2/7] updated urls for deployment --- bin/dpd | 2 +- lib/client/deploy.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/dpd b/bin/dpd index 871cb02..04451dd 100755 --- a/bin/dpd +++ b/bin/dpd @@ -328,7 +328,7 @@ program d.package(tar, function (err) { if(err) return console.error(err); console.log('pushing...'); - d.publish('http://deploy.deploydapp.com:3003', tar, key, function (err) { + d.publish('http://cloud.deployd.com', tar, key, function (err) { if(err) return console.error('failed to push:', err.message || 'could not push app to ' + DPDAPP_URL); console.log('deployd app to http://' + d.subdomain + '.deploydapp.com!'); }); diff --git a/lib/client/deploy.js b/lib/client/deploy.js index b4aaef4..a8eb7e7 100644 --- a/lib/client/deploy.js +++ b/lib/client/deploy.js @@ -15,8 +15,8 @@ var path = require('path') function Deployment(appPath, user, subdomain) { var remote = this.remote = 'deploydapp.com'; - this.api = "http://api.deploydapp.com:3000"; - this.deployUrl = "http://deploy.deploydapp.com:3003"; + this.api = "http://api.deployd.com"; + this.deployUrl = "http://cloud.deployd.com"; this.path = path.resolve(appPath); From 9b8f6a06898fe087c21a02a9d1cbb8ce9c52a349 Mon Sep 17 00:00:00 2001 From: Dallon Feldner Date: Tue, 11 Dec 2012 11:16:47 -0700 Subject: [PATCH 3/7] Fixed some minor bugs in deployment --- bin/dpd | 8 +++++++- lib/client/deploy.js | 14 +++++++------- lib/resources/dashboard/deployments.html | 2 +- lib/resources/dashboard/js/deployments.js | 2 ++ lib/resources/internal-deployments.js | 18 +++++++++++++++++- 5 files changed, 34 insertions(+), 10 deletions(-) diff --git a/bin/dpd b/bin/dpd index 04451dd..b1451ef 100755 --- a/bin/dpd +++ b/bin/dpd @@ -329,7 +329,13 @@ program if(err) return console.error(err); console.log('pushing...'); d.publish('http://cloud.deployd.com', tar, key, function (err) { - if(err) return console.error('failed to push:', err.message || 'could not push app to ' + DPDAPP_URL); + if(err) { + if (err.statusCode === 401) { + d.setConfig('sid', undefined); + d.setConfig('user', undefined); + } + return console.error('failed to push:', err.message || 'could not push app to ' + DPDAPP_URL); + } console.log('deployd app to http://' + d.subdomain + '.deploydapp.com!'); }); }); diff --git a/lib/client/deploy.js b/lib/client/deploy.js index 16f554f..7117269 100644 --- a/lib/client/deploy.js +++ b/lib/client/deploy.js @@ -100,7 +100,12 @@ Deployment.prototype.publish = function (url, tar, key, callback) { function done(err, res, body) { if(err) return callback(err); - if(res.statusCode >= 400) return callback(new Error(body)); + + if(res.statusCode >= 400) { + var error = new Error(body); + error.statusCode = res.statusCode; + return callback(error); + } callback(null, deployment.getConfig(deployment.configKey())); } @@ -119,12 +124,7 @@ Deployment.prototype.publish = function (url, tar, key, callback) { return callback(err); } - if(res.statusCode !== 200) { - deployment.setConfig('sid', undefined); - deployment.setConfig('user', undefined); - delete deployment.sid; - delete deployment.user; - } else { + if(res.statusCode === 200) { try { body = JSON.parse(body); diff --git a/lib/resources/dashboard/deployments.html b/lib/resources/dashboard/deployments.html index 0273474..da93a3e 100644 --- a/lib/resources/dashboard/deployments.html +++ b/lib/resources/dashboard/deployments.html @@ -89,7 +89,7 @@