mirror of
https://github.com/zhigang1992/create-react-app.git
synced 2026-04-22 20:39:05 +08:00
76fea02277
General cleanup after the [Jest 24 PR](#6278).
This also includes `jsdom@14` via https://www.npmjs.com/package/jest-environment-jsdom-fourteen. Since we have a node >= 8.10 requirement, we are able to use the latest version of `jsdom` which includes additional implementations of browser APIs such as `MutationObserver` (which we had an issue filed for over at #6617).
/cc @SimenB. Is there more you recommend we do to cleanup our [Jest config](b0cbf2caa1/packages/react-scripts/scripts/utils/createJestConfig.js) for TypeScript?
Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
confusing-browser-globals
A curated list of browser globals that commonly cause confusion and are not recommended to use without an explicit window. qualifier.
Motivation
Some global variables in browser are likely to be used by people without the intent of using them as globals, such as status, name, event, etc.
For example:
handleClick() { // missing `event` argument
this.setState({
text: event.target.value // uses the `event` global: oops!
});
}
This package exports a list of globals that are often used by mistake. You can feed this list to a static analysis tool like ESLint to prevent their usage without an explicit window. qualifier.
Installation
npm install --save confusing-browser-globals
Usage
If you use Create React App, you don't need to configure anything, as this rule is already included in the default eslint-config-react-app preset.
If you maintain your own ESLint configuration, you can do this:
var restrictedGlobals = require('confusing-browser-globals');
module.exports = {
rules: {
'no-restricted-globals': ['error'].concat(restrictedGlobals),
},
};
License
MIT