Commit Graph

50 Commits

Author SHA1 Message Date
Jack Zhao
63398bd5e4 Remove babelrc dependency for kitchensink test (#5098)
* add kitchensink-eject to local-test

* add jest transform

Closes https://github.com/facebook/create-react-app/issues/5095
2018-09-26 00:58:06 -04:00
Joe Haddad
adfb20c403 Turn on Babel helpers (#5093)
* Turn on helpers and test importing something with async/await works

* Compiling babel runtime breaks itself

* Add helpers option to babel plugin with defaults

* Make helpers off by default and on in our configuration

* Hit eject and e2e

* meh

* copy'n'paste

* change again

* Turn off helpers by default in /prod, /dev, /test

* oops

* Spread undefined

* Use object assign not object spread

* Put preset in template since it's needed

* Fix e2e tests
2018-09-25 18:59:06 -04:00
Jack Zhao
d0ed84507b Convert test suite to Jest (#4550)
* convert mocha tests to jest

* jest 23

* add jest configs

* use material css

* fix windows

* forceExit jest test

* force exit eject

* test

* test

* retrigger test

* remove appveyor comment

* try to remove pretendToBeVisual option

* use jsdom env

* test environment

* no cache

* test no close

* bring back raf

* test revert all broken changes

* add back jsdom

* remove jsdom

* node test environment

* use latest change

* runInBand

* runInBand

* comment test run

* try different jest option

* standardize jest test options

* increase heap size

* remove heap size config

* support scoped packages for cra --scripts-version option

* upgrade jest version

* fix windows

* fix windows again

* jest 23.4.1

* babel-jest

* babel-jest

* split out kitchhensink

* travis node 6

* travis node 6 config

* node 6 travis eject

* cache yarn

* only cache yarn

* remove unrelated changes

* typo
2018-09-21 05:17:45 -04:00
Joe Haddad
50b4857ff8 Revert "Add support for yarn and lerna monorepos. (#3741)"
This reverts commit b43ad04b88.
2018-09-18 14:31:19 -04:00
Ian Sutherland
92d9c5ada4 Add Node 10 to CI config and remove Node 6 (#4383)
* Add Node 10 to Travis config. Remove Node 6.

* Add Node 10 to Appveyor config. Remove Node 6.

* Remove node 9 from travis config.

* Increase mocha timeout.

* Update minimum Node version to 8.

* Update yarn to latest on Travis.

* Update old-node test to use Node 4.

* Increase mocha timeout in kitchensink-eject tests.

* Update yarn to latest on Appveyor.
2018-07-15 22:26:42 -06:00
Jack Zhao
366e5d3475 [internal] Separate out kitchensink test into two (#4767)
* support scoped packages for cra --scripts-version option

* seperate out kitchensink test

* add eject to node 6 testing

* travis node 6 eject

* fix CI warnings
2018-07-15 12:21:32 -06:00
Jack Zhao
e1ee8032a8 Fix node 10 npm login issue (#4626)
* node10

* token

* rerun tests
2018-06-18 13:00:55 -04:00
Jack Zhao
c2aa1632e6 Fix e2e:docker script (#4454)
* verdaccio configs

* verdaccio configs

* fix typo

* revert e2e-installs

* move config to tasks
2018-05-14 01:05:16 +01:00
Ro Savage
b2fd8db8bd Minor fixes to CI (#4193) 2018-03-21 14:55:35 -04:00
bradfordlemley
b43ad04b88 Add support for yarn and lerna monorepos. (#3741)
* Support for multiple source paths via package.json srcPaths entry.

Initial support for yarn workspace.

Support lerna workspace, fix for when to use template files.

Remove support for specifying srcPaths in package.json.

Re-enable transpilation caching.

* Clean up, use file matching (similar to original) in webpack configs instead of matching function.

* Remove package lock files.

* Fix for eject.
Note: monorepos won't work after eject.
Can be fixed easily with JEST 22.0.?+ which has file pattern matches against realpaths.

* Filter tests to run only tests in monorepo components included by the app.
(Not sure this is desireable, might be cool to be able to easily run all tests in monorepo from one app.)

* Fix conditions for when to use template.

* Fix eject.

* Remove code that is not needed w/ Jest 22.

* Include all cra-comp tests in monorepo instead of trying to include only tests that are dependencies of app.
(tests can be easily filtered via jest cli if desired, e.g. 'npm test -- myapp comp1')

* Pin find-pkg version.

* Hopefully fix jest test file matching on windows by removing first slash.

* E2E tests for monorepo.

* Run monorepo tests in CI.

* Fix and test post-eject build.

* Fix e2e test.

* Fix test suite names in appveyor.

* Include individual package dirs as srcPaths instead of top-level monorepo root.
Fixes build/start after eject.

* Fix running tests after eject.

* Clean up test workspace, add some verifcations.

* Cleanup.

* Try to fix hang when running test on appveyor.

* Don't write babel or lint config to package.json when ejecting.

* Incorporate review comments.
* Simply monorepo pkg finder
* Only include monorepo pkgs if app itself is included in monorepo
* Check for specific tests in e2e

* Fixes for windows.

* Fix for kitchensink mocha tests compiling.

* Add lerna monorepo test.

* Fix lerna bootstrap on windows.

* Incorporate more review comments:
* remove support for lerna w/o yarn workspace
* add react and react-dom as devDeps to comp1 and comp2

* Add monorepo info to user guide.
2018-02-01 20:58:18 +00:00
Dan Abramov
d49ffde4e6 Fix the E2E script (#3888)
* Fix the E2E script

* Delete .git if committing failed
2018-01-21 23:31:03 +00:00
Maurice de Beijer
247e5c90a0 Create git repository with initial commit (#1288)
* Create git repo with initial commit

* Fixe commit message

* Added the git repo to the docs

* Bail if we are in a mercurial repository

* Removed Chore from commit mesage

* Create repo after installing react and react-dom

* Removed docs

* Commit changes when ejecting

* Update after review

* git add -A instead of git add . after code review
2018-01-19 13:12:34 +00:00
Joe Haddad
aa67a4f78e Loosen Babel preset to use browserslist (#3770)
* Provide better defaults

* Let babel determine features to compile

* meh

* Remove setting of BABEL_ENV

* Revert "Remove setting of BABEL_ENV"

This reverts commit ee2db707faa8b9ada3e7a668e8a94944f5955a1e.

* Set browsers to ie9
2018-01-15 00:08:14 -05:00
Clement Hoang
1552949a3b Switch to Babel 7 (#3522)
* Update dependencies in react-scripts

* Add first pass of working dependencies for babel-preset-react-app and react-scripts

* Bump more dependency versions

* Adjust more versions and edit fix options

* Restore functionality of old preset

* Disable Uglify in iframe webpack

* Apply prettier

* Re-enable cache in dev and clean deps

* Lock packages and move babel/core to dep in preset

* Bump babel-jest

* Re-enable uglify

* Nest forceAllTransforms correctly in webpack config

* Install babel-core bridge for jest

* Add jest-cli and babel-core bridge to make tests in react-error-overlay pass

* Re-enable transform-dynamic-import

* Add dynamic import syntax support back

* Use new babel in kitchensink

* Transform modules in test

* Revert "Transform modules in test"

This reverts commit 539e46a1d77259898b7e70d778a5e43fc25edc2a.

* Attempt fix for ejected tests

* try this

* Add regenerator back

* Bump babel deps to beta.34

* Remove bad files

* Use default when requiring babel transform plugin

* Bump deps

* Try the fix?

* Oopsie

* Remove some weird things

* Run Babel on react-error-overlay tests

* Try fixing kitchensink

* Use new API for codeFrame

* Add missing (?) babelrc

* Maybe this helps?

* Maybe fix mocha

* I shouldn't have deleted this 🤦
2018-01-15 00:07:57 -05:00
Dan Abramov
0aeffe62ef Switch to Yarn Workspaces (#3755)
* Switch to Yarn Workspaces

* Feedback

* Move flowconfig

* Use publish script

* Keep git status check

* Fix Flow without perf penalty

* Remove Flow from package.json "test"

* Try running it from script directly (?)

* Try magic incantations

* lol flow COME ON

* Try to skip Flow on AppVeyor

* -df

* -df

* -df

* Try to fix CI

* Revert unrelated changes

* Update CONTRIBUTING.md
2018-01-12 01:54:53 +00:00
Ade Viankakrisna Fadlil
b02fe66732 clean up changes to npm and yarn registry (#3756) 2018-01-11 23:25:27 +00:00
Joe Haddad
1098a4a177 Oops 2018-01-11 02:21:25 -05:00
Joe Haddad
ebddb83dd6 Remove redundant steps in e2e tests (#3747)
* This doesn't look needed anymore

* Remove unnecessary rebuilds
2018-01-11 01:40:03 -05:00
Joe Haddad
29e06fc91a Follow-up: use private registry (#3746)
* Convert e2e-installs

* Convert kitchensink tests

* Upgrade npm for kitchensink
2018-01-11 01:38:10 -05:00
Dan Abramov
d29d41b3c6 Try to use Yarn in more E2E scripts (#3739)
* Try to use Yarn in more E2E scripts

* Keep using npm pack

* Maybe this will fix Windows?

* Try this
2018-01-11 00:54:49 +00:00
Dan Abramov
dcd8ea6b5c Always use Yarn on CI (#3738) 2018-01-10 23:30:59 +00:00
Dan Abramov
a03524c594 Use latest npm in e2e tests (#3735)
* Use latest npm in e2e tests

* Keep default npm version in "simple" test

* Try to fix CI by using a version that supports Yarn
2018-01-10 21:55:18 +00:00
Joe Lim
231873e948 one-line waiting for app start (#3411)
* one-line waiting for app start

* remove fixed todo
2017-11-05 07:12:50 -05:00
Joe Haddad
de1beec690 Stop using npm link in tests (#3345)
* Try a custom function

* fix path

* install rsync

* Test with node 8

* Ensure package is removed from the tree

* Remove ours

* matching functions

* try cygwin

* try c:/

* sigh

* Try /cygdrive/

* Try /cygdrive/

* Revert "Try /cygdrive/"

This reverts commit ab1ed779456d39bedbdb128a7aec3bb88b8eeb1c.

* Use sub-optimal copy

* Remove rsync install

* Fix variable

* Continue on err

* Don't link react-scripts, lol

* run yarn after eject

* re-enable cleanup

* uninstall yarn

* try with force

* appveyor ... seriously?

* swallow bad eject

* remove eject error swallow

* Revert "run yarn after eject"

This reverts commit eebf1dbc19aeb6e1f66d5ec27bda2d076bea0956.

* Run yarn after eject

* add a comment
2017-10-30 14:18:25 +00:00
Joe Haddad
fedc539246 Fix license comments 2017-09-26 20:15:14 -04:00
Sophie Alpert
2e82ebb337 BSD+Patents -> MIT (#3189)
* File headers BSD+Patents -> MIT

* BSD+Patents -> MIT
2017-09-26 10:30:05 +01:00
Tharaka Wijebandara
89bf273ec8 Link local react-error-overlay package in kitchensink test 2017-09-16 21:15:05 +05:30
Ade Viankakrisna Fadlil
0e064b30ca Revert "run npm 5.4.0 in CI (#3026)" (#3107)
This reverts commit fcb6dc5557.
2017-09-11 21:40:11 -04:00
Ade Viankakrisna Fadlil
fcb6dc5557 run npm 5.4.0 in CI (#3026)
* run npm 5.4.0 in CI

* run npm cache clean with --force in CI

* use link instead of install

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh
2017-09-07 10:47:55 +01:00
Joe Haddad
aad5987a03 Bootstrap with Yarn when available (#2673)
* Bootstrap with Yarn if we can

* Update test scripts

* Check OS and npm concurrency ability

* Windows support

* Update bootstrap.js

* Install yarn before bootstrap
2017-06-29 00:45:45 -04:00
Dan Abramov
657b3fd6c0 Test Node 8 on Travis (#2659)
* Test Node 8 on Travis

We still test Node 7 on AppVeyor

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh

* Update e2e-simple.sh

* Update e2e-simple.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh
2017-06-29 00:09:13 +01:00
Ro Savage
32f82c03cb Added cache clear to e2e scripts (#2400)
* Added cache clear to e2e scripts

* Install latest yarn on AppVeyor to avoid windows crashing bug in yarn

* Alternative fix for yarn crashing e2e tests on windows machines
2017-05-29 19:00:43 +01:00
Ro Savage
e6ddfb0411 Fix kill command in e2e-kitchensink.sh cleanup (#2397) 2017-05-29 11:09:40 +01:00
Dan Abramov
3f342383c3 Revert "Catch "No tests found" during CI" (#2390)
* Revert "Fix wrong path expansion in end-to-end test (#2388)"

This reverts commit 2aafaad72d.

* Revert "Suggest just "yarn build" (#2385)"

This reverts commit 70bf12505c.

* Revert "Catch "No tests found" during CI (#2387)"

This reverts commit 5317b3f910.
2017-05-27 23:26:03 +01:00
Dan Abramov
2aafaad72d Fix wrong path expansion in end-to-end test (#2388)
* Update e2e-kitchensink.sh

* Try again (differently)
2017-05-27 21:38:00 +01:00
Fabrizio Castellarin
5317b3f910 Catch "No tests found" during CI (#2387) 2017-05-27 20:32:12 +01:00
Joe Haddad
f366028031 Fix CI 2017-05-15 13:50:30 -04:00
Joe Haddad
70768b321e Add react-error-overlay package (#2111)
* ༼ つ ◕_◕ ༽つ stack-frame-overlay

* Fix linting

* Remove auto overlay

* Fix e2e

* Pull in the rest

* Appease flow

* Correct dep

* Remove old repo references

* Check flow on test

* Test overlay in e2e

* Add cross env

* Rename package

* Make sure it gets built post-install

* Update the README

* Remove extra builds now that there's a postinstall script

* Revert "Remove extra builds now that there's a postinstall script"

This reverts commit 8bf601dbd36c1e0da7f785fa9ade70ab08ed8772.

* Remove broken script

* Fix some dev ergo
2017-05-10 19:56:30 -04:00
Joe Haddad
a53f22b76d Fix AppVeyor CI (#2010) 2017-04-21 22:05:06 -04:00
Joe Haddad
31243283ab Add linked modules test (#1913) 2017-04-14 23:46:04 -04:00
Ade Viankakrisna Fadlil
4ec5af39ac add double quotes to escape spaces in paths in e2e (#1707)
* add double quotes to escape spaces in path

* Change $* to "$@" props to @n3tr

* escape spaces in path for all e2e tests
2017-03-05 15:42:10 +00:00
Joe Haddad
c7a9daeb80 Fix Jest tests for Cygwin 2017-03-02 22:33:47 -05:00
Joe Haddad
a3a223aa1e Add appveyor.yml (#1648)
* Add appveyor.yml

* Execute mocha directly in e2e test

* Replace e2e process substitution

* Kill nohup node processes after e2e

* Disable known failing Windows test

* Only build master
2017-02-27 18:41:49 -05:00
Dan Abramov
745d341ffb Use Yarn latest in e2e (#1534)
* Use Yarn latest in e2e

* Here too

* And here plz
2017-02-15 00:34:05 +00:00
Marcus R. Brown
f840b4d4ba Fix test -e with wildcard arguments. (#1503)
The `test` command fails with multiple arguments when given a unary operator such as '-e'. Add a function that can test one or more files by looping over all files.
2017-02-12 01:34:15 +00:00
Joe Haddad
12288836e1 Upgrade webpack (#1291)
* Upgrade webpack

* Address more webpack v2 ...

* Update html-webpack-plugin

* Remove LoaderOptionsPlugin from dev config

* ExtractTextPlugin still uses webpack 1 syntax
... and doesn't support complex options (yet)

* Grammar nit

* Update extract text webpack plugin

* - Remove webpack.LoaderOptionsPlugin
- Update deps

* Lerna hoists packages

* Update extract-text-webpack-plugin

* Update webpack-dev-server

* Remove imports for the tests

* stop removing babelrc
2017-02-11 14:11:00 -05:00
Joe Haddad
613b584f42 Add PUBLIC_URL env variable for advanced use (#937) (#1504)
* Add `PUBLIC_URL` env variable for advanced use (#937)
* Add support for `PUBLIC_URL` env variable
* Remove unnecessary duplications
* Simplify served path choice logic
* Honor PUBLIC_URL in development
* Add e2e tests

Enables serving static assets from specified host.
2017-02-09 23:15:15 -05:00
Joe Haddad
adab23fa00 e2e: Reduce complexity of e2e and improve Jest coverage (#1484) 2017-02-07 23:04:01 -05:00
Fabrizio Castellarin
1d586aaf31 E2e jsdom fix (#1470)
* E2E: run tests when react is ready

* Entangle e2e with callbacks

* Remove unused e2e lines
2017-01-30 19:24:12 +00:00
Fabrizio Castellarin
9099570b94 Use a more sophisticated template for end-to-end testing. (#1187)
* Use a more sophisticated template for end-to-end testing.

* Not publish integration tests to npm

* Use "commander" for  cli argv handling

* Handle different scripts version forms and exits without a name given

* Prepare the commands for testing with a template

* Fix dev "template" path

* Add various features to test

* Test various features separately

* Test language features

* Comment unused e2e.sh lines

* Add "development" tests

* Test environment variables

* Test webpack plugins

* Replace kitchensink README

* Switch integration tests from jest to mocha

* Use `fs-extra`

* Use the correct folders

* Do some cleanup

* Print a better message for `--template`

* Test `npm start` with and without https

* Separate fast e2e testing from kitchensink testing

* Hide `--internal-testing-template` (former `--template`) CLI option
2017-01-23 20:43:16 +01:00