Commit Graph

1023 Commits

Author SHA1 Message Date
Tharaka Wijebandara
10b05c7662 Open editor to exact column from build error overlay (#3465)
* Open editor to exact column from build error overlay

* Update launch editor validations
2018-01-09 15:47:22 +00:00
shrynx
85bf3a937b added code-insiders to the editor list (#3652) 2018-01-09 15:46:46 +00:00
Danny Calleri
5a0b1ef56d Better documentation for setupTests.js when ejecting (#3656)
* Better documentation for setupTests.js when ejecting

When running `npm run eject` before creating `src/setupTests.js`, the resulting `package.json` file, won't contain any entry for it - and this is correct in my opinion, since otherwise Jest will crash - but it's useful to have it documented and avoid pointless waste of time.

* Added additional note about src/setupTests.js

Added another note about src/setupTests.js and `npm run eject` in Testing Components section

* Update README.md

* Update README.md
2018-01-09 15:25:59 +00:00
David Gilbertson
fd1a2441b7 Fix typo (#3478)
'more' and 'simpler' together is incorrect.
2018-01-09 15:17:19 +00:00
Juhamatti Niemelä
d61a3313f6 Fix asset size comparison for multi build stats (#3514)
If create-react-app project is ejected and webpack configuration is
modified to multi build setup FileSizeReporter would fail.

In those situations `webpackStats` parameter would contain stats array
for each build. This fix will try to access stats and then falls back
to using plaing webpackStats object.
2018-01-09 15:13:59 +00:00
Evan You
bef40eeb84 Add editor support for Sublime Dev & VSCode Insiders (#3700) 2018-01-09 15:10:31 +00:00
Ulrik Strid
c6034703fc Add link for automatic deployment to azure (#1791) 2018-01-09 14:45:51 +00:00
Dan Abramov
d1adff07ff Document AJAX requests 2018-01-09 14:21:50 +00:00
Daniel Verejan
d3a1765470 Update the string that clears the console. (#2071)
* Update the string that clears the console.

#1914
I've tested it with Windows 10 and 7, node versions from ~5.0.0 up to 7.7.0.
Didn't managed to test it on 8 but it should be fine.

* Update windows string

Add windows specific string for clearing the console.
2018-01-09 13:46:29 +00:00
Rafael E. Poveda
e3e8cdd699 Support setting none in REACT_EDITOR env variable (#3721)
* add support to set REACT_EDITOR to none

* change README message

* change condition to avoid problems with editor being null

* move condition to avoid extra code
2018-01-09 12:35:43 +00:00
Dan Abramov
1c8a7f3fec Document that src/setupTests.js doesn't work if created after ejecting 2018-01-08 23:48:06 +00:00
Dan Abramov
8234e4658d Add missing TOC entries 2018-01-08 23:30:36 +00:00
Dan Abramov
3a009b3403 Document NODE_PATH 2018-01-08 23:18:17 +00:00
Mae Capozzi
5e2c05151c Update README.md (#3717)
* Update README.md with a note that reminds users to prepend REACT_APP_ to their environment variables. 
* Based on #865, where Dan Abramov suggests the person who filed the issue create a PR with these changes.
* Took the language from [Adding Custom Environment Variables](https://github.com/facebookincubator/create-react-app/tree/master/packages/react-scripts/template#adding-custom-environment-variables)
2018-01-08 22:31:43 +00:00
Dan Abramov
ce07e98bbd Relax no-cond-assign rule (#3716)
Fixes #2793
2018-01-08 21:34:01 +00:00
Dan Abramov
419e4d8f57 Add a note about Babel 2018-01-08 21:32:01 +00:00
Ernesto García
1b067c5659 Autodetect MacVim editor (#3545)
Adds support for the error overlay to detect and open the file with the error in MacVim.

Relates to #2636.
2018-01-08 21:08:29 +00:00
Dan Abramov
7ecbc029c7 Update README.md 2018-01-08 18:51:09 +00:00
Dan Abramov
8bb72919cc on -> to 2018-01-08 14:42:40 +00:00
Dan Abramov
16934fad47 Add a section on publishing components to npm 2018-01-08 14:40:24 +00:00
Dan Abramov
4f0cdcffa9 Fix the router doc 2018-01-08 14:36:28 +00:00
Dan Abramov
553712636d Link to React docs 2018-01-08 14:33:03 +00:00
Dan Abramov
1c9301ad2f Add a section on supported browsers 2018-01-08 14:29:14 +00:00
Dan Abramov
ece9523056 Link to an explanation for forking react-scripts (#3710) 2018-01-08 14:16:45 +00:00
Dan Abramov
bb718307ba Document adding a router (#3709) 2018-01-08 14:02:26 +00:00
Norris Oduro
8cae659ec5 Fix path regex match bug (#3686)
* Fix path regex match bug

* Use the escape-string-regexp package to escape regex characters

* Remove redundant character escape from path

* Add removed escape of backslashes
2018-01-04 13:15:50 -05:00
Quentin Bahers
12120f6f55 Fix typo in the User Guide (#3670)
Replace `provide a lot value` with `provide a lot of value`.
2018-01-02 11:53:45 -05:00
Elie
5d7845a733 Update README.md (#3645) 2018-01-02 11:15:32 -05:00
Christian Danielsen
76e3165412 Use friendlier syntax for setting env var on Windows (#3533)
* use safer/more aesthetic syntax

* fix typo
2018-01-02 11:01:42 -05:00
Amadeo Gallardo
ed5c48c81b Updated Debugging Tests for VSCode (#3605)
The launch configuration code provided is not compatible with VSCode since version 1.19.
The proposed documentation change is based on the response by a VSCode team member.

References:
https://github.com/facebookincubator/create-react-app/issues/3602#issuecomment-352075571
https://github.com/Microsoft/vscode/issues/40293#issuecomment-352017028
2017-12-18 15:36:32 -05:00
Nils Magnus Englund
bd682de1f6 Fixed typo in webpack.config.dev.js (#3601)
Replaced `it's` with `its`
2017-12-15 13:17:33 -05:00
Rahul Chanila
a1c5b8f705 Updates comment to reflect codebase (#3576)
the code got updated from `detect()` to `choosePort` while the comment did not.
2017-12-10 21:10:19 -05:00
Ian Sutherland
af291f3cb6 Add mjs and jsx filename extensions to file-loader exclude pattern (#3537) 2017-12-07 13:20:45 -05:00
Dan Abramov
9af042263f Unmount the App in the default test (#3511) 2017-11-27 22:32:57 +00:00
Aaron Lamb
770fdf4ba1 Update User Guide with deploying to GitHub User pages (#3510) 2017-11-27 16:28:42 -05:00
Gavin Gilmour
032e62196e Update Prettier editor integration link (#3503) 2017-11-25 13:52:32 +00:00
Joe Haddad
c789794c36 Fix run-time error unregistering (#3474) 2017-11-20 23:23:00 -05:00
JANG SUN HYUK
657d145f34 Fix misspelling (#3468) 2017-11-19 16:16:41 +00:00
Misha Khokhlov
47af4b42cd Fix broken link to href-no-hash eslint rule (#3460)
This fixes the broken link to removed `href-no-hash.md` file, that is no longer available in the [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) plugin (since [6.0.0](a14617528c/CHANGELOG.md))
2017-11-17 05:17:25 -08:00
Jeffrey Posnick
daf8df1ab3 Add a localhost-only log message pointing folks to the PWA docs. (#3455) 2017-11-15 13:51:35 -05:00
vannio
801fec286e Fix dead link (#3453)
Fix another dead link
2017-11-15 11:41:07 +00:00
Matt Morgis
b555192b43 Explain how to debug tests (#2992)
* docs: adding section about debugging tests

* docs: removing node-inspector references

* docs: replacing terminal command with npm script

* Update README.md
2017-11-14 08:05:34 -05:00
Trevor Brindle
756a9a0fa8 add —use-npm flag to bypass yarn (#3409)
* add —use-npm flag to bypass yarn

* add e2e test for —use-npm flag
2017-11-09 14:03:40 -05:00
Joe Lim
4bec877178 Improve eject message (#3416)
* improve eject message

* cross os implementation
2017-11-07 13:37:40 -05:00
Ovidiu Cherecheș
5b4ff563eb Export dismissRuntimeErrors function (#3414) 2017-11-05 13:41:56 -05:00
Joe Lim
36cd35d684 Refactor extra watch options regex to react-dev-utils (#3362)
* extra watch options regex to react-dev-utils

* fix regex

* add test

* fix eslint error

* include react-dev-utils test in CI script

* attempt to fix import error

* attempt to fix error on CI

* Update .eslintrc
2017-11-03 22:23:31 -04:00
Dan Abramov
4b55193f0a Publish
- react-scripts@1.0.17
2017-11-03 18:27:41 +00:00
Dan Abramov
5811d55f70 Use new WebpackDevServer option (#3401) 2017-11-03 18:18:57 +00:00
Loren Sands-Ramshaw
90c83f7927 Fix grammar in README (#3394)
"subway" by itself is not a proper noun
2017-11-03 18:11:12 +00:00
Kenneth Auchenberg
2cb48716ec Add link to VS Code troubleshooting guide (#3399)
* Add link to VS Code troubleshooting guide

* Update README.md
2017-11-03 18:09:29 +00:00