Commit Graph

935 Commits

Author SHA1 Message Date
Jack Cross
ea2bcb7f59 Use readConfigFile instead of require for tsconfig (#7248) 2019-08-07 21:00:56 +03:00
dominic scanlan
65a891c2e0 Optimise templates for Lighthouse (#7482) 2019-08-07 12:29:28 +03:00
Igor Muchychka
ae671dc9fe Specify roots in Jest config (#7480) 2019-08-06 20:42:57 -07:00
Andrew Luca
914c95e87f Resolve relative paths for preprocessor styles (#5829)
preprocessor will output sourceMap by default
then check if sourceMaps are needed on resolve-url-loader

Fixes #4653
2019-08-05 20:28:09 -07:00
Sibiraj
066053c8b7 Set jsonpFunction to prevent conflicts (#5951) 2019-08-05 11:24:46 +03:00
Darius Tall
30fc0bf5ed Suggest jsx: "react" in tsconfig (#7472) 2019-08-03 17:21:51 -07:00
Brody McKee
404af90d9a Add ESLint 6 support (#7415) 2019-07-28 15:05:54 +03:00
Brody McKee
cbad256a4a Add explicit check for --watchAll=false (#7433)
Resolves #7180.
2019-07-26 12:26:57 -06:00
Alex Guerra
58fad404cd Update url-loader to 2.0.1
This closes #7359 by making IMAGE_INLINE_SIZE_LIMIT=0 actually disable image inlining.

We use url-loader's `limit` option to set the line at which images will be inlined, and we basically expose this option to our end users via the IMAGE_INLINE_SIZE_LIMIT environment variable. Most people using it want to disable inlining images all together (the major motivator for adding it at all was I think for strict CSP), and our documentation said setting the value to zero would do that. However, it did the opposite: url-loader treated zero as "no limit".

The update to 2.x fixes this; zero means nothing gets inlined. The other changes from the version bump shouldn't affect us:
- minimum node version is 8.9.x, we already require 8.10.x
- the limit was "greater than", is now "greater than or equal to"
2019-07-18 15:56:16 -05:00
Brody McKee
3495286f8f Allow extending config used in eslint-loader (#7036) 2019-07-16 12:17:52 +03:00
Sudhir Mitharwal
dc50dd320e Allow title to be set when importing SVGs (#7118) 2019-07-15 17:54:19 +03:00
Min ho Kim
7c0dfef237 Fix various typos (#7355) 2019-07-15 17:12:35 +03:00
Brian Muenzenmeyer
4c0d8b64aa fix(eject): guard against empty key before access (#7289)
closes #7288
2019-07-02 20:44:03 -04:00
Ian Sutherland
a88a4c3af6 Upgrade webpack to 4.35.0 to fix dynamic import issue (#7257)
* Upgrade webpack to 4.35.0 to fix dynamic import issue

* Add a test maybe?
2019-06-24 12:25:15 -06:00
Peter Bengtsson
9d70c7afab Add environment variable to control image inlining threshold (#6060)
Fixes #3437
2019-06-17 21:25:39 -07:00
Ian Schmitz
45197e67fd Update @typescript-eslint package versions (#7222) 2019-06-14 11:14:01 -07:00
Sebastian Silbermann
820a521b3c Update fsevents dependency version (#7131) 2019-05-29 11:52:20 +03:00
Ian Sutherland
8e32ce57d0 Upgrade svgr to 4.2.0 (#6877) 2019-05-24 09:53:34 -06:00
James Friedman
e2f43a06a6 Allow additional Jest config keys (#6055) 2019-05-12 14:30:58 +03:00
Ian Sutherland
57ef103440 Publish
- babel-preset-react-app@9.0.0
 - create-react-app@3.0.1
 - eslint-config-react-app@4.0.1
 - react-app-polyfill@1.0.1
 - react-dev-utils@9.0.1
 - react-error-overlay@5.1.6
 - react-scripts@3.0.1
2019-05-08 09:36:40 -06:00
Ian Schmitz
4542185dea Unpin babel-jest (#7007) 2019-05-07 10:37:12 -07:00
Ian Schmitz
bf886bc49f Temporary fix for babel-jest preflight error (#7002)
* Temporary fix for babel-jest preflight error

* Update babel-jest in react-error-overlay
2019-05-07 06:51:47 -07:00
Ian Schmitz
4397d069d9 Disable default-case lint rule for TypeScript (#6937) 2019-05-03 13:22:09 -07:00
Maël Nison
b36d1ea1aa Adds the configuration for PnP/Typescript (#6856)
* Adds the configuration for PnP/Typescript

* Adds the header

* Bumps ts-pnp

* Bumps fork-ts-checker-webpack-plugin
2019-05-01 15:04:44 -06:00
Cory Reed
a2ae8a79c0 Remove Object.assign from MiniCssExtractPlugin options (#6854) 2019-04-29 09:31:50 -06:00
Dallon Feldner
785dd47937 Generate SVG component name in Jest fileTransform (#6706) 2019-04-25 15:35:03 -06:00
Petr Huřťák
73d5579e01 Remove body padding reset from templates (#6300)
* remove padding 0 on body from default styles

* Update index.css
2019-04-24 11:32:05 -06:00
Ian Sutherland
265c1592dc Publish
- babel-plugin-named-asset-import@0.3.2
 - babel-preset-react-app@8.0.0
 - confusing-browser-globals@1.0.7
 - create-react-app@3.0.0
 - eslint-config-react-app@4.0.0
 - react-app-polyfill@1.0.0
 - react-dev-utils@9.0.0
 - react-error-overlay@5.1.5
 - react-scripts@3.0.0
2019-04-22 12:50:29 -06:00
Romain François
e11ebfa0e8 Update fsevents dependency version (#6843)
Fixes #6852.

I update the dependency version of fsevents because old versions was vulnerable (CWE-59). Vulnerability found with snyk.io report
2019-04-20 18:14:46 -07:00
Jack Zhao
200b98b81a Remove no-watch flag in favor of watchAll=false (#6848) 2019-04-19 09:35:46 +03:00
Luiz Felipe Gonçalves
022b98418e Change Create React App version in react-scripts eject warning (#6845)
* fix: change CRA version in eject warning

* Update eject.js
2019-04-18 21:30:41 -06:00
Ian Schmitz
f5b0aac411 Relax ESLint version range (#6840)
* Relax eslint version range

* Use semver package to compare versions during preflight check

* Cleanup package.json files whitespace
2019-04-17 19:46:47 -07:00
Robert van Steen
e7a2d6168a Set baseUrl from jsconfig.json/tsconfig.json (#6656)
* Set baseUrl from jsconfig.json/tsconfig.json

* Resolve the path for loading modules

* Add tests for jsconfig.json

* Add jsconfig.json

* Update packages/react-scripts/scripts/start.js

* Move baseUrl test to config folder

* Remove alias test

* Use chalk from react-dev-utils

* Add lost absolute file for typescript baseUrl test

* Update packages/react-scripts/config/modules.js

* Update other references of useTypeScript to hasTsConfig

* Fix casing of TypeScript

* Keep respecting NODE_PATH for now to support multiple module paths.

* Add test for NODE_PATH

* Add fallback if NODE_PATH is not set.

* Fix node path behavior tests

* Remove debugging code from behavior test suite

* Remove more debugging code

* Show NODE_PATH deprecation warning during build


Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com>
Co-authored-by: Jack Zhao <jzhao@fb.com>
2019-04-16 15:08:24 -06:00
Philip Harrison
ced3fd49ca Add directory details to packages/* package.json (#6826)
Specifying the directory as part of the repository field in a
package.json allows third party tools to provide better support when
working with monorepos. For example, it allows them to correctly
construct a commit diff for a specific package.

This format was accepted by npm in [npm/rfcs#19](https://github.com/npm/rfcs/pull/19).
2019-04-16 07:58:03 -07:00
Nathan Brown
207d9315b1 Update testMatch to also be compatible with Jest 24 (#6313) 2019-04-15 20:44:56 -07:00
Ian Sutherland
9048dd66a0 Move list of files under files key in asset manifest (#6821) 2019-04-15 21:35:25 -06:00
Travis Fischer
50c1884e62 Fix react-scripts peer dependencies link local issue (#6579) (#6580) 2019-04-15 20:59:12 -06:00
Raphael.dev
dac046df1f Fix code comment typo (#6775) 2019-04-08 19:57:02 -07:00
ZHAO Jinxiang
ebabd18333 Change NODE_ENV and PUBLIC_URL to readonly (#6750) 2019-04-07 20:18:32 +03:00
Ian Schmitz
91ddd618be Update dependency versions (#6767)
Includes only minor/patch version bumps.
2019-04-06 15:16:08 -07:00
Hrusikesh Panda
550274e307 Adds PostCSS Normalize (#5810)
* Add postcss-normalize plugin

* Configure PostCSS Normalize

* Add documentation

* Include the doc in sidebar

* Fix the id in sidebar.json

* Update adding-css-reset.md


Co-authored-by: Jack Zhao <jzhao@fb.com>
Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
2019-04-05 10:23:59 -06:00
Pradeep Sekar
ffcd896add Update to workbox-webpack-plugin v4 (#6725)
* Update to workbox-webpack-plugin v4

* Update workbox-webpack-plugin to 4.2.0


Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
2019-04-05 09:48:01 -06:00
Andrew Luca
b8a47d93cf Replace deprecated SFC with FunctionComponent (#6746) 2019-04-04 23:30:10 -06:00
Endilie Yacop Sucipto
3e336d91e0 fix: terser-webpack-plugin hanging on WSL (#6732)
* fix: terser-webpack-plugin hanging on WSL

* nits

* Merge branch 'master' into terser-parallel-bug-wsl

Co-authored-by: Jack Zhao <jzhao@fb.com>
2019-04-04 23:24:27 -06:00
Mateusz Burzyński
42640dfce1 Only suggest that tsconfig.json is incorrect when SyntaxError is caught (#6160)
Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
2019-04-04 15:18:15 -06:00
Ian Sutherland
001c23eff4 Enable futureEmitAssets in webpack config (#6696) 2019-04-04 14:35:48 -06:00
Ian Schmitz
76fea02277 Cleanup Jest config (#6654)
General cleanup after the [Jest 24 PR](#6278). 

This also includes `jsdom@14` via https://www.npmjs.com/package/jest-environment-jsdom-fourteen. Since we have a node >= 8.10 requirement, we are able to use the latest version of `jsdom` which includes additional implementations of browser APIs such as `MutationObserver` (which we had an issue filed for over at #6617).

/cc @SimenB. Is there more you recommend we do to cleanup our [Jest config](b0cbf2caa1/packages/react-scripts/scripts/utils/createJestConfig.js) for TypeScript?

Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
2019-04-04 11:00:00 -06:00
Cody Olsen
9514cb88ab Remove --coverage + --watch workaround (#4176) 2019-04-02 10:49:36 -07:00
Ian Sutherland
b4247378a3 Change app component declaration from arrow function to regular function (#6655)
* Change app component declaration from arrow function to regular function

* Change TypeScript template back to an arrow function
2019-03-18 20:18:21 -06:00
Jack Zhao
4734d4ef21 Merge branch 'master' into master 2019-03-18 17:50:52 -07:00