* - [x] Upgrade to webpack 4.8.X
- [x] Utilize webpack 4 development and production modes
- [x] Upgrade webpack dev server
- [x] Webpack 4 compatible release of thread-loader
- [x] Webpack 4 compatible release of HtmlWebpackPlugin
- [x] Webpack 4 compatible release of SwPrecacheWebpackPlugin
- [x] Webpack 4 compatible release of WebpackManifestPlugin
- [x] Update README
- [x] Update WebpackDevServerUtils
- [x] Update InterpolateHtmlPlugin
- [x] Update ModuleScopePlugin
- [x] Update WatchMissingNodeModulesPlugin
- [x] Move UglifyJS options to webpack 4 optimize
- [x] Move InterpolateHtmlPlugin to make it tapable on HtmlWebpackPlugin
- [x] vendor splitting via splitChunks.splitChunks (https://twitter.com/wSokra/status/969633336732905474)
- [x] long term caching via splitChunks.runtimeChunk (https://twitter.com/wSokra/status/969679223278505985)
- [x] Make sure process.env.NODE_ENV is proxied correctly to `react-error-overlay`
- [x] Implicit webpack.NamedModulesPlugin in dev config as its default in webpack 4
- [x] Disable webpack performance hints as we have our own filesize reporter
- [x] Replace ExtractTextPlugin with MiniCssExtractPlugin
- [x] Switch to css whole file minification via OptimizeCSSAssetsPlugin rather than per module css minification to gain performance
* disable module concatenation
* fix cleanup
* fix optimization
* restore tmp removal
* preserve
* fix css tests
* fix test run
* fix svg test
* revert tmp dir
* fix import
* fix import
* help debugging
* fix tests
* fix sass test
* restore cleanup
- [x] Utilize webpack 4 development and production modes
- [x] Upgrade webpack dev server
- [x] Webpack 4 compatible release of thread-loader
- [x] Webpack 4 compatible release of HtmlWebpackPlugin
- [x] Webpack 4 compatible release of SwPrecacheWebpackPlugin
- [x] Webpack 4 compatible release of WebpackManifestPlugin
- [x] Update README
- [x] Update WebpackDevServerUtils
- [x] Update InterpolateHtmlPlugin
- [x] Update ModuleScopePlugin
- [x] Update WatchMissingNodeModulesPlugin
- [x] Move UglifyJS options to webpack 4 optimize
- [x] Move InterpolateHtmlPlugin to make it tapable on HtmlWebpackPlugin
- [x] vendor splitting via splitChunks.splitChunks (https://twitter.com/wSokra/status/969633336732905474)
- [x] long term caching via splitChunks.runtimeChunk (https://twitter.com/wSokra/status/969679223278505985)
- [x] Make sure process.env.NODE_ENV is proxied correctly to `react-error-overlay`
- [x] Implicit webpack.NamedModulesPlugin in dev config as its default in webpack 4
- [x] Disable webpack performance hints as we have our own filesize reporter
- [x] Replace ExtractTextPlugin with MiniCssExtractPlugin
- [x] Switch to css whole file minification via OptimizeCSSAssetsPlugin rather than per module css minification to gain performance
Summary:
The `hasSlash` method uses `path.substr(path, path.length - 1)` to
remove the last character from `path`. Clearly, the first parameter is
suspect; it should be `0`. The code works as written, but only very
accidentally: the first parameter is coerced by `ToNumber` to `NaN`,
which is then coerced by `ToInteger` to `+0`, per [the spec][1].
[1]: https://www.ecma-international.org/ecma-262/6.0/#sec-string.prototype.substr
Test Plan:
Reading the spec should be sufficient. To verify in the Real World:
```js
const path = "has-slash-but-does-not-need-slash/"
const a = path.substr(path, path.length - 1);
const b = path.substr(0, path.length - 1);
console.log(a === b); // true
console.log(a); // has-slash-but-does-not-need-slash
```
wchargin-branch: ensureslash-accidental-coercion
* Installs and adds sass loader task in webpack for dev environment.
* Uses Timer's branch of sass-loader without node-sass dependency.
* Adds method for handling SASS modules.
* Fixes extension of excluded files when looking for scss modules.
* Adds support for both .scss and .sass extensions.
* Uses ExtractTextPlugin with sass-loader to bundle styles for the production build.
* Bundles SASS modules for the production build.
* Uses the latest version of sass-loader.
* Adds function to create different rules for style loaders in dev environment.
* Abstracts style loaders to a common function to avoid repetition.
* Simplifies the common function that creates style loaders.
* Creates assets for testing SASS/SCSS support.
* Creates mock components and unit tests for SASS and SCSS with and without modules.
* Creates integration tests for SASS/SCSS support.
* Adds node-sass as a template dependency so sass-loader can be tested.
* Includes sass tests when test component is mounted.
* Fixes asserted module name for sass and scss modules tests.
* Removes tests against css imports in SCSS and SASS files.
* Updates sass-loader to v7.
* Uses getCSSModuleLocalIdent from react-dev-utils.
* Fixes tests to match the use of getCSSModuleLocalIdent.
* Improves readability of getStyleLoader function.
* Uses postcss after sass.
* Refactors dev config to simplify common function for style loaders.
* Refactors prod config to simplify common function for style loaders.
* Use importLoaders config according to css-loader docs.
* Revert to use ecma 5 in uglifyOptions
* remove explicit ecma version from uglifyOptions settings
The defaults are already what we want
* be explicit of where we use ecma: 8 and ecma: 5
* Add explicit dep on plugin-proposal-object-rest-spread to babel-preset-react-app
* Bump babel-related deps to beta.42
* Pass useBuiltIns directly to react-preset
* Run yarn after ejecting.
* On eject, choose to run yarn instead of npm if yarn is available.
* Move monorepo to react-dev-utils.
* Fix lint.
* Rename monorepo to workspaceUtils.
* Add react-dev-utils dep for create-react-app.
* getMonorepo -> findMonorepo
* add default value for globPatterns
without this, the latest alpha broke on start
```
/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:130
.reduce(
^
TypeError: Cannot read property 'reduce' of undefined
at findPkgs (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:130:6)
at getMonorepoPkgPaths (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:143:22)
at Object.<anonymous> (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:155:55)
at Module._compile (module.js:643:30)
at Object.Module._extensions..js (module.js:654:10)
at Module.load (module.js:556:32)
at tryModuleLoad (module.js:499:12)
at Function.Module._load (module.js:491:3)
at Module.require (module.js:587:17)
at require (internal/module.js:11:18)
error Command failed with exit code 1.
```
* also check for pkgPatterns for null
* Update paths.js
* Add named asset import for svg files via babel plugin and webpack loader.
* Fix failing e2e test
* Switched to svgr loader
* Updated SVG component test
* Disable named asset import plugin in test environment
* Added tests for including SVG in CSS
* Update tests
* Moved babel plugin config into webpack config
* Support for multiple source paths via package.json srcPaths entry.
Initial support for yarn workspace.
Support lerna workspace, fix for when to use template files.
Remove support for specifying srcPaths in package.json.
Re-enable transpilation caching.
* Clean up, use file matching (similar to original) in webpack configs instead of matching function.
* Remove package lock files.
* Fix for eject.
Note: monorepos won't work after eject.
Can be fixed easily with JEST 22.0.?+ which has file pattern matches against realpaths.
* Filter tests to run only tests in monorepo components included by the app.
(Not sure this is desireable, might be cool to be able to easily run all tests in monorepo from one app.)
* Fix conditions for when to use template.
* Fix eject.
* Remove code that is not needed w/ Jest 22.
* Include all cra-comp tests in monorepo instead of trying to include only tests that are dependencies of app.
(tests can be easily filtered via jest cli if desired, e.g. 'npm test -- myapp comp1')
* Pin find-pkg version.
* Hopefully fix jest test file matching on windows by removing first slash.
* E2E tests for monorepo.
* Run monorepo tests in CI.
* Fix and test post-eject build.
* Fix e2e test.
* Fix test suite names in appveyor.
* Include individual package dirs as srcPaths instead of top-level monorepo root.
Fixes build/start after eject.
* Fix running tests after eject.
* Clean up test workspace, add some verifcations.
* Cleanup.
* Try to fix hang when running test on appveyor.
* Don't write babel or lint config to package.json when ejecting.
* Incorporate review comments.
* Simply monorepo pkg finder
* Only include monorepo pkgs if app itself is included in monorepo
* Check for specific tests in e2e
* Fixes for windows.
* Fix for kitchensink mocha tests compiling.
* Add lerna monorepo test.
* Fix lerna bootstrap on windows.
* Incorporate more review comments:
* remove support for lerna w/o yarn workspace
* add react and react-dom as devDeps to comp1 and comp2
* Add monorepo info to user guide.
* Create git repo with initial commit
* Fixe commit message
* Added the git repo to the docs
* Bail if we are in a mercurial repository
* Removed Chore from commit mesage
* Create repo after installing react and react-dom
* Removed docs
* Commit changes when ejecting
* Update after review
* git add -A instead of git add . after code review
