Commit Graph

12 Commits

Author SHA1 Message Date
Dan Ristea
772a447247 Autodetect JetBrains IDEs (#2754)
Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode

Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those.

Removed older integrations of AppCode, IntelliJ IDEA

https://www.jetbrains.com/help/idea/opening-files-from-command-line.html
https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html

Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12
Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM

Relates to #2636
2017-09-09 22:25:19 +02:00
Dan Ristea
4b856a7c79 Support PyCharm in launchEditor (#2740)
PyCharm has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those.

https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html

Tested with PyCharm Pro 2017.1.4 on MacOS 10.12
2017-09-09 22:25:19 +02:00
Trygve Aaberge
fc2057c5f0 Reorder vim arguments in launchEditor so --remote works (#2723)
This allows you to set REACT_EDITOR to 'vim --remote', so the file can
be opened in an already running vim process. When using vim without
remote, it works in the same way as before.

When launching vim without --remote, the order of the line and path
arguments doesn't matter. However, when using --remote the line argument
has to precede the path. This happens to be the same as joe and emacs
uses, so the vim cases were just moved there.

I haven't tested this with mvim, but the documentation says the same as
the vim documentation, so I assume it works the same.
2017-09-09 22:25:18 +02:00
Dan Abramov
10bd98cbe5 Reformat source code with Prettier 1.5.2 2017-08-07 16:16:16 +02:00
Pete Nykänen
ae62952a4c Add Brackets to launchEditor.js (#2637) 2017-08-07 16:10:12 +02:00
Marius Wirtherle
2a4fe99c62 docs: added REACT_EDITOR to Advanced Configuration section (#2445)
* docs: added REACT_EDITOR to `Advanced Configuration` section

* Update README.md

* Update launchEditor.js
2017-08-07 16:05:30 +02:00
Levin Rickert
b9cbf5c4bd Auto-detect running editor on Windows for error overlay (#2552)
* Auto-detect running editor on Windows for error overlay

* Ignore process output if powershell call fails

* Support Notepad++
2017-08-07 16:05:30 +02:00
Mikhail Osher
b68c39e69c Support PhpStorm in launchEditor (#2622)
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line.
It seems to work even if `<projectPath>` is omitted (commit 02f88ba157).

Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.
2017-08-07 16:02:40 +02:00
Marius Wirtherle
1cb5fbb152 Add WebStorm >2017 launchEditor Support (#2414) 2017-08-07 16:00:38 +02:00
Malcolm
d3e85364fe Add WSL support to launchEditor utility (#2282) 2017-05-20 17:52:58 +01:00
Dan Abramov
10c734b66a Print error messages for editor integration (#2150) 2017-05-14 23:52:27 +01:00
Dan Abramov
4434467a43 Click to view source from error overlay (#2141)
* Click to view source

* Update package.json

* Update package.json

* Fix lint
2017-05-14 12:17:05 +01:00