Commit Graph

139 Commits

Author SHA1 Message Date
Forbes Lindesay
a6cd6f30cb Update webpack version note (#2798)
* Remove note about webpackHotDevClient being webpack 1.0 only

It must work in webpack 2 since create-react-app is still using it and is using webpack 2 now.

It would be great if you could add some kind of note about how it differs from the default webpack hot reloaders.

* Update README.md

* Update README.md
2017-09-09 22:25:56 +02:00
Owen Flood
5eb7c7359a Don't prompt to install serve if already installed (#2761)
* dont prompt if serve is already installed

* change name for readability

* Pin the version
2017-09-09 22:25:20 +02:00
Dan Ristea
772a447247 Autodetect JetBrains IDEs (#2754)
Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode

Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those.

Removed older integrations of AppCode, IntelliJ IDEA

https://www.jetbrains.com/help/idea/opening-files-from-command-line.html
https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html

Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12
Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM

Relates to #2636
2017-09-09 22:25:19 +02:00
Dan Ristea
4b856a7c79 Support PyCharm in launchEditor (#2740)
PyCharm has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those.

https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html

Tested with PyCharm Pro 2017.1.4 on MacOS 10.12
2017-09-09 22:25:19 +02:00
Trygve Aaberge
fc2057c5f0 Reorder vim arguments in launchEditor so --remote works (#2723)
This allows you to set REACT_EDITOR to 'vim --remote', so the file can
be opened in an already running vim process. When using vim without
remote, it works in the same way as before.

When launching vim without --remote, the order of the line and path
arguments doesn't matter. However, when using --remote the line argument
has to precede the path. This happens to be the same as joe and emacs
uses, so the vim cases were just moved there.

I haven't tested this with mvim, but the documentation says the same as
the vim documentation, so I assume it works the same.
2017-09-09 22:25:18 +02:00
Dan Abramov
ae40264af6 Publish
- create-react-app@1.3.3
 - react-dev-utils@3.0.2
 - react-error-overlay@1.0.9
 - react-scripts@1.0.10
2017-09-09 22:25:09 +02:00
Patrick Hooper
3bc8dcdce5 Downgrade strip-ansi package to 3.0.1 (#2692) 2017-08-07 16:17:41 +02:00
Dan Abramov
8d156edec6 Publish
- babel-preset-react-app@3.0.1
 - create-react-app@1.3.2
 - eslint-config-react-app@1.0.5
 - react-dev-utils@3.0.1
 - react-error-overlay@1.0.8
 - react-scripts@1.0.8
2017-08-07 16:17:28 +02:00
Dan Abramov
10bd98cbe5 Reformat source code with Prettier 1.5.2 2017-08-07 16:16:16 +02:00
Dan Abramov
55df6e1130 Bump dependencies (#2658) 2017-08-07 16:11:39 +02:00
Dan Abramov
a9c8b817f3 Warn about large bundle sizes (#2648) 2017-08-07 16:10:41 +02:00
Pete Nykänen
ae62952a4c Add Brackets to launchEditor.js (#2637) 2017-08-07 16:10:12 +02:00
Marius Wirtherle
2a4fe99c62 docs: added REACT_EDITOR to Advanced Configuration section (#2445)
* docs: added REACT_EDITOR to `Advanced Configuration` section

* Update README.md

* Update launchEditor.js
2017-08-07 16:05:30 +02:00
Levin Rickert
b9cbf5c4bd Auto-detect running editor on Windows for error overlay (#2552)
* Auto-detect running editor on Windows for error overlay

* Ignore process output if powershell call fails

* Support Notepad++
2017-08-07 16:05:30 +02:00
Mikhail Osher
b68c39e69c Support PhpStorm in launchEditor (#2622)
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line.
It seems to work even if `<projectPath>` is omitted (commit 02f88ba157).

Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.
2017-08-07 16:02:40 +02:00
Levin Rickert
d68ed30f2c Show warning when trying to run on port below 1024 without admin permissions under Linux (#2518) 2017-08-07 16:02:05 +02:00
Joe Haddad
349caa452d Unscope detect-port (#2483)
Resolves #2481
2017-08-07 16:00:47 +02:00
Marius Wirtherle
1cb5fbb152 Add WebStorm >2017 launchEditor Support (#2414) 2017-08-07 16:00:38 +02:00
Frédéric Miserey
4c80b02d68 Fix detection of parent directory in ModuleScopePlugin (#2405)
* Fix detection of parent directory

* Correct parent directory detection fix

Add windows specific path and extend to issuer path
2017-08-07 16:00:37 +02:00
Dan Abramov
c16a178a00 Suggest just "yarn build" (#2385) 2017-08-07 16:00:37 +02:00
Dan Abramov
bef6ec65d2 Publish
- react-dev-utils@3.0.0
 - react-error-overlay@1.0.7
 - react-scripts@1.0.7
2017-08-07 16:00:37 +02:00
Jin Zheng
6a48c7cab0 Print file sizes with correct build folder path. (#2361)
* Print file sizes with correct build folder path.

* Just use the print the basename.
2017-08-07 15:59:41 +02:00
William Monk
6bd33bd2ec Merge remote-tracking branch 'facebook/master' 2017-05-25 08:38:39 +01:00
Dan Abramov
7a1873c0a7 Publish
- eslint-config-react-app@1.0.4
 - react-dev-utils@2.0.1
 - react-error-overlay@1.0.6
 - react-scripts@1.0.6
2017-05-24 13:22:25 +01:00
Joe Haddad
a29808a2c8 Don't resolve localhost if on network (#2332)
* Don't resolve if on network

* Update WebpackDevServerUtils.js
2017-05-24 11:00:24 +01:00
Dan Abramov
2558c3e32f Publish
- eslint-config-react-app@1.0.3
 - react-dev-utils@2.0.0
 - react-error-overlay@1.0.5
 - react-scripts@1.0.5
2017-05-22 17:09:28 +01:00
Dan Abramov
25f81f2bea Files in public/ folder should not be requested through proxy (#2326) 2017-05-22 17:04:17 +01:00
Dan Abramov
9cfa3552ba Limit console warnings to 5 files at most (#2327) 2017-05-22 16:36:53 +01:00
William Monk
fc46e5e11c Merge create-react-app@1.0.4 2017-05-22 13:48:45 +01:00
Pavol Madar
0d1521aabf Remove connect-history-api-fallback and cross-spawn dependencies from react-scripts (#751) (#2320) 2017-05-22 12:46:51 +01:00
William Monk
32f52bebfe Merge remote-tracking branch 'facebook/master' 2017-05-21 21:27:47 +01:00
Dan Abramov
d649b8a0de Publish
- eslint-config-react-app@1.0.2
 - react-dev-utils@1.0.3
 - react-error-overlay@1.0.3
 - react-scripts@1.0.3
2017-05-21 20:56:22 +01:00
Joe Haddad
2430b5615f Ensure address is private (#2297)
* Ensure address is private
Resolves #2296

* adjust rule

* Update WebpackDevServerUtils.js
2017-05-21 20:44:28 +01:00
Broda Noel
7348ca9bd1 Wrap console calls into a check (#2301)
* Wrap console calls into a check

* Add another check
2017-05-21 20:42:28 +01:00
Dan Abramov
ae0cb23dc9 Publish
- react-dev-utils@1.0.2
 - react-error-overlay@1.0.2
 - react-scripts@1.0.2
2017-05-20 19:20:46 +01:00
pmadar
a1749f9154 Remove unnecessary dependencies(#751) (#2283)
* Remove unnecessary dependencies(#751)

* Sort alphabetically
2017-05-20 19:08:58 +01:00
Jeffrey Posnick
eadfad28f4 Provide a no-op SW that will be served by the dev environment. (#2276)
* Provide a no-op SW that will be served by the dev environment.

* Hide no-op service worker from user
2017-05-20 19:07:43 +01:00
Dan Abramov
d76c1b78eb Wrap console calls into a check (#2290) 2017-05-20 19:06:48 +01:00
Dan Abramov
f3ff3f2473 Add missing license headers 2017-05-20 18:59:22 +01:00
Malcolm
d3e85364fe Add WSL support to launchEditor utility (#2282) 2017-05-20 17:52:58 +01:00
Jonathan
68cd59837e Fix missing dependency (#2269)
* Adding missing dependency

* Pinning text-table dependency
2017-05-19 22:57:11 +01:00
Dan Abramov
cd5c6d5717 Publish
- eslint-config-react-app@1.0.1
 - react-dev-utils@1.0.1
 - react-error-overlay@1.0.1
 - react-scripts@1.0.1
2017-05-19 20:22:12 +01:00
chyipin
1834cb5dbd Show customized build path for serve instruction (#2229)
* Show customized build path for serve instruction

* Remove cyan
2017-05-19 17:18:00 +01:00
Joe Haddad
70a7f28e2b Add explicit package dependence (#2243)
Closes #2232
2017-05-19 08:19:04 -04:00
Dan Abramov
6c8b18b0cd Improve interaction between compile and runtime overlays (#2219) 2017-05-18 23:07:56 +01:00
Dan Abramov
43b819c2bb "rule keywords" => "keywords" 2017-05-18 22:46:30 +01:00
Dan Abramov
55afd862c8 Move error overlay middleware (#2216) 2017-05-18 21:01:26 +01:00
Dan Abramov
07c75aa5fd Replace text-align: start with left to fix Edge (#2215) 2017-05-18 19:04:43 +01:00
Dan Abramov
8dc9217b61 Move more logic from react-scripts to react-dev-utils (#2209)
* Show warnings for builds

* Move WebpackDevServer helpers into react-dev-utils
2017-05-18 12:26:18 +01:00
Brian Vaughn
0681e24531 Tweaked error overlay styles (pt2) (#2208)
* Fixed several of the issues and nits from PR:

* Moved margin between header and file name to header, so when content was scrolled, the header would remain more separate
* Made build-time and runtime overlays better match
* Secondary error <pre> style now uses yellow bg instead of red
* 'Scrollable Header' (see above comment to why this is necessary) but I did increase the max-height from 35% to 50%.
* Fixed header and 'X' button vertical alignment

* Temporary stack margin fix

* Move "N errors" to the top
2017-05-18 12:25:43 +01:00