Commit Graph

175 Commits

Author SHA1 Message Date
Blaine Kasten
8ec99b6fff Suggest jest-enzyme for simplifying test matchers (#994)
* Suggest jest-enzyme for simplifying test matchers

* Update README.md

* Update README.md
2017-02-11 23:05:54 +00:00
Joe Haddad
12288836e1 Upgrade webpack (#1291)
* Upgrade webpack

* Address more webpack v2 ...

* Update html-webpack-plugin

* Remove LoaderOptionsPlugin from dev config

* ExtractTextPlugin still uses webpack 1 syntax
... and doesn't support complex options (yet)

* Grammar nit

* Update extract text webpack plugin

* - Remove webpack.LoaderOptionsPlugin
- Update deps

* Lerna hoists packages

* Update extract-text-webpack-plugin

* Update webpack-dev-server

* Remove imports for the tests

* stop removing babelrc
2017-02-11 14:11:00 -05:00
Dan Abramov
9f1276314d Add additional info about env variables 2017-02-11 14:00:26 +00:00
Dan Abramov
dc4e8bb462 Make index.html interpolation instructions less clashing with env syntax 2017-02-11 13:45:30 +00:00
Joe Haddad
67e6cf5a52 Publish
- babel-preset-react-app@2.1.0
 - create-react-app@1.0.4
 - eslint-config-react-app@0.5.1
 - react-dev-utils@0.5.0
 - react-scripts@0.9.0
2017-02-10 22:33:41 -05:00
Joe Haddad
15e0b98479 Upgrade dependencies (#1522)
* Upgrade dependencies

* Re-add caret
2017-02-10 21:31:15 -05:00
Anders D. Johnson
b0b0e6da55 fix: add yarn gitignores (#1507)
* fix: add yarn gitignores to template

* fix: add yarn gitignores to root

* fix: add wildcard to npm-debug.log ignore
2017-02-11 01:30:11 +00:00
Brandon Istenes
e19b0f6373 Make build exit with error code when interrupted (#1496)
* Make build exit with error code when interrupted

This addresses issue #1493.

Current behavior is that `npm run build` exits code 0 without creating a bundle when interrupted. This change makes the build script catch catchable interruptions and exit with the appropriate error code.

* Better error messages for kill signals

* Don't catch SIGINT

Ctrl+C should exit silently, and already produces a non-zero exit code when sent to the console while `npm run build` is running. Exit code 0 is produced if SIGINT is sent directly to the `node build.js` process, but this is unlikely to happen. A SIGINT handler in `build.js` will also be triggered by Ctrl+C in the console, potentially producing unnecessary noise.

* Style fix

* No changes needed to build.js

Problem is coming from the parent process, `react-scripts`

* Make react-scripts script handle signals

* Clarify context
2017-02-11 00:12:36 +00:00
Joe Haddad
7a02f9a41a readme: Add Advanced Configuration (#1515)
* Add Advanced Configuration section

* Reference package.json instead

* Add HOST, HTTPS, and CI

* Switch wording from Amazon to a CDN

* Add test runner comment

* Add top-level README link

* Simplify wording

* Link to relevant docs

* Link to apps

* Add .env link

* Simpler links

* Add a CI flag note
2017-02-10 16:20:53 -05:00
Thibault Derousseaux
8e127aaa38 Support relative asset paths for special case (#1489)
* Fix paths in CSS files when homepage is set to "./"

In the production build, ExtractTextPlugin is used to generate a separate CSS file instead of injecting style through JavaScript. This plugin does not work well by default with nested output structure. To fix it, we give it a relative publicPath pointing to the build folder.

* Add section in README to explain how to make builds deployable anywhere

* Apply review requested change

* Apply review changes 2
2017-02-10 00:44:00 -05:00
Joe Haddad
613b584f42 Add PUBLIC_URL env variable for advanced use (#937) (#1504)
* Add `PUBLIC_URL` env variable for advanced use (#937)
* Add support for `PUBLIC_URL` env variable
* Remove unnecessary duplications
* Simplify served path choice logic
* Honor PUBLIC_URL in development
* Add e2e tests

Enables serving static assets from specified host.
2017-02-09 23:15:15 -05:00
Jih-Chi Lee
1d9159de23 Make all react app vars accessible in index.html (#1440)
* Make all vars accessiable in index.html

* Fix wrong env provieded to DefinePlugin

* Separate results from getClientEnvironment

* The `string` should be object instead of string

* Fix accessing wrong field

* Changed variables naming to `raw` and `stringified`

* Remove trailing commas
2017-02-09 22:41:03 -05:00
pd4d10
b999405c67 Add missing '\n' to the end of package.json file (#1510) 2017-02-09 16:36:20 -05:00
Calvin Webster
160d8d13ef clarifying the use of custom environment variables (#1513)
* clarifying the use of custom environment variables

* Tweak
2017-02-09 20:46:47 +00:00
RodrigoHahn
c811a31622 Change "OS X" references to "macOS" (#1511)
Updated README.md to refer to the current rebranding.
2017-02-09 14:41:24 +00:00
Ro Savage
0ac0d116b9 Update comments for webpack loaders 2017-02-09 11:21:02 +13:00
Jay Phelps
9e0e18fd2e UX: Explain why build is failing (#1352) 2017-02-08 15:27:44 -05:00
Joe Haddad
adab23fa00 e2e: Reduce complexity of e2e and improve Jest coverage (#1484) 2017-02-07 23:04:01 -05:00
vulong23
65e6340395 Edit User Guide: Add ESLint config for VS Code users (#1482)
* Add ESLint config for VS Code users

* Update VSC ESLint note to a better solution 

Update VSC ESLint note to a better solution as discussed in Pull Request
2017-02-04 16:47:19 +00:00
Fatih
6424232dc1 Reflect websocket proxy support on README (#1013) (#1483)
* Reflect websocket proxy support on README

* Add 'the'
2017-02-04 15:18:54 +00:00
Valerii
8964dd6f13 - import expect and expect flow (#1463)
- code style
2017-01-30 19:28:16 +00:00
Fabrizio Castellarin
1d586aaf31 E2e jsdom fix (#1470)
* E2E: run tests when react is ready

* Entangle e2e with callbacks

* Remove unused e2e lines
2017-01-30 19:24:12 +00:00
creynders
bc2fc80898 eject: Additionally remove react-scripts from dependencies (#1458)
ATM if react-scripts is (erroneously) declared in `dependencies` instead of `devDependencies` or isn't declared at all, the `eject` script will fail half-way. This change makes it more robust, react-scripts will be removed from either, if present.
2017-01-27 16:26:35 +00:00
Anthony F
dd788b672a Readme: Removes experimental from Jest snapshot (#1453)
Per final comment in #372

`Snapshot rendering should actually be pretty stable / useable after React 15.4.1.
See this post for more info.`
2017-01-26 18:40:12 +00:00
Dan Abramov
da321b2433 Bump Jest version (#1432) 2017-01-24 23:39:42 +00:00
Jonathan Kim
dbb7ffe6a5 Added babel-runtime dependency to deduplicate dependencies when using yarn (#1441) 2017-01-24 17:20:57 +00:00
Alex Driaguine
3bb31ccb0f Added links to tutorials for integrating cra with an api backend (#1437)
* Added Rails link to User Guide

* docs: unify sections for rails and node backend integration

* docs: fix faulty link and indentation
2017-01-24 11:12:01 +00:00
Vasiliy Taranov
65bde54306 Add causes of dev server not detecting changes (#1422)
* Add causes of dev server not detecting changes

Add causes of `npm start` not detecting changes to Troubleshooting chapter of User Guide

* Reworded slightly

* Update README.md
2017-01-23 21:22:55 +01:00
Fabrizio Castellarin
9099570b94 Use a more sophisticated template for end-to-end testing. (#1187)
* Use a more sophisticated template for end-to-end testing.

* Not publish integration tests to npm

* Use "commander" for  cli argv handling

* Handle different scripts version forms and exits without a name given

* Prepare the commands for testing with a template

* Fix dev "template" path

* Add various features to test

* Test various features separately

* Test language features

* Comment unused e2e.sh lines

* Add "development" tests

* Test environment variables

* Test webpack plugins

* Replace kitchensink README

* Switch integration tests from jest to mocha

* Use `fs-extra`

* Use the correct folders

* Do some cleanup

* Print a better message for `--template`

* Test `npm start` with and without https

* Separate fast e2e testing from kitchensink testing

* Hide `--internal-testing-template` (former `--template`) CLI option
2017-01-23 20:43:16 +01:00
Ville Immonen
11cc5aef48 Merge pull request #1367 from facebookincubator/0.8.x
0.8.5
2017-01-09 17:59:11 +02:00
Ville Immonen
a5b838940e Publish
- create-react-app@1.0.3
 - react-scripts@0.8.5
2017-01-09 17:51:41 +02:00
Ville Immonen
24abc5e154 Use yarnpkg alias to run Yarn (#1365)
There’s a common tool included in Hadoop that also has a `yarn` command,
which created issues for users who had Hadoop installed:
* #1257
* #1363

Yarn also installs the command under `yarnpkg` alias (added in
cefa9a368d)
so we can use `yarnpkg` instead of `yarn` to make it more reliable.

This has no effect on users who don't have Hadoop installed, but those
who have won't see errors from falsely detecting Hadoop Yarn as Yarn
the package manager, and they can now also install Yarn to make use of
our Yarn support without the Hadoop Yarn interfering.
2017-01-09 17:27:07 +02:00
Ville Immonen
1b645e2cc4 Use yarnpkg alias to run Yarn (#1365)
There’s a common tool included in Hadoop that also has a `yarn` command,
which created issues for users who had Hadoop installed:
* #1257
* #1363

Yarn also installs the command under `yarnpkg` alias (added in
cefa9a368d)
so we can use `yarnpkg` instead of `yarn` to make it more reliable.

This has no effect on users who don't have Hadoop installed, but those
who have won't see errors from falsely detecting Hadoop Yarn as Yarn
the package manager, and they can now also install Yarn to make use of
our Yarn support without the Hadoop Yarn interfering.
2017-01-09 17:25:31 +02:00
Fatih
25480273b0 Bump babel-loader version (#1009) (#1309) 2017-01-08 05:46:29 -08:00
Paul O’Shannessy
4d7b7544e7 Use npm script hooks to avoid && in deploy script (#1324) 2016-12-30 17:59:27 +02:00
Christian Raidl
a90e2b2eea fix readme: remove double 'we' (#1312) 2016-12-30 17:56:12 +02:00
Johnny Magrippis
e45b08746a Fixes duplicate "is" typo (#1306) 2016-12-30 17:55:31 +02:00
David
ac6a4c83fd Updated react-scripts babel-jest && jest packages to 18.0.0 (#1311) 2016-12-23 12:09:39 -08:00
Eduard Kyvenko
21b0044412 Remove path-exists from dependencies and replace it with fs.existsSync (#1289) 2016-12-18 20:57:00 +02:00
Jay Phelps
7408e36478 Only gitignore dirs in root, not deep (#1267) 2016-12-14 03:06:38 -08:00
Cary Landholt
94c912dc60 Remove interactive shell check when opening browser on start (#1264)
Browser launch can still be suppressed using BROWSER=none
2016-12-13 08:13:30 -08:00
MUA
7a8edf07fb Heroku Deployment: Adds a note on how to resolve "File/Module Not Found Errors" (#1260)
* Adds note on how to resolve file or directory not found errors for heroku deployments

* Style tweaks
2016-12-12 16:43:08 -08:00
Dan Abramov
ab3913cc11 Clarify when to use the public folder 2016-12-12 14:21:46 +00:00
Dan Abramov
587b2f8b59 Add "Changing the Page Title" to User Guide (#1256)
* Add "Changing the Page Title" to User Guide

* Add link to main README
2016-12-12 05:43:59 -08:00
Dan Abramov
3df6b49b8e Style nit 2016-12-12 01:49:01 +00:00
Dan Abramov
2b2b8ff338 Replace the Flow documentation section (#1245) 2016-12-11 10:08:37 -08:00
Dan Abramov
96f4be9b75 Publish
- create-react-app@1.0.2
 - react-dev-utils@0.4.2
 - react-scripts@0.8.4
2016-12-11 11:50:25 +00:00
Dan Abramov
a13a65f1c5 Clear scrollback in test mode (#1237) 2016-12-11 03:33:34 -08:00
Benoit Averty
a60140f811 Disable jest watch mode when --coverage flag is present (#1229) 2016-12-11 02:03:19 -08:00
Pavel Kolesnikov
9d42ffab97 Proxy rewrites Origin header to match the target server URL (#1212)
* Proxy rewrites Origin header to match the target server URL

* Added comments on rewriting Origin header by the proxy middleware
2016-12-11 00:48:35 -08:00