Commit Graph

196 Commits

Author SHA1 Message Date
myappincome
0dcf973a6d Adding link to “Customizing” create-react-app (#1121)
Add documentation for customizing Bootstrap theme
2017-02-24 12:59:28 -05:00
Bond
9e51852ce4 Document debugging in the browser. (#1540)
* Document debugging in the browser.

* Styling
2017-02-24 12:04:07 -05:00
Valerii Sorokobatko
ce90532972 Fix workflow if react-scripts package is linked via npm-link (#1356)
* add npm-link support

* - remove extra veriable
- simplify condition

* update code after review:
- remove utils/isReactScriptsLinked
- add appPath and ownPath to paths.js (but only for "before eject" export case)

* update code after review:
- remove utils/isReactScriptsLinked
- add appPath and ownPath to paths.js (but only for "before eject" export case)

* update code after review:
- remove utils/isReactScriptsLinked
- add appPath and ownPath to paths.js (but only for "before eject" export case)
- remove "if" block for fs.removeSync(ownPath) at ejec.tjs

* change ownPath value
2017-02-24 11:55:37 -05:00
Dan Abramov
16a5e55548 Document Sass imports 2017-02-24 11:55:27 -05:00
Joe Woodhouse
5ee655b9ba Add note about when to import bootstrap CSS. (#1618)
* Add note about when to import bootstrap CSS.

* Tweak
2017-02-24 11:55:21 -05:00
SBrown52
fb945898c2 Update flow configuration documentation (#1518)
* Update flow configuration documentation

The documentation was missing creating the .flowconfig file

* Update flow configuration documentation

Adding in suggested changes

* Wording

* Wording
2017-02-24 11:27:18 -05:00
Michael DeRazon
d4f39851d5 add a comment about NODE_ENV value set to 'production' during build step (#1625)
* add a comment about NODE_ENV value set to 'production' during build step

https://github.com/facebookincubator/create-react-app/issues/790#issuecomment-281986264

* Move words around
2017-02-24 11:27:12 -05:00
Jirat Ki
7c4c16710e Install react, react-dom, and react-scripts at the same time (#1253)
* Install react and react-dom along with react-scripts

- Install react, react-dom and react-script in a same time
- Move react-scripts to devDependencies.

* Check if react, react-dom has been already installed

- To backward compatibility with old CRA’s cli
- In case old CRA doesn’t install react, react-don along with
react-scripts

* Use packageName to find script dependency

- use packageName to find dependency
- fix pathExists.sync

* Check dependencies.react in package.json instead of actual files

* Process exit when dependencies not found

- Show error and exit when dependencies not found.
- Log install show custom package name

* Remove template string

* Install dependencies if template is preseted

* Remove dangling comma

Resolves #1239
2017-02-22 23:33:28 -05:00
Alexander James Phillips
bf0c02e026 Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable HMR (#1608)
* Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable HMR

* Use br in react-scripts template README md

* Use br in md for new line breaks

* Update troubleshooting HMR to allow for VMs running Windows

* Fix up the instructions
2017-02-22 23:33:28 -05:00
Mato Ilic
71be55bc16 fixes #1584 PORT env variable not always an integer (#1585) 2017-02-22 23:33:27 -05:00
Mohammad Kermani
c7d6a5de34 Update README.md (#1573)
Update links to jest expect function.
2017-02-22 23:33:27 -05:00
Alessandro Burato
6ae2d06b61 add --recursive to sass watch script (#1564) 2017-02-22 23:33:27 -05:00
Darío Javier Cravero
41f9d20a97 Use https in link to Ignoring files at Github (#1561) 2017-02-22 23:33:27 -05:00
kiran ps
8c375ac4d2 modified documentation for setting up jest-enzyme (#1562) 2017-02-22 23:33:26 -05:00
Alessandro Burato
677896a9a8 update CSS preprocessor instructions (#1543)
* update CSS preprocessor instructions
- Windows shell users should note that running two programs simultaneously is not supported.

* fix the order of SASS build step
- the suggested build step with integrated CSS preprocessing is wrong. The SASS preprocessor should run first, then the react-scripts build will pick the up-to-date final CSS

* Add tweaks from PR discussion
2017-02-22 23:33:26 -05:00
Dan Abramov
1aefc2c17d Tweak syntax doc (#1539)
* Tweak syntax doc

* Shorter version
2017-02-22 23:33:26 -05:00
Joe Haddad
963383afaf Update language support wording to ES2017 2017-02-22 23:33:26 -05:00
pd4d10
572d07b677 Add useful link to react-scripts (#1495) 2017-02-22 23:33:26 -05:00
Toni Petrina
ed47cc3725 Added link to Azure deployment tutorial (#1338) 2017-02-22 23:33:25 -05:00
Roman Rubas
d53228d267 [documentation] how to disable autoprefix feature (#1320)
* added how to disable autoprefix feature in doc

* Just link to the doc
2017-02-22 23:33:25 -05:00
Jonathan Conway
60902dc715 reactjs/redux#2004 List features beyond ES6 supported by create-react-app (#1313)
* reactjs/redux#2004 List features beyond ES6 supported by create-react-app

* Add more info
2017-02-22 23:33:25 -05:00
Dimitris Tsironis
645ba66d41 Add SASS support documentation #1007 (#1008)
* Add SASS support documentation #1007

* Change SASS section title to more generic label

* Fix link in Table of Contents

* Chain build-css with watch-css script, fix typos

* Update Sass and Less naming style

* Fix wording, remove offensive words

* Slightly rewite
2017-02-22 23:33:25 -05:00
Blaine Kasten
12e8ceae9d Suggest jest-enzyme for simplifying test matchers (#994)
* Suggest jest-enzyme for simplifying test matchers

* Update README.md

* Update README.md
2017-02-22 23:33:24 -05:00
Dan Abramov
9f1276314d Add additional info about env variables 2017-02-11 14:00:26 +00:00
Dan Abramov
dc4e8bb462 Make index.html interpolation instructions less clashing with env syntax 2017-02-11 13:45:30 +00:00
Joe Haddad
67e6cf5a52 Publish
- babel-preset-react-app@2.1.0
 - create-react-app@1.0.4
 - eslint-config-react-app@0.5.1
 - react-dev-utils@0.5.0
 - react-scripts@0.9.0
2017-02-10 22:33:41 -05:00
Joe Haddad
15e0b98479 Upgrade dependencies (#1522)
* Upgrade dependencies

* Re-add caret
2017-02-10 21:31:15 -05:00
Anders D. Johnson
b0b0e6da55 fix: add yarn gitignores (#1507)
* fix: add yarn gitignores to template

* fix: add yarn gitignores to root

* fix: add wildcard to npm-debug.log ignore
2017-02-11 01:30:11 +00:00
Brandon Istenes
e19b0f6373 Make build exit with error code when interrupted (#1496)
* Make build exit with error code when interrupted

This addresses issue #1493.

Current behavior is that `npm run build` exits code 0 without creating a bundle when interrupted. This change makes the build script catch catchable interruptions and exit with the appropriate error code.

* Better error messages for kill signals

* Don't catch SIGINT

Ctrl+C should exit silently, and already produces a non-zero exit code when sent to the console while `npm run build` is running. Exit code 0 is produced if SIGINT is sent directly to the `node build.js` process, but this is unlikely to happen. A SIGINT handler in `build.js` will also be triggered by Ctrl+C in the console, potentially producing unnecessary noise.

* Style fix

* No changes needed to build.js

Problem is coming from the parent process, `react-scripts`

* Make react-scripts script handle signals

* Clarify context
2017-02-11 00:12:36 +00:00
Joe Haddad
7a02f9a41a readme: Add Advanced Configuration (#1515)
* Add Advanced Configuration section

* Reference package.json instead

* Add HOST, HTTPS, and CI

* Switch wording from Amazon to a CDN

* Add test runner comment

* Add top-level README link

* Simplify wording

* Link to relevant docs

* Link to apps

* Add .env link

* Simpler links

* Add a CI flag note
2017-02-10 16:20:53 -05:00
Thibault Derousseaux
8e127aaa38 Support relative asset paths for special case (#1489)
* Fix paths in CSS files when homepage is set to "./"

In the production build, ExtractTextPlugin is used to generate a separate CSS file instead of injecting style through JavaScript. This plugin does not work well by default with nested output structure. To fix it, we give it a relative publicPath pointing to the build folder.

* Add section in README to explain how to make builds deployable anywhere

* Apply review requested change

* Apply review changes 2
2017-02-10 00:44:00 -05:00
Joe Haddad
613b584f42 Add PUBLIC_URL env variable for advanced use (#937) (#1504)
* Add `PUBLIC_URL` env variable for advanced use (#937)
* Add support for `PUBLIC_URL` env variable
* Remove unnecessary duplications
* Simplify served path choice logic
* Honor PUBLIC_URL in development
* Add e2e tests

Enables serving static assets from specified host.
2017-02-09 23:15:15 -05:00
Jih-Chi Lee
1d9159de23 Make all react app vars accessible in index.html (#1440)
* Make all vars accessiable in index.html

* Fix wrong env provieded to DefinePlugin

* Separate results from getClientEnvironment

* The `string` should be object instead of string

* Fix accessing wrong field

* Changed variables naming to `raw` and `stringified`

* Remove trailing commas
2017-02-09 22:41:03 -05:00
pd4d10
b999405c67 Add missing '\n' to the end of package.json file (#1510) 2017-02-09 16:36:20 -05:00
Calvin Webster
160d8d13ef clarifying the use of custom environment variables (#1513)
* clarifying the use of custom environment variables

* Tweak
2017-02-09 20:46:47 +00:00
RodrigoHahn
c811a31622 Change "OS X" references to "macOS" (#1511)
Updated README.md to refer to the current rebranding.
2017-02-09 14:41:24 +00:00
Ro Savage
0ac0d116b9 Update comments for webpack loaders 2017-02-09 11:21:02 +13:00
Jay Phelps
9e0e18fd2e UX: Explain why build is failing (#1352) 2017-02-08 15:27:44 -05:00
Joe Haddad
adab23fa00 e2e: Reduce complexity of e2e and improve Jest coverage (#1484) 2017-02-07 23:04:01 -05:00
vulong23
65e6340395 Edit User Guide: Add ESLint config for VS Code users (#1482)
* Add ESLint config for VS Code users

* Update VSC ESLint note to a better solution 

Update VSC ESLint note to a better solution as discussed in Pull Request
2017-02-04 16:47:19 +00:00
Fatih
6424232dc1 Reflect websocket proxy support on README (#1013) (#1483)
* Reflect websocket proxy support on README

* Add 'the'
2017-02-04 15:18:54 +00:00
Valerii
8964dd6f13 - import expect and expect flow (#1463)
- code style
2017-01-30 19:28:16 +00:00
Fabrizio Castellarin
1d586aaf31 E2e jsdom fix (#1470)
* E2E: run tests when react is ready

* Entangle e2e with callbacks

* Remove unused e2e lines
2017-01-30 19:24:12 +00:00
creynders
bc2fc80898 eject: Additionally remove react-scripts from dependencies (#1458)
ATM if react-scripts is (erroneously) declared in `dependencies` instead of `devDependencies` or isn't declared at all, the `eject` script will fail half-way. This change makes it more robust, react-scripts will be removed from either, if present.
2017-01-27 16:26:35 +00:00
Anthony F
dd788b672a Readme: Removes experimental from Jest snapshot (#1453)
Per final comment in #372

`Snapshot rendering should actually be pretty stable / useable after React 15.4.1.
See this post for more info.`
2017-01-26 18:40:12 +00:00
Dan Abramov
da321b2433 Bump Jest version (#1432) 2017-01-24 23:39:42 +00:00
Jonathan Kim
dbb7ffe6a5 Added babel-runtime dependency to deduplicate dependencies when using yarn (#1441) 2017-01-24 17:20:57 +00:00
Alex Driaguine
3bb31ccb0f Added links to tutorials for integrating cra with an api backend (#1437)
* Added Rails link to User Guide

* docs: unify sections for rails and node backend integration

* docs: fix faulty link and indentation
2017-01-24 11:12:01 +00:00
Vasiliy Taranov
65bde54306 Add causes of dev server not detecting changes (#1422)
* Add causes of dev server not detecting changes

Add causes of `npm start` not detecting changes to Troubleshooting chapter of User Guide

* Reworded slightly

* Update README.md
2017-01-23 21:22:55 +01:00
Fabrizio Castellarin
9099570b94 Use a more sophisticated template for end-to-end testing. (#1187)
* Use a more sophisticated template for end-to-end testing.

* Not publish integration tests to npm

* Use "commander" for  cli argv handling

* Handle different scripts version forms and exits without a name given

* Prepare the commands for testing with a template

* Fix dev "template" path

* Add various features to test

* Test various features separately

* Test language features

* Comment unused e2e.sh lines

* Add "development" tests

* Test environment variables

* Test webpack plugins

* Replace kitchensink README

* Switch integration tests from jest to mocha

* Use `fs-extra`

* Use the correct folders

* Do some cleanup

* Print a better message for `--template`

* Test `npm start` with and without https

* Separate fast e2e testing from kitchensink testing

* Hide `--internal-testing-template` (former `--template`) CLI option
2017-01-23 20:43:16 +01:00