Commit Graph

28 Commits

Author SHA1 Message Date
Jared Palmer
8a72a314bc Make error overlay filename configurable (#3028)
* Make error overlay file configurable

* Add fallback filename
2017-09-02 13:42:04 -07:00
Tharaka Wijebandara
51d0df4902 Rename Overlay to ErrorOvelay (#3051) 2017-09-01 17:59:37 -07:00
Tharaka Wijebandara
ecd1f0544b Convert react-error-overlay to React (#2515)
* Convert react-error-overlay to React

* Update compile-time error overlay to use react-error-overlay components

 * Refactor react-error-overlay components to container and presentational components.

 * Make the compile-time error overlay a part of react-error-overlay package.

 * Use react-error-overlay as dependency in react-dev-utils to show compile-time errors.

* Run Prettier

* Move the function name fix into StackFrame itself

* Fix clicking on source code snippet to open the code in editor

* Use exact objects + minor style tweak

* Don't linkify frames that don't exist on the disk

* Fix lint

* Consolidate iframe rendering logic

* Remove circular dependency between react-dev-utils and react-error-overlay

* Fix lint

* Fix decoupling of react-dev-utils and react-error-overlay by moving middleware

* Deduplicate identical errors
2017-08-27 19:45:55 -06:00
Dan Abramov
5c010e0335 Fix module function name in error overlay (#3012) 2017-08-26 17:35:25 -06:00
Dan Abramov
a171d93064 Reformat source code with Prettier 1.5.2 2017-06-28 16:23:16 +01:00
Broda Noel
7348ca9bd1 Wrap console calls into a check (#2301)
* Wrap console calls into a check

* Add another check
2017-05-21 20:42:28 +01:00
Dan Abramov
d76c1b78eb Wrap console calls into a check (#2290) 2017-05-20 19:06:48 +01:00
Dan Abramov
f3ff3f2473 Add missing license headers 2017-05-20 18:59:22 +01:00
Nayef Ghattas
499adbe7ea Fix shortcut handling in react-error-overlay (#2238) 2017-05-19 08:04:09 -04:00
Dan Abramov
6c8b18b0cd Improve interaction between compile and runtime overlays (#2219) 2017-05-18 23:07:56 +01:00
Dan Abramov
55afd862c8 Move error overlay middleware (#2216) 2017-05-18 21:01:26 +01:00
Dan Abramov
07c75aa5fd Replace text-align: start with left to fix Edge (#2215) 2017-05-18 19:04:43 +01:00
Brian Vaughn
02968ecdb2 Cleaned up next/prev error arrow styles; arrows wrap around when clicked now (#2210) 2017-05-18 13:33:18 +01:00
Dan Abramov
0d0536f9d7 Fix vertical alignment of close button 2017-05-18 13:06:28 +01:00
Brian Vaughn
0681e24531 Tweaked error overlay styles (pt2) (#2208)
* Fixed several of the issues and nits from PR:

* Moved margin between header and file name to header, so when content was scrolled, the header would remain more separate
* Made build-time and runtime overlays better match
* Secondary error <pre> style now uses yellow bg instead of red
* 'Scrollable Header' (see above comment to why this is necessary) but I did increase the max-height from 35% to 50%.
* Fixed header and 'X' button vertical alignment

* Temporary stack margin fix

* Move "N errors" to the top
2017-05-18 12:25:43 +01:00
Brian Vaughn
68f95d4133 Tweaking error overlay styles (#2201)
* Tweaked overlay styles

* Tweaked pre-style

* Clicked to background overlay dismiss

* Tidied up styles tobe more mobile Safari friendly

* Re-enabled pre-wrap

* Margin fixes

* Base font-size 10 -> 11px

* Error overlay is full-screen now based on feedback

* Make "N errors on the page" visible again

* Fix bottom margin of frame location and lack of tab nav

* Add tooltip to close button

* Bring compile error styles closer to runtime overlay

* s/when/if/
2017-05-18 00:48:33 +01:00
Dan Abramov
fcb7dcf1da Put console.stack() behind a react vendor prefix (#2164)
Matches what we did in https://github.com/facebook/react/pull/9679
2017-05-15 21:03:18 +01:00
Dan Abramov
9e733b57f8 Internal Webpack paths should not be clickable 2017-05-15 16:50:40 +01:00
Joe Haddad
9b228176f0 [Internal] Warn for missing brackets (#2151)
* Warn for missing braces

* Overlay, too
2017-05-14 20:59:20 -04:00
Dan Abramov
8b451c38fa Don't collapse unintentional top-level errors (#2145)
* Don't collapse unintentional top-level errors

* Linkify internal stack frames too
2017-05-14 15:21:42 +01:00
Dan Abramov
ac7777d52d Work around weird inferred name in Chrome 2017-05-14 12:35:18 +01:00
Dan Abramov
4434467a43 Click to view source from error overlay (#2141)
* Click to view source

* Update package.json

* Update package.json

* Fix lint
2017-05-14 12:17:05 +01:00
Dan Abramov
b25c13394f Skip React frames that are too close (#2143) 2017-05-14 12:14:22 +01:00
Joe Haddad
76d2d848c6 Improve unmapper file heuristic, add limited warning support, and ignore internal errors (#2128)
* Browser sort is not stable

* Fix ordering of final message

* Register the warning capture

* Display only createElement warnings

* Use different method name

* Fix regression

* Ignore errors with only node_module files

* Ignore null files, too

* Revise count

* Revise warning

* Update overlay.js

* Add support for https://github.com/facebook/react/pull/9679

* Use absolute paths

* Trim path if it's absolute

* Make sure it's an absolute path

* Oops

* Tweak for new behavior

* Make it safer

* More resilient warnings

* Prettier output

* Fix flow
2017-05-13 14:39:32 +01:00
Dan Abramov
2b596547c8 Fix a bad condition
https://github.com/facebookincubator/create-react-app/pull/2123#discussion_r116062043
2017-05-11 19:07:40 +01:00
Dan Abramov
3521eb7c8b Make error box messages friendlier (#2123) 2017-05-11 15:37:48 +01:00
Joe Haddad
942cf6230c Adds tests for the overlay (#2118)
* Add get-source-map tests

* Fixtures shouldn't be formatted

* Add mapper tests

* Add stack-frame tests

* Add more util tests

* Add unmapper tests

* Add parser tests

* Switch to snapshots

* Snapshot more
2017-05-11 14:00:20 +01:00
Joe Haddad
70768b321e Add react-error-overlay package (#2111)
* ༼ つ ◕_◕ ༽つ stack-frame-overlay

* Fix linting

* Remove auto overlay

* Fix e2e

* Pull in the rest

* Appease flow

* Correct dep

* Remove old repo references

* Check flow on test

* Test overlay in e2e

* Add cross env

* Rename package

* Make sure it gets built post-install

* Update the README

* Remove extra builds now that there's a postinstall script

* Revert "Remove extra builds now that there's a postinstall script"

This reverts commit 8bf601dbd36c1e0da7f785fa9ade70ab08ed8772.

* Remove broken script

* Fix some dev ergo
2017-05-10 19:56:30 -04:00