Commit Graph

48 Commits

Author SHA1 Message Date
Valerii Sorokobatko
fe7b5c212b update to modern code style (#1738)
* mv create-react-app/index.js -> create-react-app/creteReactApp.js

* update to modern code style

* var -> cosnt

* set trailing-coma to es5 for prettier
2017-03-07 19:46:10 +00:00
Joe Haddad
ed5c016d61 Add runtime error overlay (#1101)
* Add red box prototype

* Unmount fail node when hot-reloaded (future proofing)

* Slightly improve error reason

* Add Chrome unhandledrejection listener

* Close red box when Escape is pressed

* Construct our own source if not available

* Resolve sourcemaps for friendlier traces

* Allow error to be scrolled

* Only utilize sourcemaps, not the magic. :(

* Make view similar to React Native

* Fix an uncaught syntax error

* Add workaround for Firefox 50

* Add a hint for closing the prompt

* Multiple error support
When there's multiple errors, simply state that there are more instead of re-rendering

* Log any renderer error

* Dim node_modules in display

* Override chrome stack trace limit

* Magic: show me some source!

* Add ability to toggle internal calls

* Switch text from show -> hide

* Change color scheme to something easier on the eyes

* Change UI to be friendlier (thanks @nicinabox)
https://github.com/facebookincubator/create-react-app/pull/1101#issuecomment-263621057
https://github.com/facebookincubator/create-react-app/pull/1101#issuecomment-263636171

* Update styles

* Add container inside overlay

* Apply pre style

* Add line highlight

* Add omitted frames ui

* Move yellow to var

* Do all function names in black

* Adapt container based on screen size

* Extract ansiHTML

Use base16-github theme

* Linting

* Add syntax highlighting of errors

* Linting

* Remove white background

* Append new files to package.json

* Target exact version

* White is a little harsh, use same color as red box.

* Fix a bug where omitted frames would never be rendered
(under certain circumstances)

* Show local file path instead of confusing webpack://

* Do not require the entire file

* Remove css file

* Use context size, not a magic variable.

* Fix title regression

* Update dependency

* Do not center text for internal calls

* Temporarily disable links

* Switch internal toggle to 'i'

* Remove unnecessary rules from container style

* Reduce omitted frames font size

* Fix font family in pre > code

* Re-introduce line highlighting

* Object.<anonymous> -> (anonymous function)

* Add ability to see script source

* Add missing ansi mappings

* Remove SIAF

* Skip native functions

* Extract hints div function

* Extract renderers

* Refacor var names

* If source is disabled, don't use the line.

* Allow toggle between source

* Allow bundles to be expanded

* Wow, how did I let this one slip?

* Toggle text for UX/DX

* Make it so clicking Close unmounts the error component

* Do not allow hot reloading once an error is thrown

* Do not wrap lines for small displays

* Fix toggle when additional errors happen

* Make the close a button

* Capture and store errors

* Dispose on render; move additional logic

* Only make code not wrap

* Switch to a view-by-index method

* Allow user to switch between errors with arrow keys

* Fix text while switching between errors

* Update close button style

* Render additional errors at top

* Add left and right arrows

* Make frames pointy

* UTF-8 arrows

* Don't mount unneeded DOM node

* Switch to single changing text for compiled <-> source

* Don't display arrows with only one error.

* Collapsed and expanded

* Make sure the last collapse toggle is appended

* Do not show the stack trace if it doesn't resolve to a file we wrote

* Style container with media queries

* Do not allow x overflow; break words by default.

* Trim off whitespace of lines

* Remove padding since it's not outer-most

* Add footer message

* Extract css file to JS

* Only inject the css when the overlay is up

* Extract red variable

* Remove env

* Update babel-code-frame

* Set force color to true

* Extract out collapse div logic

* Remove arrow field

* Insert a top collapse

* Make browser friendlier

* Absolutify ^

* Make arrows buttons

* Accessify

* Let there be ES5

* Pretty css

* Use forEach where we can ...

* Remove extracted loop

* Fix IE compatibility

* Capture React warnings

* Add source override via React output parsing

* Whoops, fix arguments to crash.

* es5-ify

* Re-enable e2e-install directory test

* Only rewrite line number if it was resolved and leaves a line at bottom

* Rename failFast to crashOverlay

* Disable console proxy

* Appease linter

* Appease more
2017-03-06 21:59:57 -05:00
Joe Haddad
956322b76a Published branch 0.9.x
- create-react-app@1.3.0
 - eslint-config-react-app@0.6.1
 - react-dev-utils@0.5.2
 - react-scripts@0.9.4
2017-03-06 14:20:24 -05:00
Ade Viankakrisna Fadlil
fbdff9d722 extract generic build functions to react-dev-utils (#1726)
* Temp rename

* Rename to change the case

* extract generic build functions to react-dev-utils

* tweak package json files and move removeFileNameHash

* revert removeFileNameHash

* use paths.appBuild in printFileSizes

* use paths.appBuild in removeFileNameHash

* change curried functions to regular functions

* add fs-extra to react-dev-utils deps

* move getDifferenceLabel inside printFileSizes

* inline copyPublicFolder

* combine printFileSizes and removeFileNameHash to fileSizeReporter

* fix typo

* Tweak APIs and fix issues

* Fix heading

* Remove missing file

* Newline

* Newline

* Trailing space

* Update FileSizeReporter.js

* Update build.js
2017-03-06 01:49:53 +00:00
Dan Abramov
2f7e3a2168 Lint internal scripts with eslint:recommended (#1729)
* Lint internal scripts with eslint:recommended

* Warnings r bad
2017-03-05 22:29:28 +00:00
Dan Abramov
ed9eeebf2b Don't use ES6 in a file that should run on Node 4 (#1724) 2017-03-05 19:10:48 +00:00
Pierre Bertet
d07accbd09 Fix openBrowser() when BROWSER=open on macOS (#1690)
* Fix openBrowser() when BROWSER=open on macOS

* Tweaks
2017-03-05 16:42:13 +00:00
Chris Drackett
59cab8f590 Improve reliability of port hint. (#1696)
* fixing things for people with the username `cwd`

closes #1694

* combine awk into a single command and add escaping
2017-03-03 13:03:07 -05:00
Joe Haddad
f3d8ffff0f Published 0.9.1 at 9e2624f332
- babel-preset-react-app@2.1.1
 - create-react-app@1.1.0
 - eslint-config-react-app@0.5.2
 - react-dev-utils@0.5.1
 - react-scripts@0.9.1
2017-02-25 22:10:11 -05:00
Joe Haddad
21fe19ab0f Bump deps for webpack 2 compat (#1621) 2017-02-23 00:57:53 -05:00
Alexander James Phillips
2a8535b5d5 Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable HMR (#1608)
* Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable HMR

* Use br in react-scripts template README md

* Use br in md for new line breaks

* Update troubleshooting HMR to allow for VMs running Windows

* Fix up the instructions
2017-02-22 18:37:18 +00:00
Kees Kluskens
1d5a277367 Enable watchContentBase for webpack-dev-server (#1546)
Resolves #1508
2017-02-14 21:41:31 -05:00
Joe Haddad
67e6cf5a52 Publish
- babel-preset-react-app@2.1.0
 - create-react-app@1.0.4
 - eslint-config-react-app@0.5.1
 - react-dev-utils@0.5.0
 - react-scripts@0.9.0
2017-02-10 22:33:41 -05:00
Robbie H
17bb8d420f webpack-dev-server patch for 'still-ok' success status (#1377) 2017-01-12 10:27:58 -08:00
Jimmy Miller
3f6937c956 Change console.log for errors and warnings (#1375)
Array.forEach is passed the following parameters:

currentValue
    The current element being processed in the array.
index
    The index of the current element being processed in the array.
array
- https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach

console.log takes multiple arguments. We only want to print the first one, the actually message.
2017-01-11 12:15:58 -08:00
Pedro Nauck
d29fb006c0 Add missing import in react-dev-utils README.md (#1369) 2017-01-11 07:53:54 -08:00
Matthew Holloway
7d66ba176a Downgrading to compatible version of SockJS-Client (#1274) 2016-12-20 16:06:56 -08:00
Dan Abramov
519d32a19f Only open Chrome tab if BROWSER is missing or is Chrome (#1247) 2016-12-11 13:15:42 -08:00
Gabriel Aumala
759806ed4f Configure which browser to open in npm start (#873) (#1148)
Use a 'BROWSER' environment variable with npm start to specify which
browser to open. if the value of 'BROWSER' is not valid executable file,
don't open any browser.
2016-12-11 12:16:35 -08:00
Dan Abramov
96f4be9b75 Publish
- create-react-app@1.0.2
 - react-dev-utils@0.4.2
 - react-scripts@0.8.4
2016-12-11 11:50:25 +00:00
Dan Abramov
5c551f8da3 Use a better clear console sequence (#1211) 2016-12-11 02:04:09 -08:00
Shogun Sea
f3c6de802d fix html-dev-plugin link in react-dev-utils doc (#1232) 2016-12-10 13:51:09 -08:00
Jirat Ki
7e2a08b957 Strip filename from loader notation first (#1226) 2016-12-10 06:48:27 -08:00
Jirat Ki
3416ba2802 Fix - openChrome won't open default browser (using Canary) (#1215)
- Use “Chrome” instead of "Google Chrome", It  will try to use current active browser.
  otherwise, use default.
- If “Chrome”s aren’t running, will fallback to opn(url)
2016-12-09 04:48:17 -08:00
Dan Abramov
49414d6ba0 Publish
- babel-preset-react-app@2.0.1
 - eslint-config-react-app@0.5.0
 - react-dev-utils@0.4.1
 - react-scripts@0.8.2
2016-12-07 21:31:11 +00:00
Jirat Ki
6ebec23a85 Chrome 'open tab' reuse an empty tab when possible (#1165)
* Reuse empty tab on open chrome apple script

* Break find tab into function

* Use property to store found

* Fix minor issues that caused window to not get active
2016-12-06 17:14:57 +00:00
James Newell
f7d9cd8166 Don't strip stack traces of evaluated webpack bundles (#1050)
* Don't strip stack traces of evaluated webpack code

* Strip stack traces at the end of a string

because the last line doesn't always have a `\n` and `create-react-app` is leaving the last line of the stack traces present in the error messages

* code comment

* code comment
2016-12-05 22:58:36 +00:00
Ville Immonen
5ee027d638 Publish
- babel-preset-react-app@2.0.0
 - create-react-app@0.7.0
 - eslint-config-react-app@0.4.0
 - react-dev-utils@0.4.0
 - react-scripts@0.8.0
2016-12-03 18:03:38 +02:00
Ian McNally
05c3b55c62 add logging of existing default port process on start (#816)
* add logging of existing port process on start

* Move port process wording in start command on to next line

* Color the named processes as cyan in terminal output

* Add handling for multiple processes on a part

- With the currently process filtering, if multiple processes are returned as running on port 3000, this command would fail. This splits apart the process IDing and the process naming, to support multiple processes.
- One curious thing about the bash command to get processes, is that it'll include browsers with a window open on localhost:3000. May want to reconsider that.

* Add process directory to existing port warning

- also moved terminal coloring up, when getting the process, to be able to distinguish the process command from the directory

* Change output color to all cyan, except "in"

* Rename getProcessNameOnPort -> getProcessForPort

- better reflects its broadened scope (both command and directory)

* Add checking if process is a CRA instance, to customize port running message

- moved from using package.json to a regex, for reliability

* Move getProcessForPort to react-dev-utils

- also allowed for breakdown of commands into helper methods

* Add documentation for getProcessForPort

* Add getProcessForPort to list of dev-scripts files

* Use app's package name when CRA app is running on another port

* Filter port process by those listening

- Removed the handling of multiple process IDs since you can filtering by listening process (and not have the browser in the list of processes)
- Trimmed the terminal outputs for better matching (process id) and better terminal output (directory of process)

* Update README on port helpers, to specify only one port returned

* Add ignore of stderr when executing process commands

- Make sure any potential errors don't leak to the user
2016-11-22 22:44:21 +02:00
Einar Löve
b9c9aeda03 Fix chrome tab reuse (#1035)
* Correctly checks site url to tab url in reuse check

* Bring chrome to foreground focused after tab reuse
2016-11-17 21:37:20 +02:00
Einar Löve
e3b69661d9 Allow webpack 2 as peerDependency in react-dev-utils (#963)
* Allow webpack 2 as peerDependency

* Remove webpack as peer dependency
2016-10-31 11:45:44 +00:00
Sandro Padin
0bd593baa7 Catch and noop call to open web browser. (#964)
Running `create-react-app` in a Docker container causes an unhandled rejection error in nodejs > 6.5 because the `opn` module tries to open a web browser in a system that doesn't have one. I figured this error could be safely ignored.
2016-10-28 13:45:50 +01:00
Ville Immonen
a5f760bab9 Publish
- babel-preset-react-app@1.0.0
 - create-react-app@0.6.0
 - eslint-config-react-app@0.3.0
 - react-dev-utils@0.3.0
 - react-scripts@0.7.0
2016-10-22 23:49:30 +03:00
Jarle Friestad
4e5a561d98 Dispose error overlay when linting errors have been corrected (#856)
* Dispose error overlay when linting errors have been corrected

* Fixed spelling error

* Minor style tweaks
2016-10-11 12:44:58 +01:00
Michal Kvasničák
4feff2acf7 Make webpackHotDevClient support webpack 2 too (#840)
* Support webpack 2

* Code style
2016-10-04 13:25:13 +01:00
unixdev
856001ff8c Fix script name to open chrome (#831)
A previous commit renamed the apple script to open chrome from
`chrome.applescript` to `openChrome.applescript`. That created
a minor bug. Even when chrome was open with the client app,
`npm start` would open the client app in a new Safari tab on
macOS instead of re-using the open tab in chrome.
2016-10-03 12:36:56 +01:00
Brian Ng
909d938166 Fix some typos (#809) 2016-10-01 12:13:42 +03:00
Dan Abramov
a8d29c8ca0 Fix usage example to match react-dev-utils@0.2.x API 2016-09-30 13:25:52 +01:00
Dan Abramov
dc6074abbc Publish
- react-dev-utils@0.2.1
 - react-scripts@0.6.1
2016-09-27 15:53:27 +01:00
Ville Immonen
7d0fd03b00 Fix the right and bottom padding of the error overlay (#758) 2016-09-26 10:29:55 +01:00
Dan Abramov
059536291e 0.6.0 2016-09-25 13:07:08 +01:00
Dan Abramov
17ab11e279 Add an unobtrusive log when server disconnects 2016-09-25 12:41:33 +01:00
Dan Abramov
e872907b50 Fix error overlay in Firefox (#749) 2016-09-25 12:33:43 +01:00
Dan Abramov
9cce0fb59f Add syntax error overlay in development (#744)
* Add syntax error overlay in development

* Support HMR being disabled

* Tweak CSS
2016-09-25 11:31:10 +01:00
Dan Abramov
12c95f313a 0.5.1 2016-09-24 00:56:02 +01:00
Ville Immonen
e41d671bee Fix InterpolateHtmlPlugin only replacing the first occurrence (#731)
Fixes https://github.com/facebookincubator/create-react-app/issues/625#issuecomment-249320724.
2016-09-24 00:28:32 +01:00
Dan Abramov
35f38fd44c Tweak README 2016-09-23 20:55:15 +01:00
Dan Abramov
e5bf5af296 Extract some utilities into a separate package (#723)
* Extract some utilities into a separate package

* Add utils dir to `files` in package.json

* Do not create an empty `utils` dir on eject
2016-09-23 20:53:08 +01:00