Commit Graph

11 Commits

Author SHA1 Message Date
Dan Ristea
804ac00095 Support PyCharm in launchEditor (#2740)
PyCharm has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those.

https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html

Tested with PyCharm Pro 2017.1.4 on MacOS 10.12
2017-07-07 11:34:56 +01:00
Trygve Aaberge
f495c15578 Reorder vim arguments in launchEditor so --remote works (#2723)
This allows you to set REACT_EDITOR to 'vim --remote', so the file can
be opened in an already running vim process. When using vim without
remote, it works in the same way as before.

When launching vim without --remote, the order of the line and path
arguments doesn't matter. However, when using --remote the line argument
has to precede the path. This happens to be the same as joe and emacs
uses, so the vim cases were just moved there.

I haven't tested this with mvim, but the documentation says the same as
the vim documentation, so I assume it works the same.
2017-07-04 23:44:55 +01:00
Dan Abramov
a171d93064 Reformat source code with Prettier 1.5.2 2017-06-28 16:23:16 +01:00
Pete Nykänen
84299ceb23 Add Brackets to launchEditor.js (#2637) 2017-06-27 21:46:59 +01:00
Marius Wirtherle
6a09ed1e6e docs: added REACT_EDITOR to Advanced Configuration section (#2445)
* docs: added REACT_EDITOR to `Advanced Configuration` section

* Update README.md

* Update launchEditor.js
2017-06-27 16:30:26 +01:00
Levin Rickert
2874e1209e Auto-detect running editor on Windows for error overlay (#2552)
* Auto-detect running editor on Windows for error overlay

* Ignore process output if powershell call fails

* Support Notepad++
2017-06-27 16:16:02 +01:00
Mikhail Osher
58ef08f798 Support PhpStorm in launchEditor (#2622)
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html
https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html

Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line.
It seems to work even if `<projectPath>` is omitted (commit 02f88ba157).

Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.
2017-06-26 16:19:21 +01:00
Marius Wirtherle
02f88ba157 Add WebStorm >2017 launchEditor Support (#2414) 2017-05-30 14:00:16 +01:00
Malcolm
d3e85364fe Add WSL support to launchEditor utility (#2282) 2017-05-20 17:52:58 +01:00
Dan Abramov
10c734b66a Print error messages for editor integration (#2150) 2017-05-14 23:52:27 +01:00
Dan Abramov
4434467a43 Click to view source from error overlay (#2141)
* Click to view source

* Update package.json

* Update package.json

* Fix lint
2017-05-14 12:17:05 +01:00