Commit Graph

118 Commits

Author SHA1 Message Date
Ian Sutherland
92d9c5ada4 Add Node 10 to CI config and remove Node 6 (#4383)
* Add Node 10 to Travis config. Remove Node 6.

* Add Node 10 to Appveyor config. Remove Node 6.

* Remove node 9 from travis config.

* Increase mocha timeout.

* Update minimum Node version to 8.

* Update yarn to latest on Travis.

* Update old-node test to use Node 4.

* Increase mocha timeout in kitchensink-eject tests.

* Update yarn to latest on Appveyor.
2018-07-15 22:26:42 -06:00
Jack Zhao
366e5d3475 [internal] Separate out kitchensink test into two (#4767)
* support scoped packages for cra --scripts-version option

* seperate out kitchensink test

* add eject to node 6 testing

* travis node 6 eject

* fix CI warnings
2018-07-15 12:21:32 -06:00
Jack Zhao
e1ee8032a8 Fix node 10 npm login issue (#4626)
* node10

* token

* rerun tests
2018-06-18 13:00:55 -04:00
Jack Zhao
c1b0175253 Merge pull request #3929 from maciej-ka/remove-trailing-spaces-from-copyright
Remove trailing spaces from copyright
2018-05-30 21:46:43 -07:00
Jack Zhao
d1454febd1 Webpack4 (#4490)
* - [x] Upgrade to webpack 4.8.X
- [x] Utilize webpack 4 development and production modes
- [x] Upgrade webpack dev server
- [x] Webpack 4 compatible release of thread-loader
- [x] Webpack 4 compatible release of HtmlWebpackPlugin
- [x] Webpack 4 compatible release of SwPrecacheWebpackPlugin
- [x] Webpack 4 compatible release of WebpackManifestPlugin
- [x] Update README
- [x] Update WebpackDevServerUtils
- [x] Update InterpolateHtmlPlugin
- [x] Update ModuleScopePlugin
- [x] Update WatchMissingNodeModulesPlugin
- [x] Move UglifyJS options to webpack 4 optimize
- [x] Move InterpolateHtmlPlugin to make it tapable on HtmlWebpackPlugin
- [x] vendor splitting via splitChunks.splitChunks (https://twitter.com/wSokra/status/969633336732905474)
- [x] long term caching via splitChunks.runtimeChunk (https://twitter.com/wSokra/status/969679223278505985)
- [x] Make sure process.env.NODE_ENV is proxied correctly to `react-error-overlay`
- [x] Implicit webpack.NamedModulesPlugin in dev config as its default in webpack 4
- [x] Disable webpack performance hints as we have our own filesize reporter
- [x] Replace ExtractTextPlugin with MiniCssExtractPlugin
- [x] Switch to css whole file minification via OptimizeCSSAssetsPlugin rather than per module css minification to gain performance

* disable module concatenation

* fix cleanup

* fix optimization

* restore tmp removal

* preserve

* fix css tests

* fix test run

* fix svg test

* revert tmp dir

* fix import

* fix import

* help debugging

* fix tests

* fix sass test

* restore cleanup
2018-05-20 18:25:57 +01:00
Jack Zhao
c2aa1632e6 Fix e2e:docker script (#4454)
* verdaccio configs

* verdaccio configs

* fix typo

* revert e2e-installs

* move config to tasks
2018-05-14 01:05:16 +01:00
Mikhail Osher
da4a87f638 Support package distribution tags (#4350)
* Support package distribution tags (#4348)

* Remove redundand variable check in `getInstallPackage`

* Simplify react-scripts version using `--scripts-version=@tagname` notation

* Add dist-tag tests to e2e-installs
2018-04-27 08:45:18 -04:00
Brian Muenzenmeyer
cf6caf46ef Fix typo in e2e-simple.sh comment (#4323) 2018-04-19 14:39:32 -04:00
Ro Savage
b2fd8db8bd Minor fixes to CI (#4193) 2018-03-21 14:55:35 -04:00
bradfordlemley
b43ad04b88 Add support for yarn and lerna monorepos. (#3741)
* Support for multiple source paths via package.json srcPaths entry.

Initial support for yarn workspace.

Support lerna workspace, fix for when to use template files.

Remove support for specifying srcPaths in package.json.

Re-enable transpilation caching.

* Clean up, use file matching (similar to original) in webpack configs instead of matching function.

* Remove package lock files.

* Fix for eject.
Note: monorepos won't work after eject.
Can be fixed easily with JEST 22.0.?+ which has file pattern matches against realpaths.

* Filter tests to run only tests in monorepo components included by the app.
(Not sure this is desireable, might be cool to be able to easily run all tests in monorepo from one app.)

* Fix conditions for when to use template.

* Fix eject.

* Remove code that is not needed w/ Jest 22.

* Include all cra-comp tests in monorepo instead of trying to include only tests that are dependencies of app.
(tests can be easily filtered via jest cli if desired, e.g. 'npm test -- myapp comp1')

* Pin find-pkg version.

* Hopefully fix jest test file matching on windows by removing first slash.

* E2E tests for monorepo.

* Run monorepo tests in CI.

* Fix and test post-eject build.

* Fix e2e test.

* Fix test suite names in appveyor.

* Include individual package dirs as srcPaths instead of top-level monorepo root.
Fixes build/start after eject.

* Fix running tests after eject.

* Clean up test workspace, add some verifcations.

* Cleanup.

* Try to fix hang when running test on appveyor.

* Don't write babel or lint config to package.json when ejecting.

* Incorporate review comments.
* Simply monorepo pkg finder
* Only include monorepo pkgs if app itself is included in monorepo
* Check for specific tests in e2e

* Fixes for windows.

* Fix for kitchensink mocha tests compiling.

* Add lerna monorepo test.

* Fix lerna bootstrap on windows.

* Incorporate more review comments:
* remove support for lerna w/o yarn workspace
* add react and react-dom as devDeps to comp1 and comp2

* Add monorepo info to user guide.
2018-02-01 20:58:18 +00:00
maciej-ka
476fe85164 Remove trailing spaces from copyright 2018-01-28 23:36:23 +01:00
Michaël De Boey
25184c4e91 Fix links to package (#3898) 2018-01-22 22:16:22 +00:00
Dan Abramov
31118bd6d6 Remove file 2018-01-22 01:45:33 +00:00
Dan Abramov
5aa8ee04ca Remove git from e2e script 2018-01-21 23:38:57 +00:00
Dan Abramov
d49ffde4e6 Fix the E2E script (#3888)
* Fix the E2E script

* Delete .git if committing failed
2018-01-21 23:31:03 +00:00
Dan Abramov
eac8fcee2d Fix integration test (#3879)
* Fix integration test

* More fixes
2018-01-20 20:19:52 +00:00
Dan Abramov
ab2e0f870d Fix the script replacing local deps (#3876) 2018-01-20 18:24:25 +00:00
Maurice de Beijer
247e5c90a0 Create git repository with initial commit (#1288)
* Create git repo with initial commit

* Fixe commit message

* Added the git repo to the docs

* Bail if we are in a mercurial repository

* Removed Chore from commit mesage

* Create repo after installing react and react-dom

* Removed docs

* Commit changes when ejecting

* Update after review

* git add -A instead of git add . after code review
2018-01-19 13:12:34 +00:00
Mario Nebl
70ef42c3f3 Add screencast task (#3816)
* Automate screencast recordings
* **screencast.js**: Automate screencast.sh, asciinema, svg-term-cli. Removes progress-bar, npm tree data from cast
* **screencast.sh**: Simulate user input, trigger demoed commands
* **screencast-start.js**: Start a shell command and end the process log patterns have been observed
2018-01-16 19:07:45 +00:00
Siddharth Doshi
c36d1a00a1 Add restricted globals package (#2286)
* Add restricted globals package

* Use new package in eslint-config

* Add eslint-restricted-globals dependency

* Fixes

* Update dependencies

* Update test and README

* Use jest

* tweaks

* Add lint/test to CI

* Fix lint
2018-01-15 00:08:14 -05:00
Joe Haddad
aa67a4f78e Loosen Babel preset to use browserslist (#3770)
* Provide better defaults

* Let babel determine features to compile

* meh

* Remove setting of BABEL_ENV

* Revert "Remove setting of BABEL_ENV"

This reverts commit ee2db707faa8b9ada3e7a668e8a94944f5955a1e.

* Set browsers to ie9
2018-01-15 00:08:14 -05:00
Clement Hoang
1552949a3b Switch to Babel 7 (#3522)
* Update dependencies in react-scripts

* Add first pass of working dependencies for babel-preset-react-app and react-scripts

* Bump more dependency versions

* Adjust more versions and edit fix options

* Restore functionality of old preset

* Disable Uglify in iframe webpack

* Apply prettier

* Re-enable cache in dev and clean deps

* Lock packages and move babel/core to dep in preset

* Bump babel-jest

* Re-enable uglify

* Nest forceAllTransforms correctly in webpack config

* Install babel-core bridge for jest

* Add jest-cli and babel-core bridge to make tests in react-error-overlay pass

* Re-enable transform-dynamic-import

* Add dynamic import syntax support back

* Use new babel in kitchensink

* Transform modules in test

* Revert "Transform modules in test"

This reverts commit 539e46a1d77259898b7e70d778a5e43fc25edc2a.

* Attempt fix for ejected tests

* try this

* Add regenerator back

* Bump babel deps to beta.34

* Remove bad files

* Use default when requiring babel transform plugin

* Bump deps

* Try the fix?

* Oopsie

* Remove some weird things

* Run Babel on react-error-overlay tests

* Try fixing kitchensink

* Use new API for codeFrame

* Add missing (?) babelrc

* Maybe this helps?

* Maybe fix mocha

* I shouldn't have deleted this 🤦
2018-01-15 00:07:57 -05:00
Dan Abramov
0aeffe62ef Switch to Yarn Workspaces (#3755)
* Switch to Yarn Workspaces

* Feedback

* Move flowconfig

* Use publish script

* Keep git status check

* Fix Flow without perf penalty

* Remove Flow from package.json "test"

* Try running it from script directly (?)

* Try magic incantations

* lol flow COME ON

* Try to skip Flow on AppVeyor

* -df

* -df

* -df

* Try to fix CI

* Revert unrelated changes

* Update CONTRIBUTING.md
2018-01-12 01:54:53 +00:00
Ade Viankakrisna Fadlil
b02fe66732 clean up changes to npm and yarn registry (#3756) 2018-01-11 23:25:27 +00:00
Joe Haddad
1098a4a177 Oops 2018-01-11 02:21:25 -05:00
Joe Haddad
ebddb83dd6 Remove redundant steps in e2e tests (#3747)
* This doesn't look needed anymore

* Remove unnecessary rebuilds
2018-01-11 01:40:03 -05:00
Joe Haddad
29e06fc91a Follow-up: use private registry (#3746)
* Convert e2e-installs

* Convert kitchensink tests

* Upgrade npm for kitchensink
2018-01-11 01:38:10 -05:00
Joe Haddad
75d71e1541 Use private registry (#3744)
* Run e2e-simple in a realistic scenario

* Use npx for everything

* oops
2018-01-11 00:49:39 -05:00
Dan Abramov
99c14e710f Separate old Node E2E test (#3742)
* Separate old Node E2E test

* Try this for old node
2018-01-11 01:55:55 +00:00
Dan Abramov
d29d41b3c6 Try to use Yarn in more E2E scripts (#3739)
* Try to use Yarn in more E2E scripts

* Keep using npm pack

* Maybe this will fix Windows?

* Try this
2018-01-11 00:54:49 +00:00
Dan Abramov
dcd8ea6b5c Always use Yarn on CI (#3738) 2018-01-10 23:30:59 +00:00
Dan Abramov
a03524c594 Use latest npm in e2e tests (#3735)
* Use latest npm in e2e tests

* Keep default npm version in "simple" test

* Try to fix CI by using a version that supports Yarn
2018-01-10 21:55:18 +00:00
Dan Abramov
70b3a4db89 Lint against files with old license (#3361)
* Lint against files with old license

* Update e2e-simple.sh

* Update e2e-simple.sh

* oh no
2018-01-10 16:24:27 +00:00
Ian Schmitz
b20b96a971 Port cra.sh development task to javascript (#2309)
* Port cra.sh development task to javascript

* Port cra.sh development task to javascript

Use absolute path when generating .tgz path
2018-01-09 17:38:33 +00:00
Trevor Brindle
756a9a0fa8 add —use-npm flag to bypass yarn (#3409)
* add —use-npm flag to bypass yarn

* add e2e test for —use-npm flag
2017-11-09 14:03:40 -05:00
Joe Lim
231873e948 one-line waiting for app start (#3411)
* one-line waiting for app start

* remove fixed todo
2017-11-05 07:12:50 -05:00
Joe Lim
36cd35d684 Refactor extra watch options regex to react-dev-utils (#3362)
* extra watch options regex to react-dev-utils

* fix regex

* add test

* fix eslint error

* include react-dev-utils test in CI script

* attempt to fix import error

* attempt to fix error on CI

* Update .eslintrc
2017-11-03 22:23:31 -04:00
Joe Haddad
de1beec690 Stop using npm link in tests (#3345)
* Try a custom function

* fix path

* install rsync

* Test with node 8

* Ensure package is removed from the tree

* Remove ours

* matching functions

* try cygwin

* try c:/

* sigh

* Try /cygdrive/

* Try /cygdrive/

* Revert "Try /cygdrive/"

This reverts commit ab1ed779456d39bedbdb128a7aec3bb88b8eeb1c.

* Use sub-optimal copy

* Remove rsync install

* Fix variable

* Continue on err

* Don't link react-scripts, lol

* run yarn after eject

* re-enable cleanup

* uninstall yarn

* try with force

* appveyor ... seriously?

* swallow bad eject

* remove eject error swallow

* Revert "run yarn after eject"

This reverts commit eebf1dbc19aeb6e1f66d5ec27bda2d076bea0956.

* Run yarn after eject

* add a comment
2017-10-30 14:18:25 +00:00
Joe Haddad
fedc539246 Fix license comments 2017-09-26 20:15:14 -04:00
Sophie Alpert
2e82ebb337 BSD+Patents -> MIT (#3189)
* File headers BSD+Patents -> MIT

* BSD+Patents -> MIT
2017-09-26 10:30:05 +01:00
Tharaka Wijebandara
89bf273ec8 Link local react-error-overlay package in kitchensink test 2017-09-16 21:15:05 +05:30
Ade Viankakrisna Fadlil
0e064b30ca Revert "run npm 5.4.0 in CI (#3026)" (#3107)
This reverts commit fcb6dc5557.
2017-09-11 21:40:11 -04:00
Ade Viankakrisna Fadlil
fcb6dc5557 run npm 5.4.0 in CI (#3026)
* run npm 5.4.0 in CI

* run npm cache clean with --force in CI

* use link instead of install

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh
2017-09-07 10:47:55 +01:00
Joe Haddad
aad5987a03 Bootstrap with Yarn when available (#2673)
* Bootstrap with Yarn if we can

* Update test scripts

* Check OS and npm concurrency ability

* Windows support

* Update bootstrap.js

* Install yarn before bootstrap
2017-06-29 00:45:45 -04:00
Dan Abramov
657b3fd6c0 Test Node 8 on Travis (#2659)
* Test Node 8 on Travis

We still test Node 7 on AppVeyor

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh

* Update e2e-simple.sh

* Update e2e-simple.sh

* Update e2e-kitchensink.sh

* Update e2e-installs.sh
2017-06-29 00:09:13 +01:00
Dan Abramov
9559ba486e Put react-scripts in dependencies, not devDependencies (#2657)
* Put react-scripts in dependencies, not devDependencies

* Sort dependencies on eject

* Remove CI check
2017-06-28 14:04:26 +01:00
Fabrizio Castellarin
1f91848d51 E2E testing enhancements (#2408)
* Local testing with docker

* Docs on e2e testing

* `bash` callback after docker

* Add a TL;DR in the CONTRIBUTING section

* Local e2e testing with modified files

* Remove the N.B. from the README

* Fixed a fixme in e2e doc
2017-06-26 17:34:03 +01:00
Ro Savage
32f82c03cb Added cache clear to e2e scripts (#2400)
* Added cache clear to e2e scripts

* Install latest yarn on AppVeyor to avoid windows crashing bug in yarn

* Alternative fix for yarn crashing e2e tests on windows machines
2017-05-29 19:00:43 +01:00
Ro Savage
e6ddfb0411 Fix kill command in e2e-kitchensink.sh cleanup (#2397) 2017-05-29 11:09:40 +01:00
Dan Abramov
3f342383c3 Revert "Catch "No tests found" during CI" (#2390)
* Revert "Fix wrong path expansion in end-to-end test (#2388)"

This reverts commit 2aafaad72d.

* Revert "Suggest just "yarn build" (#2385)"

This reverts commit 70bf12505c.

* Revert "Catch "No tests found" during CI (#2387)"

This reverts commit 5317b3f910.
2017-05-27 23:26:03 +01:00