Commit Graph

4 Commits

Author SHA1 Message Date
William Monk
49ed54f346 Merge commit '84be4dd0bdf6155c075f9e9bee9f075d8982d0cd' into merge-facebook-master 2017-02-12 09:11:03 +00:00
Brandon Istenes
e19b0f6373 Make build exit with error code when interrupted (#1496)
* Make build exit with error code when interrupted

This addresses issue #1493.

Current behavior is that `npm run build` exits code 0 without creating a bundle when interrupted. This change makes the build script catch catchable interruptions and exit with the appropriate error code.

* Better error messages for kill signals

* Don't catch SIGINT

Ctrl+C should exit silently, and already produces a non-zero exit code when sent to the console while `npm run build` is running. Exit code 0 is produced if SIGINT is sent directly to the `node build.js` process, but this is unlikely to happen. A SIGINT handler in `build.js` will also be triggered by Ctrl+C in the console, potentially producing unnecessary noise.

* Style fix

* No changes needed to build.js

Problem is coming from the parent process, `react-scripts`

* Make react-scripts script handle signals

* Clarify context
2017-02-11 00:12:36 +00:00
Will Monk
9135f06260 Update Build Config 2016-12-12 14:09:18 +00:00
Ville Immonen
26464096d5 Set up a monorepo with Lerna 2016-09-19 10:52:19 +03:00