Commit Graph

991 Commits

Author SHA1 Message Date
Mateusz Burzyński
42640dfce1 Only suggest that tsconfig.json is incorrect when SyntaxError is caught (#6160)
Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
2019-04-04 15:18:15 -06:00
Ian Sutherland
001c23eff4 Enable futureEmitAssets in webpack config (#6696) 2019-04-04 14:35:48 -06:00
Ian Schmitz
76fea02277 Cleanup Jest config (#6654)
General cleanup after the [Jest 24 PR](#6278). 

This also includes `jsdom@14` via https://www.npmjs.com/package/jest-environment-jsdom-fourteen. Since we have a node >= 8.10 requirement, we are able to use the latest version of `jsdom` which includes additional implementations of browser APIs such as `MutationObserver` (which we had an issue filed for over at #6617).

/cc @SimenB. Is there more you recommend we do to cleanup our [Jest config](b0cbf2caa1/packages/react-scripts/scripts/utils/createJestConfig.js) for TypeScript?

Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
2019-04-04 11:00:00 -06:00
Cody Olsen
9514cb88ab Remove --coverage + --watch workaround (#4176) 2019-04-02 10:49:36 -07:00
Ian Sutherland
b4247378a3 Change app component declaration from arrow function to regular function (#6655)
* Change app component declaration from arrow function to regular function

* Change TypeScript template back to an arrow function
2019-03-18 20:18:21 -06:00
Jack Zhao
4734d4ef21 Merge branch 'master' into master 2019-03-18 17:50:52 -07:00
Abdelrahman Rifai
c5087e6cbe Remove shrink-to-fit=no from templates (#6669) 2019-03-18 12:28:16 -06:00
Ian Sutherland
6902736747 Unpin eslint-config-react-hooks dependency (#6653) 2019-03-15 13:46:12 -06:00
Lorenzo Rapetti
3be3576304 Update to Jest 24 (#6278)
* Update to jest 24

* Add notice about pnpResolver.js

* Formatting

* Fix linting

* Update to jest 24.1.0

* Update jest-pnp-resolver

* Swap create-react-app params in e2e scripts

* Add extraGlobals to supportedKeys

* Bump jest to 24.3.1

* Bump jest to 24.4.0

* Bumb jest to 24.5.0

* Update template dependencies jest to 24.5.0

* Debug failing test

* Remove jest-pnp-resolver

* Remove console.log

* Revert yarn.lock.cached
2019-03-15 12:02:59 -06:00
Ian Schmitz
eee8491d57 Add TypeScript linting support (#6513)
* Initial pass adding typescript-eslint

* Add warning to shared rule set

* Add documentation for setting up VSCode extension

* Provide tsconfig path to typescript-eslitn
2019-03-14 21:17:17 -06:00
Eivind Arvesen
7ae3146037 Support React Hooks (#5602) (#5997)
* Add Babel plug-in for Hooks; Add ESLint plug-in for Hooks (WIP)

* Fix transform destructuring loose config

* Add eslint-plugin-react-hooks to package.json

* Fix package.json's

* Fix eslint-plugin-react-hooks version

* Fix package.json

* Fix package.json

* Add eslint-plugin-react-hooks to script package.json

* Force array destructuring to work in loose mode only for known Hooks

* Update based on feedback from PR

* Add 'exhaustive-deps' lint rule

* Bump eslint-plugin-react-hooks to stable version

* Remove extraneous dependency from react-scripts
2019-03-14 20:36:30 -06:00
Ian Schmitz
f4f20a20d0 Support browserslist in @babel/preset-env (#6608)
* Add browserslist support to @babel/preset-env

* Support @babel/polyfill in entry point
2019-03-14 12:16:09 -07:00
Kelvin Jin
88d6f029bd Add empty mock for http2 (#5686) 2019-03-13 19:50:19 -06:00
ZHAO Jinxiang
b60f56fca7 change named import into default import (#6625) 2019-03-12 07:34:12 -07:00
Salvador Hernandez
dc133a351f Stage files for commit after ejecting (#5960)
* add command to add files to staging after eject

* update console.log message

* wrap git add in a try/catch block

* return true & update log message

* add test to check if files were staged

* Fix check for staged files
2019-03-11 22:06:37 -06:00
Ian Schmitz
3c9c21a285 Upgrade dependencies (#6614)
* Upgrade dependencies

* Upgrade a couple missed deps

* Run Prettier over codebase
2019-03-11 20:45:14 -06:00
Jannis Hell
5b77280dad Make compiler variable const instead of let (#6621)
compiler is not being reassigned, so we can use a const here
2019-03-11 12:42:20 -07:00
Ian Schmitz
1a04b96795 Type check JSON files (#6615) 2019-03-11 10:20:00 -06:00
ZHAO Jinxiang
e4fdac2418 Change class components to functional components in templates (#6451)
* change class component to function component

* Update packages/react-scripts/template/src/App.js

Co-Authored-By: xiaoxiangmoe <xiaoxiangmoe@gmail.com>

* Update packages/react-scripts/template-typescript/src/App.tsx

Co-Authored-By: xiaoxiangmoe <xiaoxiangmoe@gmail.com>
2019-03-11 10:05:21 -06:00
Mike Beaton
ed86da9ed3 Convert JSON.stringify \n to os.EOL when writing tsconfig.json (#6610) 2019-03-11 08:47:16 -07:00
Aftab Khan
2591590194 Update html-webpack-plugin (#6361) 2019-03-10 13:22:19 -06:00
ThePrez
c54e36d810 Update webpack-dev-server to 3.2.1 (#6483)
* Upgrade webpack-dev-server to 3.2.1
2019-03-09 11:58:03 -08:00
Ian Sutherland
c17e25bf7f Publish
- create-react-app@2.1.8
 - react-dev-utils@8.0.0
 - react-scripts@2.1.8
2019-03-06 17:53:30 -07:00
Ian Sutherland
1548a0a92e Reapply "Speed up TypeScript v2 (#6406)" (#6586)
This reverts commit b2cf28b7f1 and reapplies #6406.
2019-03-06 17:46:38 -07:00
Ian Sutherland
e69ad37fcf Publish
- create-react-app@2.1.7
 - react-dev-utils@7.0.5
 - react-scripts@2.1.7
2019-03-06 17:40:34 -07:00
Ian Sutherland
b2cf28b7f1 Revert "Speed up TypeScript v2 (#6406)" (#6585)
This reverts commit 6a5b3cdaaa.
2019-03-06 17:33:17 -07:00
Ian Sutherland
b5887dcac7 Publish
- babel-preset-react-app@7.0.2
 - confusing-browser-globals@1.0.6
 - create-react-app@2.1.6
 - eslint-config-react-app@3.0.8
 - react-app-polyfill@0.2.2
 - react-dev-utils@7.0.4
 - react-error-overlay@5.1.4
 - react-scripts@2.1.6
2019-03-06 16:17:21 -07:00
Jack Zhao
4a4d2eff4e remove argv 2019-02-21 14:39:01 -08:00
Jack Zhao
140e182e7d remove stats json 2019-02-21 14:35:34 -08:00
Jack Zhao
e7a427ad16 remove webpack-bundle-analyzer 2019-02-20 23:21:35 -08:00
Ian Schmitz
6c8e2e53c5 Use contenthash instead of chunkhash for better long-term caching (#6387) 2019-02-20 18:24:19 -08:00
Jack Zhao
28f5427979 revert css sourcemaps in development (#6472)
This fixes #6399.
2019-02-20 16:16:18 -05:00
Leigh Halliday
d57fd37d2d Convert all bit.ly links from http to https (#6239) 2019-02-19 09:25:19 -07:00
Ian Schmitz
6a5b3cdaaa Speed up TypeScript v2 (#6406)
* Revert "Revert "Speed up TypeScript projects (#5903)""

This reverts commit 544a5943ce.

* Move fork-ts-checker dep to react-dev-utils

* Convert WebpackDevServerUtils.createCompiler to take in options arg

* Update README.md for react-dev-utils
2019-02-18 16:31:44 -08:00
Ian Schmitz
09def49be5 Revert "Switch to eval-source-map (#5060)" (#6444)
This reverts commit 773d103986.
2019-02-18 06:50:16 -05:00
Aaron Reisman
df3e73f454 Exclude .d.ts files from TypeScript glob 2019-02-17 10:17:49 +02:00
Gasim Gasimzada
319cf9b9e1 Add forward ref to SVG Component (#5457)
* Add forward ref to SVG component

* Write proper component for the ref test

* Add ref to jest svg transform and fix tests

* Fix SVG file location

* Use proper `ref` instead of svgRef in tests

* Add ref to svgr loader
2019-02-14 12:20:39 -07:00
Ian Schmitz
1548e39bf7 Publish
- create-react-app@2.1.5
 - react-dev-utils@7.0.3
 - react-scripts@2.1.5
2019-02-11 08:36:54 -08:00
Ian Schmitz
544a5943ce Revert "Speed up TypeScript projects (#5903)"
This reverts commit 5ce09db2b3.
2019-02-11 08:10:33 -08:00
Ian Schmitz
72c49ac807 Revert "Move fork-ts-checker-webpack-plugin dependency to react-dev-utils (#6395)"
This reverts commit c2b715847c.
2019-02-11 08:10:10 -08:00
X.L
c2b715847c Move fork-ts-checker-webpack-plugin dependency to react-dev-utils (#6395) 2019-02-11 07:41:55 -08:00
Ian Schmitz
b02f181d0d Publish
- babel-plugin-named-asset-import@0.3.1
 - babel-preset-react-app@7.0.1
 - create-react-app@2.1.4
 - eslint-config-react-app@3.0.7
 - react-app-polyfill@0.2.1
 - react-dev-utils@7.0.2
 - react-error-overlay@5.1.3
 - react-scripts@2.1.4
2019-02-10 13:48:33 -08:00
Ian Schmitz
b7e0158441 Upgrade dependencies (#6393) 2019-02-10 12:24:40 -08:00
Dan Abramov
782d71b957 Add Jest typeahead plugin (#5213)
* Add Jest typeahead plugin

* Update jest-watch-typeahead to 0.2.1
2019-02-10 08:13:27 -08:00
Dominik Palo
caf0a30e38 Use semicolons in the ProcessEnv interface (#6364) 2019-02-08 07:41:30 -08:00
zhuoli99
18d5e87b75 Sass source map for dev (#5713)
Sass source map for dev
2019-02-07 21:18:50 -08:00
Tomáš Szabo
5ce09db2b3 Speed up TypeScript projects (#5903)
As a lot of [people](https://hackernoon.com/why-i-no-longer-use-typescript-with-react-and-why-you-shouldnt-either-e744d27452b4) is complaining about TypeScript performance in CRA, I decided to enable `async` mode in TypeScript checker.

These changes basically brings the JS compilation times to TS projects. So, recompilation took less than 1 second instead of 3 seconds in medium size project.

The problem with async mode is that type-errors are reported after Webpack ends up recompilation as TypeScript could be slower than Babel. PR allows to emit files compiled by Babel immediately and then wait for TS and show type errors in terminal later. Also, if there was no compilation errors and any type error occurs, we trigger a hot-reload with new errors to show error overlay in browser.

Also, I wanted to start a discussion about `skipLibCheck: false` option in default `tsconfig.json`. This makes recompilations really slow and we should consider to set it to `true` or at least give users a big warning to let them know that it could be really slow.

The following video is showing the updated workflow with a forced 2.5 second delay for type-check to give you an idea how it works.

![nov-26-2018 15-47-01](https://user-images.githubusercontent.com/5549148/49021284-9446fe80-f192-11e8-952b-8f83d77d5fbc.gif)


I'm pretty sure that PR needs some polishing and improvements but it should works as it is. Especially a "hack" with reloading the browser after type-check looks ugly to me.

cc @brunolemos as he is an initiator of an original TypeScript PR.

Should fix https://github.com/facebook/create-react-app/issues/5820
2019-02-07 19:34:52 -08:00
Chris Self
1deb811c5d Make manifest.json description more generic (#6355) 2019-02-06 19:40:17 -08:00
Charles Pritchard
bacb440748 Add empty mock for dns (#6292) 2019-02-05 09:38:52 +02:00
Rico Kahler
af339ec343 Add '--no-watch' flag for tests (#6285) 2019-02-01 17:49:52 +02:00