Commit Graph

2074 Commits

Author SHA1 Message Date
zhuoli99
18d5e87b75 Sass source map for dev (#5713)
Sass source map for dev
2019-02-07 21:18:50 -08:00
Timothy
817ecb1bb6 Update ZEIT Now deployment instructions (#6359) 2019-02-08 00:00:52 -05:00
Tomáš Szabo
5ce09db2b3 Speed up TypeScript projects (#5903)
As a lot of [people](https://hackernoon.com/why-i-no-longer-use-typescript-with-react-and-why-you-shouldnt-either-e744d27452b4) is complaining about TypeScript performance in CRA, I decided to enable `async` mode in TypeScript checker.

These changes basically brings the JS compilation times to TS projects. So, recompilation took less than 1 second instead of 3 seconds in medium size project.

The problem with async mode is that type-errors are reported after Webpack ends up recompilation as TypeScript could be slower than Babel. PR allows to emit files compiled by Babel immediately and then wait for TS and show type errors in terminal later. Also, if there was no compilation errors and any type error occurs, we trigger a hot-reload with new errors to show error overlay in browser.

Also, I wanted to start a discussion about `skipLibCheck: false` option in default `tsconfig.json`. This makes recompilations really slow and we should consider to set it to `true` or at least give users a big warning to let them know that it could be really slow.

The following video is showing the updated workflow with a forced 2.5 second delay for type-check to give you an idea how it works.

![nov-26-2018 15-47-01](https://user-images.githubusercontent.com/5549148/49021284-9446fe80-f192-11e8-952b-8f83d77d5fbc.gif)


I'm pretty sure that PR needs some polishing and improvements but it should works as it is. Especially a "hack" with reloading the browser after type-check looks ugly to me.

cc @brunolemos as he is an initiator of an original TypeScript PR.

Should fix https://github.com/facebook/create-react-app/issues/5820
2019-02-07 19:34:52 -08:00
Chris Self
1deb811c5d Make manifest.json description more generic (#6355) 2019-02-06 19:40:17 -08:00
Nathan Schneider
aa25c77bbc Fix missing article in README (#6346) 2019-02-06 09:56:36 +02:00
gottfired
1648ce8106 Fix order of args in tasks/cra test (#6342) 2019-02-05 09:45:57 +02:00
Charles Pritchard
bacb440748 Add empty mock for dns (#6292) 2019-02-05 09:38:52 +02:00
Rico Kahler
dea19fdb30 Add --no-watch test flag to docs (#6331) 2019-02-04 09:21:05 +02:00
James George
a78be99b5e Check for multiple project names when initializing (#6080) 2019-02-03 17:07:31 +02:00
Rico Kahler
af339ec343 Add '--no-watch' flag for tests (#6285) 2019-02-01 17:49:52 +02:00
Adriano Costa
714599dae6 Prevent cursor events on app-logo svg (#6276) 2019-01-25 15:26:26 -05:00
Ian Sutherland
91f54afb40 Update stale config to ignore additional labels 2019-01-24 22:01:55 -07:00
James K Nelson
3efcdbf328 Fix e2e:docker test failure (#6050)
* fix e2e:docker issue

* fix e2e tests
2019-01-21 20:24:34 -07:00
Nikita Lyzhov
1c591cb7a4 Update serve change listening port documentation (#6229)
* [docs] Change serve port flag and add example

* [docs] Add --listen flag
2019-01-20 13:46:50 -07:00
Ben Carp
ed5fb1066b Update updating-to-new-releases.md with note about global installs (#6190)
* Update updating-to-new-releases.md

Related to https://github.com/facebook/create-react-app/issues/6140

* Update updating-to-new-releases.md

Linking to getting started following discussion on #6190. 
Adapt terminology to current installation methods.

* Update updating-to-new-releases.md

typo, rleative link

* Update docusaurus/docs/updating-to-new-releases.md

Co-Authored-By: carpben <carpben@users.noreply.github.com>
2019-01-19 19:13:37 -07:00
Steven Tan
803946fe58 Changes to steps for publishing GitHub User Page (#6095)
* Changes to steps for publishing GitHub User Page

Remove the the step for switching to gh-pages branch as it is no longer a viable option.

* Changed projects to project
2019-01-16 18:39:34 -08:00
Dotan Simha
34e5029c54 Add empty mock for module (#5798) 2019-01-16 11:26:24 +02:00
Matthew Holloway
fd382772a1 Ignore node_modules in verifyNoTypeScript (#6022) 2019-01-14 13:54:46 +02:00
Otávio Pace
47e9e2c7a0 Move chalk dependency to react-dev-utils (#6150)
Related to #751
2019-01-12 13:55:57 +02:00
Adam Laycock
8174eed5b3 Upgrade @svgr/webpack to 4.1.0 (#5816)
* Upgrade svgr to 4.0.3

* Upgrade svgr to 4.0.4

* Remove unnecessary prettier option

* Update to 4.1.0
2019-01-11 22:45:32 -05:00
Dallon Feldner
132ac3523f Update local-test.sh to return test exit code (#6179)
The `e2e:docker` command can run tests in a Docker container, but it always returns exit code 0 even if the tests failed. This PR resolves that and returns the exit code from the test command.
2019-01-11 18:35:13 -05:00
Ian Schmitz
c8a540d9a1 Add react/react-dom dependencies to relative-paths test fixture (#6165) 2019-01-10 21:17:09 -08:00
Ian Schmitz
2741781bc6 Add note for global install of CLI (#6157)
* Add note for global install of CLI

Closes #6140.
2019-01-09 13:16:09 -08:00
David Rice
6e261f8a06 Update react-dev-util globby dependency to v8.0.2 (#6162)
v8.0.2 was recently released https://github.com/sindresorhus/globby/releases to fix some pathing issues with dir-glob.
2019-01-09 14:24:03 -05:00
loveky
caf0effda5 update link for difference between proposal stages (#6149)
seems the page which the old link points to has removed the related information.
2019-01-08 07:36:06 -08:00
Yangshun Tay
ddf294159f Remove extra table cell (#6141) 2019-01-07 07:53:08 -08:00
Jason Laster
773d103986 Switch to eval-source-map (#5060)
Switches to eval-source-map, which is easier for webpack to recompute
when a file changes and has column based mappings, which lets firefox
devtools show original variable in the debugger and evaluate original
expressions in the console.
2019-01-06 22:42:05 -05:00
Ian Schmitz
005ee5b952 Bump eslint-plugin-react version and update webpack config (#6132)
* Bump eslint-plugin-react version

* Move eslint-plugin-react settings into eslint-config-react-app

* Add react/no-typos rule
2019-01-06 15:05:14 -08:00
Joe Haddad
3e1dc99013 Fix CI and upgrade dependencies (#6137)
* Upgrade a bunch of dependencies

* Turn off nightly Yarn
2019-01-06 13:13:20 -05:00
Ian Schmitz
73e3d0ebf1 Update CHANGELOG.md v2.1.3 2019-01-04 11:02:24 -08:00
Ian Schmitz
0d0d0349a5 Publish
- create-react-app@2.1.3
 - react-dev-utils@7.0.1
 - react-error-overlay@5.1.2
 - react-scripts@2.1.3
react-scripts@2.1.3 react-dev-utils@7.0.1 react-error-overlay@5.1.2 create-react-app@2.1.3
2019-01-04 10:53:44 -08:00
Ian Schmitz
6a95aae96d Prepare 2.1.3 release 2019-01-04 10:08:47 -08:00
Hardo
dae67ff06a Fix typo in CSS modules docs (#6067) 2019-01-04 17:18:24 +02:00
Dan Abramov
c8c3e48abd Update adding-typescript.md 2019-01-03 15:38:20 +00:00
Zachary Friss
4c7c3c5e28 Update webpack-dev-server 3.1.9 -> 3.1.14 (#6064)
* Update webpack-dev-server 3.1.9 -> 3.1.14
2019-01-01 21:26:44 -08:00
Janne R
86eb24d4a6 Replace deprecated VSCode launch.json variable (#6110)
Replace deprecated ${workspaceRoot} variable with ${workspaceFolder} in VSCode launch.json. See https://code.visualstudio.com/docs/editor/variables-reference#_why-isnt-workspaceroot-documented
2019-01-01 14:02:48 -08:00
shawtung
1aca3cc416 Fix comment typo (#6036) 2018-12-30 18:45:05 -08:00
Prashant Andani
6fc1993728 Typo fixes (#6104)
<!--
Thank you for sending the PR!

If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots!

Happy contributing!
-->
2018-12-30 18:21:33 -08:00
Ian Sutherland
bf669a3a84 Update lock bot config 2018-12-28 12:15:33 -07:00
Jason Quense
e7b975e8c2 Generalize the Bootstrap documentation (#5631)
* Generalize the adding bootstrap documentation

* Update adding-bootstrap.md

* Update adding-bootstrap.md

* Update adding-bootstrap.md
2018-12-24 12:58:45 -07:00
Lukas Werfel
42a1b5acb2 Update eslint instructions in docs (#6084)
Add a note that it will work in IDE with 2.0.3 and later
2018-12-24 10:42:57 -05:00
Denis Mukhametov
0f4781e850 Fix control comment fo CSS Grid prefixing (#6061)
"on" value of "autoprefixer grid" is kinda deprecated. It's better to use "autoplace" or "no-autoplace" instead.
https://github.com/postcss/autoprefixer#options

"autoplace" enables PostCss' autoplace polyfill for ie and makes prefixes, "no-autoplace" only makes prefixes
https://github.com/postcss/autoprefixer#does-autoprefixer-polyfill-grid-layout-for-ie
2018-12-23 14:59:01 -05:00
Joe Haddad
c1714042b6 Add note to changelog v2.1.2 2018-12-23 13:56:53 -05:00
Joe Haddad
d7c0b59242 Publish
- babel-plugin-named-asset-import@0.3.0
 - babel-preset-react-app@7.0.0
 - create-react-app@2.1.2
 - eslint-config-react-app@3.0.6
 - react-app-polyfill@0.2.0
 - react-dev-utils@7.0.0
 - react-error-overlay@5.1.1
 - react-scripts@2.1.2
react-dev-utils@7.0.0 create-react-app@2.1.2 babel-preset-react-app@7.0.0 eslint-config-react-app@3.0.6 react-app-polyfill@0.2.0 react-error-overlay@5.1.1 react-scripts@2.1.2 babel-plugin-named-asset-import@0.3.0
2018-12-23 13:53:12 -05:00
Joe Haddad
6a7a43f3e4 Prepare 2.1.2 release 2018-12-23 13:50:24 -05:00
Joe Haddad
0702e78fbb Tweak contributing doc 2018-12-23 13:43:14 -05:00
Matheus Souza
45bc6280d1 Fix Markdown comment in proxying docs (#6009) 2018-12-11 09:35:24 -07:00
Dugagjin Lashi
3d1c0eacea add webp support for typescript (#5978)
* add webp support for typescript

* moved webp declaration below png
2018-12-11 10:53:44 -05:00
Max Belsky
4a6007e035 Add docs for creating new TypeScript project (#6015) 2018-12-11 09:45:39 +02:00
Ian Sutherland
1eff815f4d Make links to docs consistent in README (#6000) 2018-12-09 16:38:15 -07:00