Commit Graph

607 Commits

Author SHA1 Message Date
Francis Upton IV
14f4485aeb Fixed link to CSS imports blog post 2018-04-13 16:06:57 -06:00
Ro Savage
ae2cf07249 Update CSS Modules localIndetName (#4192)
* Update CSS Modules localIndetName

* Add missing file to package

* Correct regex

* plz plz plz
2018-04-13 16:14:31 -04:00
Andreas Cederström
06176e1ea4 bump babel 7 beta (#4253) 2018-04-05 07:28:30 +02:00
Andreas Cederström
7966139635 Small typo fix #4217 2018-04-04 08:46:15 +02:00
Dan Abramov
3b102fe1b9 Work around Jest environment resolving bug (#4247) 2018-04-03 18:44:59 +01:00
Vicente Plata
061d1e46fc Add troubleshooting for Github Pages (#4197)
Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
2018-04-03 00:51:58 +01:00
Plortinus
9c3f03cac7 use the lastest url of gitignore file (#4236)
* use the lastest url of gitignore file

* Update gitignore
2018-04-02 15:19:28 -04:00
Daniel
9a99b5d190 Fix typo and be clearer about ecma settings in uglifyjs options (#4239) 2018-04-02 15:17:24 -04:00
Daniel
2824bf2e15 [next] Revert to use ecma 5 in uglifyOptions (#4234)
* Revert to use ecma 5 in uglifyOptions

* remove explicit ecma version from uglifyOptions settings

The defaults are already what we want

* be explicit of where we use ecma: 8 and ecma: 5
2018-04-02 13:30:30 -04:00
bradfordlemley
9c167a4249 Add some stuff that requires transpilation. (#4174) 2018-03-25 21:14:59 -04:00
Ian Sutherland
8a34b7cc77 Add ESLint check for incorrect propTypes usage (#3840) (#4048) 2018-03-25 16:17:41 -06:00
bradfordlemley
058d03f8f8 Fix typos in example monorepo documentation. (#4164) 2018-03-21 17:42:30 -04:00
Brian Ng
cb3f835586 Bump babel-related deps (#4159)
* Add explicit dep on plugin-proposal-object-rest-spread to babel-preset-react-app

* Bump babel-related deps to beta.42

* Pass useBuiltIns directly to react-preset
2018-03-18 14:22:56 -06:00
Harry Moreno
1e52f252fc Remove ref to non free resource (#4160)
the screencast for react storybook is non-free. Remove.
2018-03-15 21:50:58 +00:00
Stas Rudakou
65e0621622 Fix a typo in packages/react-scripts/template/README.md (#4089)
s/allows to easily makes/allows you to easily make/
2018-03-04 20:45:19 -05:00
João Paquim
041f44c7af Docs: Update status of Object Rest/Spread proposal (#4101) 2018-03-04 20:40:15 -05:00
nikolas2
b49762ac1a docs: use node_js 8 in example travis.yml (#4107)
This is the current node LTS release.
2018-03-04 20:35:18 -05:00
Ian Sutherland
43fbf0f3d6 Update dotenv to 5.0.0 (#4009) 2018-02-10 12:45:40 -07:00
bradfordlemley
2c34d5b66e Use yarn when running inside yarn workspace. (#3997)
* Run yarn after ejecting.

* On eject, choose to run yarn instead of npm if yarn is available.

* Move monorepo to react-dev-utils.

* Fix lint.

* Rename monorepo to workspaceUtils.

* Add react-dev-utils dep for create-react-app.

* getMonorepo -> findMonorepo
2018-02-10 13:07:19 +00:00
Robin van der Vleuten
aaf022ca39 Set the public path to the asset manifest entries (#2544) 2018-02-09 13:14:14 +00:00
Ian Sutherland
c263f17784 Upgrade dotenv-expand to 4.2.0 (#3961) (#3992) 2018-02-09 13:11:32 +00:00
Ade Viankakrisna Fadlil
47d2d94118 Ensure workspaces key exists in parent package.json (#3989)
* add default value for globPatterns

without this, the latest alpha broke on start
```
/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:130
    .reduce(
     ^

TypeError: Cannot read property 'reduce' of undefined
    at findPkgs (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:130:6)
    at getMonorepoPkgPaths (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:143:22)
    at Object.<anonymous> (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:155:55)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)
error Command failed with exit code 1.
```

* also check for pkgPatterns for null

* Update paths.js
2018-02-06 21:27:14 -05:00
Andrew Ho
ea760ff84a Fix typo (#3956)
sever => server
2018-02-03 23:59:26 -05:00
Pete Nykänen
779dad5546 Add loader for .graphql files (#3909)
* Add graphql loader to webpack config

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Update README.md

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Update react-scripts README.md

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Add graphql jest transform

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Add integration tests, pin versions in package.json

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Tests expect regexp matchers

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Use strict equal test instead

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Escaping is hard

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Add comment for signifying a different file

* Update docs

* Fix jest config

* Remove node_modules exclusion

* Update README.md

* Inline graphql jest transform

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Update copyright header

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>

* Use .graphql extension only

Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
2018-02-03 15:51:55 +00:00
Ian Sutherland
d0e17316b9 Named asset import for SVG files (#3907)
* Add named asset import for svg files via babel plugin and webpack loader.

* Fix failing e2e test

* Switched to svgr loader

* Updated SVG component test

* Disable named asset import plugin in test environment

* Added tests for including SVG in CSS

* Update tests

* Moved babel plugin config into webpack config
2018-02-02 12:56:57 -07:00
bradfordlemley
aa8789b1aa Add react-scripts version compatibility for monorepos. (#3953) 2018-02-01 23:08:12 +00:00
bradfordlemley
b43ad04b88 Add support for yarn and lerna monorepos. (#3741)
* Support for multiple source paths via package.json srcPaths entry.

Initial support for yarn workspace.

Support lerna workspace, fix for when to use template files.

Remove support for specifying srcPaths in package.json.

Re-enable transpilation caching.

* Clean up, use file matching (similar to original) in webpack configs instead of matching function.

* Remove package lock files.

* Fix for eject.
Note: monorepos won't work after eject.
Can be fixed easily with JEST 22.0.?+ which has file pattern matches against realpaths.

* Filter tests to run only tests in monorepo components included by the app.
(Not sure this is desireable, might be cool to be able to easily run all tests in monorepo from one app.)

* Fix conditions for when to use template.

* Fix eject.

* Remove code that is not needed w/ Jest 22.

* Include all cra-comp tests in monorepo instead of trying to include only tests that are dependencies of app.
(tests can be easily filtered via jest cli if desired, e.g. 'npm test -- myapp comp1')

* Pin find-pkg version.

* Hopefully fix jest test file matching on windows by removing first slash.

* E2E tests for monorepo.

* Run monorepo tests in CI.

* Fix and test post-eject build.

* Fix e2e test.

* Fix test suite names in appveyor.

* Include individual package dirs as srcPaths instead of top-level monorepo root.
Fixes build/start after eject.

* Fix running tests after eject.

* Clean up test workspace, add some verifcations.

* Cleanup.

* Try to fix hang when running test on appveyor.

* Don't write babel or lint config to package.json when ejecting.

* Incorporate review comments.
* Simply monorepo pkg finder
* Only include monorepo pkgs if app itself is included in monorepo
* Check for specific tests in e2e

* Fixes for windows.

* Fix for kitchensink mocha tests compiling.

* Add lerna monorepo test.

* Fix lerna bootstrap on windows.

* Incorporate more review comments:
* remove support for lerna w/o yarn workspace
* add react and react-dom as devDeps to comp1 and comp2

* Add monorepo info to user guide.
2018-02-01 20:58:18 +00:00
Michaël De Boey
3767d91886 Fix package repository name (#3900) 2018-01-23 00:25:03 +00:00
Michaël De Boey
25184c4e91 Fix links to package (#3898) 2018-01-22 22:16:22 +00:00
Dan Abramov
d49ffde4e6 Fix the E2E script (#3888)
* Fix the E2E script

* Delete .git if committing failed
2018-01-21 23:31:03 +00:00
Dan Abramov
1cf2248c46 Don't use app node_modules folder as a resolve fallback (#3884) 2018-01-21 19:05:24 +00:00
Bond
db75a16a13 Update short link for PWA (#3872) 2018-01-21 11:25:11 +00:00
Piotr
39126a102b Provide callbacks in serviceWorker (next) (#3867)
* Provide callbacks in serviceWorker

* revert exporting default function
2018-01-20 19:15:32 +00:00
Dan Abramov
b3527d7783 Fix git init race condition (#3877) 2018-01-20 18:32:41 +00:00
Maurice de Beijer
247e5c90a0 Create git repository with initial commit (#1288)
* Create git repo with initial commit

* Fixe commit message

* Added the git repo to the docs

* Bail if we are in a mercurial repository

* Removed Chore from commit mesage

* Create repo after installing react and react-dom

* Removed docs

* Commit changes when ejecting

* Update after review

* git add -A instead of git add . after code review
2018-01-19 13:12:34 +00:00
Ian Sutherland
0e51eef6d7 Disable service worker by default (#3817)
* WIP disable service worker by default (#2554)

* Updated service worker registration

* Readd default export in registerServiceWorker.js

* Updated comments about using Service Worker

* Call it serviceWorker

* Nits
2018-01-19 00:13:54 +00:00
Bond
9d67605ab6 Use custom bit.ly links (#3836)
* change link to advanced deployment

* Use custom CRA link for deployment

* use custom link for minification failure

* update link for deployment

* feedback
2018-01-18 09:17:02 -05:00
Joe Haddad
9754a23170 Bump deps 2018-01-18 00:04:38 -05:00
Joe Haddad
713eec417d Babel 7 disabled code highlighting by default 😢 (#3849) 2018-01-17 22:05:45 -05:00
Andrew
c9b289b64d fix small grammatical typo in webpack config documentation (#3842) 2018-01-17 21:34:08 +00:00
Dan Abramov
406ab6c3c0 Bump Babel 2018-01-17 20:44:59 +00:00
Ian Sutherland
82907fd23c Import SVGs as React components (#1388) (#3718)
* Import SVGs as React components (#1388)

* Updated webpack production config and fixed tests

* Improved Jest SVG file transform

* Improved SVG tests

* Add a comment

* Update webpack.config.prod.js
2018-01-17 19:40:56 +00:00
Luke Jackson
f6ad7fe7f8 Applies new theme and adds docs link to template (#3235)
* Applies dark theme and adds link to reactjs.org

* Just "learn React"

* Tweaks
2018-01-17 19:37:53 +00:00
Joe Haddad
11f1aa09b3 Remove CSS modules docs (#3832) 2018-01-17 10:34:38 -05:00
Joe Haddad
f4988e224a Update comments for accuracy 2018-01-17 10:30:45 -05:00
Ro Savage
fc7c9915b0 Add support for CSS Modules with explicit filename (#2285)
* Add css modules with [name].modules.css file convention

* Add e2e for CSS Modules

* Updated based on feedback

* Change css modules class name to be deterministic and fix licences

* Update css modules class naming convention
2018-01-17 10:20:57 -05:00
Edward Ren (Eddie)
0ddc043a97 Updated react-scripts Readme.md to better document GitHub Pages hosting with custom domains (#3821) 2018-01-17 14:34:53 +00:00
Jack Franklin
7969b48cd0 Enhance Jest config error for setupTestFrameworkScriptFile (#3512)
* Enhance Jest config error for `setupTestFrameworkScriptFile`

I wasn't aware of the fact that users of c-r-a could just define
`src/setupTests.js` and it would be configured with Jest - I nearly
ejected before I found a GitHub issue that confirmed this functionality.

I thought it might be a nice idea to add it to the error about Jest
config overrides to stop others ejecting when they don't need to.

* Change the order of Jest config errors.

* Show different error for `setupTestFrameworkScriptFile`

* Tweak the message
2018-01-17 13:26:22 +00:00
Dan Abramov
72c3d4ebb5 Try to fix CI (#3806)
* Try to fix CI

* Bump Jest elsewhere

* Bump Babel elsewhere

* Fix CI on Windows by writing .cmd file back
2018-01-16 18:24:14 +00:00
Dan Abramov
19e0bb1881 Support Jest --watchAll flag (#3804)
* Support Jest --watchAll flag

* Use clearer condition

* Add comma
2018-01-15 17:49:57 +00:00