mirror of
https://github.com/zhigang1992/create-react-app.git
synced 2026-04-24 05:05:53 +08:00
update to modern code style (#1738)
* mv create-react-app/index.js -> create-react-app/creteReactApp.js * update to modern code style * var -> cosnt * set trailing-coma to es5 for prettier
This commit is contained in:
Valerii Sorokobatko
committed by
Dan Abramov
Dan Abramov
parent
43873dc9b8
commit
fe7b5c212b
149
packages/react-scripts/scripts/init.js
vendored
149
packages/react-scripts/scripts/init.js
vendored
@@ -7,19 +7,28 @@
|
||||
* LICENSE file in the root directory of this source tree. An additional grant
|
||||
* of patent rights can be found in the PATENTS file in the same directory.
|
||||
*/
|
||||
|
||||
'use strict';
|
||||
|
||||
var fs = require('fs-extra');
|
||||
var path = require('path');
|
||||
var spawn = require('cross-spawn');
|
||||
var chalk = require('chalk');
|
||||
const fs = require('fs-extra');
|
||||
const path = require('path');
|
||||
const spawn = require('cross-spawn');
|
||||
const chalk = require('chalk');
|
||||
|
||||
module.exports = function(appPath, appName, verbose, originalDirectory, template) {
|
||||
var ownPackageName = require(path.join(__dirname, '..', 'package.json')).name;
|
||||
var ownPath = path.join(appPath, 'node_modules', ownPackageName);
|
||||
var appPackage = require(path.join(appPath, 'package.json'));
|
||||
var useYarn = fs.existsSync(path.join(appPath, 'yarn.lock'));
|
||||
module.exports = function(
|
||||
appPath,
|
||||
appName,
|
||||
verbose,
|
||||
originalDirectory,
|
||||
template
|
||||
) {
|
||||
const ownPackageName = require(path.join(
|
||||
__dirname,
|
||||
'..',
|
||||
'package.json'
|
||||
)).name;
|
||||
const ownPath = path.join(appPath, 'node_modules', ownPackageName);
|
||||
const appPackage = require(path.join(appPath, 'package.json'));
|
||||
const useYarn = fs.existsSync(path.join(appPath, 'yarn.lock'));
|
||||
|
||||
// Copy over some of the devDependencies
|
||||
appPackage.dependencies = appPackage.dependencies || {};
|
||||
@@ -27,10 +36,10 @@ module.exports = function(appPath, appName, verbose, originalDirectory, template
|
||||
|
||||
// Setup the script rules
|
||||
appPackage.scripts = {
|
||||
'start': 'react-scripts start',
|
||||
'build': 'react-scripts build',
|
||||
'test': 'react-scripts test --env=jsdom',
|
||||
'eject': 'react-scripts eject'
|
||||
start: 'react-scripts start',
|
||||
build: 'react-scripts build',
|
||||
test: 'react-scripts test --env=jsdom',
|
||||
eject: 'react-scripts eject',
|
||||
};
|
||||
|
||||
fs.writeFileSync(
|
||||
@@ -38,58 +47,71 @@ module.exports = function(appPath, appName, verbose, originalDirectory, template
|
||||
JSON.stringify(appPackage, null, 2)
|
||||
);
|
||||
|
||||
var readmeExists = fs.existsSync(path.join(appPath, 'README.md'));
|
||||
const readmeExists = fs.existsSync(path.join(appPath, 'README.md'));
|
||||
if (readmeExists) {
|
||||
fs.renameSync(path.join(appPath, 'README.md'), path.join(appPath, 'README.old.md'));
|
||||
fs.renameSync(
|
||||
path.join(appPath, 'README.md'),
|
||||
path.join(appPath, 'README.old.md')
|
||||
);
|
||||
}
|
||||
|
||||
// Copy the files for the user
|
||||
var templatePath = template ? path.resolve(originalDirectory, template) : path.join(ownPath, 'template');
|
||||
const templatePath = template
|
||||
? path.resolve(originalDirectory, template)
|
||||
: path.join(ownPath, 'template');
|
||||
if (fs.existsSync(templatePath)) {
|
||||
fs.copySync(templatePath, appPath);
|
||||
} else {
|
||||
console.error('Could not locate supplied template: ' + chalk.green(templatePath));
|
||||
console.error(
|
||||
`Could not locate supplied template: ${chalk.green(templatePath)}`
|
||||
);
|
||||
return;
|
||||
}
|
||||
|
||||
// Rename gitignore after the fact to prevent npm from renaming it to .npmignore
|
||||
// See: https://github.com/npm/npm/issues/1862
|
||||
fs.move(path.join(appPath, 'gitignore'), path.join(appPath, '.gitignore'), [], function (err) {
|
||||
if (err) {
|
||||
// Append if there's already a `.gitignore` file there
|
||||
if (err.code === 'EEXIST') {
|
||||
var data = fs.readFileSync(path.join(appPath, 'gitignore'));
|
||||
fs.appendFileSync(path.join(appPath, '.gitignore'), data);
|
||||
fs.unlinkSync(path.join(appPath, 'gitignore'));
|
||||
} else {
|
||||
throw err;
|
||||
fs.move(
|
||||
path.join(appPath, 'gitignore'),
|
||||
path.join(appPath, '.gitignore'),
|
||||
[],
|
||||
err => {
|
||||
if (err) {
|
||||
// Append if there's already a `.gitignore` file there
|
||||
if (err.code === 'EEXIST') {
|
||||
const data = fs.readFileSync(path.join(appPath, 'gitignore'));
|
||||
fs.appendFileSync(path.join(appPath, '.gitignore'), data);
|
||||
fs.unlinkSync(path.join(appPath, 'gitignore'));
|
||||
} else {
|
||||
throw err;
|
||||
}
|
||||
}
|
||||
}
|
||||
});
|
||||
);
|
||||
|
||||
var command;
|
||||
var args;
|
||||
let command;
|
||||
let args;
|
||||
|
||||
if (useYarn) {
|
||||
command = 'yarnpkg';
|
||||
args = ['add'];
|
||||
} else {
|
||||
command = 'npm';
|
||||
args = [
|
||||
'install',
|
||||
'--save',
|
||||
verbose && '--verbose'
|
||||
].filter(function(e) { return e; });
|
||||
args = ['install', '--save', verbose && '--verbose'].filter(e => e);
|
||||
}
|
||||
args.push('react', 'react-dom');
|
||||
|
||||
// Install additional template dependencies, if present
|
||||
var templateDependenciesPath = path.join(appPath, '.template.dependencies.json');
|
||||
const templateDependenciesPath = path.join(
|
||||
appPath,
|
||||
'.template.dependencies.json'
|
||||
);
|
||||
if (fs.existsSync(templateDependenciesPath)) {
|
||||
var templateDependencies = require(templateDependenciesPath).dependencies;
|
||||
args = args.concat(Object.keys(templateDependencies).map(function (key) {
|
||||
return key + '@' + templateDependencies[key];
|
||||
}));
|
||||
const templateDependencies = require(templateDependenciesPath).dependencies;
|
||||
args = args.concat(
|
||||
Object.keys(templateDependencies).map(key => {
|
||||
return `${key}@${templateDependencies[key]}`;
|
||||
})
|
||||
);
|
||||
fs.unlinkSync(templateDependenciesPath);
|
||||
}
|
||||
|
||||
@@ -97,12 +119,12 @@ module.exports = function(appPath, appName, verbose, originalDirectory, template
|
||||
// which doesn't install react and react-dom along with react-scripts
|
||||
// or template is presetend (via --internal-testing-template)
|
||||
if (!isReactInstalled(appPackage) || template) {
|
||||
console.log('Installing react and react-dom using ' + command + '...');
|
||||
console.log(`Installing react and react-dom using ${command}...`);
|
||||
console.log();
|
||||
|
||||
var proc = spawn.sync(command, args, {stdio: 'inherit'});
|
||||
const proc = spawn.sync(command, args, { stdio: 'inherit' });
|
||||
if (proc.status !== 0) {
|
||||
console.error('`' + command + ' ' + args.join(' ') + '` failed');
|
||||
console.error(`\`${command} ${args.join(' ')}\` failed`);
|
||||
return;
|
||||
}
|
||||
}
|
||||
@@ -110,51 +132,56 @@ module.exports = function(appPath, appName, verbose, originalDirectory, template
|
||||
// Display the most elegant way to cd.
|
||||
// This needs to handle an undefined originalDirectory for
|
||||
// backward compatibility with old global-cli's.
|
||||
var cdpath;
|
||||
if (originalDirectory &&
|
||||
path.join(originalDirectory, appName) === appPath) {
|
||||
let cdpath;
|
||||
if (originalDirectory && path.join(originalDirectory, appName) === appPath) {
|
||||
cdpath = appName;
|
||||
} else {
|
||||
cdpath = appPath;
|
||||
}
|
||||
|
||||
// Change displayed command to yarn instead of yarnpkg
|
||||
var displayedCommand = useYarn ? 'yarn' : 'npm';
|
||||
const displayedCommand = useYarn ? 'yarn' : 'npm';
|
||||
|
||||
console.log();
|
||||
console.log('Success! Created ' + appName + ' at ' + appPath);
|
||||
console.log(`Success! Created ${appName} at ${appPath}`);
|
||||
console.log('Inside that directory, you can run several commands:');
|
||||
console.log();
|
||||
console.log(chalk.cyan(' ' + displayedCommand + ' start'));
|
||||
console.log(chalk.cyan(` ${displayedCommand} start`));
|
||||
console.log(' Starts the development server.');
|
||||
console.log();
|
||||
console.log(chalk.cyan(' ' + displayedCommand + ' run build'));
|
||||
console.log(chalk.cyan(` ${displayedCommand} run build`));
|
||||
console.log(' Bundles the app into static files for production.');
|
||||
console.log();
|
||||
console.log(chalk.cyan(' ' + displayedCommand + ' test'));
|
||||
console.log(chalk.cyan(` ${displayedCommand} test`));
|
||||
console.log(' Starts the test runner.');
|
||||
console.log();
|
||||
console.log(chalk.cyan(' ' + displayedCommand + ' run eject'));
|
||||
console.log(' Removes this tool and copies build dependencies, configuration files');
|
||||
console.log(' and scripts into the app directory. If you do this, you can’t go back!');
|
||||
console.log(chalk.cyan(` ${displayedCommand} run eject`));
|
||||
console.log(
|
||||
' Removes this tool and copies build dependencies, configuration files'
|
||||
);
|
||||
console.log(
|
||||
' and scripts into the app directory. If you do this, you can’t go back!'
|
||||
);
|
||||
console.log();
|
||||
console.log('We suggest that you begin by typing:');
|
||||
console.log();
|
||||
console.log(chalk.cyan(' cd'), cdpath);
|
||||
console.log(' ' + chalk.cyan(displayedCommand + ' start'));
|
||||
console.log(` ${chalk.cyan(`${displayedCommand} start`)}`);
|
||||
if (readmeExists) {
|
||||
console.log();
|
||||
console.log(chalk.yellow('You had a `README.md` file, we renamed it to `README.old.md`'));
|
||||
console.log(
|
||||
chalk.yellow(
|
||||
'You had a `README.md` file, we renamed it to `README.old.md`'
|
||||
)
|
||||
);
|
||||
}
|
||||
console.log();
|
||||
console.log('Happy hacking!');
|
||||
};
|
||||
|
||||
function isReactInstalled(appPackage) {
|
||||
var dependencies = appPackage.dependencies || {};
|
||||
const dependencies = appPackage.dependencies || {};
|
||||
|
||||
return (
|
||||
typeof dependencies.react !== 'undefined' &&
|
||||
typeof dependencies['react-dom'] !== 'undefined'
|
||||
)
|
||||
return typeof dependencies.react !== 'undefined' &&
|
||||
typeof dependencies['react-dom'] !== 'undefined';
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user