kylefang/create-react-app
1
0
Fork 0
mirror of https://github.com/zhigang1992/create-react-app.git synced 2026-03-29 00:18:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

avoid TypeError on when registering service workers without config (#5301)

Browse Source 
* avoid TypeError on when registering service workers without config

Fixes #5299

* same before config.onUpdate
This commit is contained in:
Peter Bengtsson
2018-10-04 22:42:16 -04:00
committed by Joe Haddad
parent ea15ebad8f
commit e783bf8aed
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/react-scripts/template/src/serviceWorker.js vendored
View File

@@ -68,7 +68,7 @@ function registerValidSW(swUrl, config) {
console.log('New content is available; please refresh.');
// Execute callback
if (config.onUpdate) {
if (config && config.onUpdate) {
config.onUpdate(registration);
}
} else {
@@ -78,7 +78,7 @@ function registerValidSW(swUrl, config) {
console.log('Content is cached for offline use.');
// Execute callback
if (config.onSuccess) {
if (config && config.onSuccess) {
config.onSuccess(registration);
}
}