From d0b534d845720a089eadcc321fddac13bb8d7631 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Sun, 27 Nov 2016 15:42:34 -0500 Subject: [PATCH] Add a hint for closing the prompt --- packages/react-dev-utils/failFast.js | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/packages/react-dev-utils/failFast.js b/packages/react-dev-utils/failFast.js index 4a92a7a4..cf2989f3 100644 --- a/packages/react-dev-utils/failFast.js +++ b/packages/react-dev-utils/failFast.js @@ -18,6 +18,13 @@ overflow: 'auto' } + const exitStyle = { + position: 'fixed', + top: '1em', + right: '1em', + 'font-size': '0.8em' + } + const headerStyle = { 'font-size': '1.5em', 'font-weight': 'bold' @@ -44,7 +51,9 @@ function applyStyles(element, styles) { element.setAttribute('style', '') // Firefox can't handle const due to non-compliant implementation + // Revisit Jan 2016 // https://developer.mozilla.org/en-US/Firefox/Releases/51#JavaScript + // https://bugzilla.mozilla.org/show_bug.cgi?id=1101653 for (let key in styles) { if (!styles.hasOwnProperty(key)) continue element.style[key] = styles[key].toString() @@ -59,6 +68,11 @@ const overlay = document.createElement('div') applyStyles(overlay, overlayStyle) + const exit = document.createElement('div') + exit.appendChild(document.createTextNode('press [escape] to close this prompt')) + applyStyles(exit, exitStyle) + overlay.appendChild(exit) + // Create header const header = document.createElement('div') applyStyles(header, headerStyle) @@ -69,7 +83,9 @@ const trace = document.createElement('div') applyStyles(trace, traceStyle) // Firefox can't handle const due to non-compliant implementation + // Revisit Jan 2016 // https://developer.mozilla.org/en-US/Firefox/Releases/51#JavaScript + // https://bugzilla.mozilla.org/show_bug.cgi?id=1101653 for (let frame of frames) { const { functionName, fileName, lineNumber } = frame const url = `${fileName}:${lineNumber}`