kylefang/create-react-app
1
0
Fork 0
mirror of https://github.com/zhigang1992/create-react-app.git synced 2026-04-29 09:55:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make formatWebpackMessages return all messages (#2834)

Browse Source 
* Move the reduction of the messages to a single place in the place it is used.

* Fix variable name
This commit is contained in:
Stéphane Goetz
2017-08-09 03:37:04 +02:00
committed by Joe Haddad
parent d009a99094
commit badfc2a8d9
3 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/react-dev-utils/WebpackDevServerUtils.js vendored
View File

@@ -164,6 +164,11 @@ function createCompiler(webpack, config, appName, urls, useYarn) {
// If errors exist, only show errors. // If errors exist, only show errors.
if (messages.errors.length) { if (messages.errors.length) {
// Only keep the first error. Others are often indicative
// of the same problem, but confuse the reader with noise.
if (messages.errors.length > 1) {
messages.errors.length = 1;
}
console.log(chalk.red('Failed to compile.\n')); console.log(chalk.red('Failed to compile.\n'));
console.log(messages.errors.join('\n\n')); console.log(messages.errors.join('\n\n'));
return; return;

5
packages/react-dev-utils/formatWebpackMessages.js vendored
View File

@@ -121,11 +121,6 @@ function formatWebpackMessages(json) {
// preceding a much more useful Babel syntax error. // preceding a much more useful Babel syntax error.
result.errors = result.errors.filter(isLikelyASyntaxError); result.errors = result.errors.filter(isLikelyASyntaxError);
} }
// Only keep the first error. Others are often indicative
// of the same problem, but confuse the reader with noise.
if (result.errors.length > 1) {
result.errors.length = 1;
}
return result; return result;
} }

5
packages/react-scripts/scripts/build.js vendored
View File

@@ -122,6 +122,11 @@ function build(previousFileSizes) {
} }
const messages = formatWebpackMessages(stats.toJson({}, true)); const messages = formatWebpackMessages(stats.toJson({}, true));
if (messages.errors.length) { if (messages.errors.length) {
// Only keep the first error. Others are often indicative
// of the same problem, but confuse the reader with noise.
if (messages.errors.length > 1) {
messages.errors.length = 1;
}
return reject(new Error(messages.errors.join('\n\n'))); return reject(new Error(messages.errors.join('\n\n')));
} }
if ( if (