kylefang/create-react-app
1
0
Fork 0
mirror of https://github.com/zhigang1992/create-react-app.git synced 2026-04-25 21:55:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Turn on Babel helpers (#5093)

Browse Source 
* Turn on helpers and test importing something with async/await works

* Compiling babel runtime breaks itself

* Add helpers option to babel plugin with defaults

* Make helpers off by default and on in our configuration

* Hit eject and e2e

* meh

* copy'n'paste

* change again

* Turn off helpers by default in /prod, /dev, /test

* oops

* Spread undefined

* Use object assign not object spread

* Put preset in template since it's needed

* Fix e2e tests
This commit is contained in:
Joe Haddad
2018-09-25 18:59:06 -04:00
committed by GitHub
parent 5599eff861
commit adfb20c403
9 changed files with 35 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tasks/e2e-kitchensink.sh
View File

@@ -146,8 +146,8 @@ PORT=3001 \
nohup yarn start &>$tmp_server_log &
grep -q 'You can now view' <(tail -f $tmp_server_log)
# Before running Mocha, specify that it should use our preset
# TODO: this is very hacky and we should find some other solution
# We haven't ejected yet which means there's no `babel` key
# in package.json yet
echo '{"presets":["react-app"]}' > .babelrc
# Test "development" environment