From 9fd98447d8afeef90efc669040b52fc65bc06484 Mon Sep 17 00:00:00 2001 From: Oskar Persson Date: Sun, 7 Oct 2018 00:27:30 +0200 Subject: [PATCH] Fix file size report after build (#5335) Fixes #5333 printFileSizesAfterBuild calls canReadAsset with an object containing the file name while measureFileSizesBeforeBuild calls it with just the name. When canReadAsset only receives the name it returns false since accessing the `name` property results in undefined. This commit fixes that by having canReadAssset instead expect only the file name and making printFileSizesAfterBuild just like measureFileSizesBeforeBuild only provide the name as argument. --- packages/react-dev-utils/FileSizeReporter.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-dev-utils/FileSizeReporter.js b/packages/react-dev-utils/FileSizeReporter.js index c718e6e3..b2b4cc69 100644 --- a/packages/react-dev-utils/FileSizeReporter.js +++ b/packages/react-dev-utils/FileSizeReporter.js @@ -17,9 +17,9 @@ var gzipSize = require('gzip-size').sync; function canReadAsset(asset) { return ( - /\.(js|css)$/.test(asset.name) && - !/service-worker\.js/.test(asset.name) && - !/precache-manifest\.[0-9a-f]+\.js/.test(asset.name) + /\.(js|css)$/.test(asset) && + !/service-worker\.js/.test(asset) && + !/precache-manifest\.[0-9a-f]+\.js/.test(asset) ); } @@ -37,7 +37,7 @@ function printFileSizesAfterBuild( .map(stats => stats .toJson({ all: false, assets: true }) - .assets.filter(canReadAsset) + .assets.filter(asset => canReadAsset(asset.name)) .map(asset => { var fileContents = fs.readFileSync(path.join(root, asset.name)); var size = gzipSize(fileContents);