From 6311bac13e1d8bd7b813eb49e3218461c67b3fdc Mon Sep 17 00:00:00 2001 From: Eduardo Duran Date: Wed, 31 Oct 2018 09:47:00 -0400 Subject: [PATCH] Make serviceWorker config argument optional in template (#5651) --- .../react-scripts/template-typescript/src/serviceWorker.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-scripts/template-typescript/src/serviceWorker.ts b/packages/react-scripts/template-typescript/src/serviceWorker.ts index 7c316eac..c0b13105 100644 --- a/packages/react-scripts/template-typescript/src/serviceWorker.ts +++ b/packages/react-scripts/template-typescript/src/serviceWorker.ts @@ -25,7 +25,7 @@ type Config = { onUpdate?: (registration: ServiceWorkerRegistration) => void; }; -export function register(config: Config) { +export function register(config?: Config) { if (process.env.NODE_ENV === 'production' && 'serviceWorker' in navigator) { // The URL constructor is available in all browsers that support SW. const publicUrl = new URL( @@ -62,7 +62,7 @@ export function register(config: Config) { } } -function registerValidSW(swUrl: string, config: Config) { +function registerValidSW(swUrl: string, config?: Config) { navigator.serviceWorker .register(swUrl) .then(registration => { @@ -106,7 +106,7 @@ function registerValidSW(swUrl: string, config: Config) { }); } -function checkValidServiceWorker(swUrl: string, config: Config) { +function checkValidServiceWorker(swUrl: string, config?: Config) { // Check if the service worker can be found. If it can't reload the page. fetch(swUrl) .then(response => {