kylefang/create-react-app
1
0
Fork 0
mirror of https://github.com/zhigang1992/create-react-app.git synced 2026-01-12 22:46:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make serviceWorker config argument optional in template (#5651)

Browse Source
This commit is contained in:
Eduardo Duran
2018-10-31 09:47:00 -04:00
committed by Joe Haddad
parent e1321e520c
commit 6311bac13e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/react-scripts/template-typescript/src/serviceWorker.ts
View File

@@ -25,7 +25,7 @@ type Config = {
onUpdate?: (registration: ServiceWorkerRegistration) => void;
};
export function register(config: Config) {
export function register(config?: Config) {
if (process.env.NODE_ENV === 'production' && 'serviceWorker' in navigator) {
// The URL constructor is available in all browsers that support SW.
const publicUrl = new URL(
@@ -62,7 +62,7 @@ export function register(config: Config) {
}
}
function registerValidSW(swUrl: string, config: Config) {
function registerValidSW(swUrl: string, config?: Config) {
navigator.serviceWorker
.register(swUrl)
.then(registration => {
@@ -106,7 +106,7 @@ function registerValidSW(swUrl: string, config: Config) {
});
}
function checkValidServiceWorker(swUrl: string, config: Config) {
function checkValidServiceWorker(swUrl: string, config?: Config) {
// Check if the service worker can be found. If it can't reload the page.
fetch(swUrl)
.then(response => {