kylefang/create-react-app
1
0
Fork 0
mirror of https://github.com/zhigang1992/create-react-app.git synced 2026-01-12 22:46:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Local testing docker links (#2662)

Browse Source 
* Fix a command style in docs

* Add a link to docker's docs
This commit is contained in:
Fabrizio Castellarin
2017-06-28 17:01:08 +02:00
committed by Dan Abramov
parent 6ab0ec0075
commit 60ae2b6d4c
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@@ -92,7 +92,7 @@ and then run `npm start` or `npm run build`.
## Contributing to E2E (end to end) tests
**TL;DR** use the command yarn e2e:docker to run unit and e2e tests.
**TL;DR** use the command `yarn e2e:docker` to run unit and e2e tests.
More detailed information are in the dedicated [README](/packages/react-scripts/fixtures/kitchensink/README.md).

2
packages/react-scripts/fixtures/kitchensink/README.md
View File

@@ -10,6 +10,8 @@ In order to run them locally, without having to manually install and configure e
This is a simple script that runs a **Docker** container, where the node version, git branch to clone, test suite, and whether to run it with `yarn` or `npm` can be chosen.
Simply run `yarn e2e:docker -- --help` to get additional info.
If you need guidance installing **Docker**, you should follow their [official docs](https://docs.docker.com/engine/installation/).
## Writing tests
Each time a new feature is added, it is advised to add at least one test covering it.