kylefang/create-react-app
1
0
Fork 0
mirror of https://github.com/zhigang1992/create-react-app.git synced 2026-04-24 05:05:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Toggle mjs files to javascript/auto type (#5151)

Browse Source
This commit is contained in:
Joe Haddad
2018-09-28 08:34:06 -04:00
committed by GitHub
parent 2a7346e085
commit 3ae3cf3678
7 changed files with 81 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
fixtures/smoke/graphql-with-mjs/index.test.js Normal file
View File

@@ -0,0 +1,17 @@
const {
bootstrap,
isSuccessfulDevelopment,
isSuccessfulProduction,
} = require('../../utils');
beforeEach(async () => {
await bootstrap({ directory: global.testDirectory, template: __dirname });
});
describe('graphql with mjs entrypoint', () => {
it('builds in development', async () => {
await isSuccessfulDevelopment({ directory: global.testDirectory });
});
it('builds in production', async () => {
await isSuccessfulProduction({ directory: global.testDirectory });
});
});

10
fixtures/smoke/graphql-with-mjs/package.json Normal file
View File

@@ -0,0 +1,10 @@
{
"dependencies": {
"apollo-boost": "0.1.16",
"graphql": "14.0.2",
"react-apollo": "2.2.1",
"react": "latest",
"react-dom": "latest",
"react-scripts": "latest"
}
}

9
fixtures/smoke/graphql-with-mjs/public/index.html Normal file
View File

@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>React App</title>
</head>
<body>
<div id="root"></div>
</body>
</html>

20
fixtures/smoke/graphql-with-mjs/src/App.js Normal file
View File

@@ -0,0 +1,20 @@
import React, { Component } from 'react';
import ApolloClient from 'apollo-boost';
import { ApolloProvider } from 'react-apollo';
const client = new ApolloClient({
uri: '/whatever',
});
class App extends Component {
render() {
return (
<ApolloProvider client={client}>
<div />
</ApolloProvider>
);
}
}
export default App;

5
fixtures/smoke/graphql-with-mjs/src/index.js Normal file
View File

@@ -0,0 +1,5 @@
import React from 'react';
import ReactDOM from 'react-dom';
import App from './App';
ReactDOM.render(<App />, document.getElementById('root'));

10
packages/react-scripts/config/webpack.config.dev.js
View File

@@ -187,6 +187,16 @@ module.exports = {
],
include: paths.appSrc,
},
{
// `mjs` support is still in its infancy in the ecosystem, so we don't
// support it.
// Modules who define their `browser` or `module` key as `mjs` force
// the use of this extension, so we need to tell webpack to fall back
// to auto mode (ES Module interop, allows ESM to import CommonJS).
test: /\.mjs$/,
include: /node_modules/,
type: 'javascript/auto',
},
{
// "oneOf" will traverse all following loaders until one will
// match the requirements. When no loader matches it will fall

10
packages/react-scripts/config/webpack.config.prod.js
View File

@@ -244,6 +244,16 @@ module.exports = {
],
include: paths.appSrc,
},
{
// `mjs` support is still in its infancy in the ecosystem, so we don't
// support it.
// Modules who define their `browser` or `module` key as `mjs` force
// the use of this extension, so we need to tell webpack to fall back
// to auto mode (ES Module interop, allows ESM to import CommonJS).
test: /\.mjs$/,
include: /node_modules/,
type: 'javascript/auto',
},
{
// "oneOf" will traverse all following loaders until one will
// match the requirements. When no loader matches it will fall