66 Commits

Author SHA1 Message Date
Yossef Mendelssohn
f0a9ad99e0 Refactoring CLI#run
If reporting is going to live within/around CLI#run, I want it to be
its own thing. It feels more right this way, except I don't much like
the `process` method name. I just don't have a good name for "actual
run" where "run" has been co-opted to mean "report on the actual run".
2012-10-05 15:44:27 -04:00
Yossef Mendelssohn
ea7719caa1 report → reporter
It makes more sense this way. I was trying too hard on the length
instead of the content.
2012-10-05 15:39:18 -04:00
Yossef Mendelssohn
9fe1b631fd ivar → attr 2012-10-05 15:34:23 -04:00
Yossef Mendelssohn
66c4796f3e Don't affect issues unless it's wanted 2012-10-05 02:16:55 -04:00
Yossef Mendelssohn
1a1070f04e Check for whether issues should be affected 2012-10-05 02:14:33 -04:00
Yossef Mendelssohn
6c879a8dc4 Give CLI a Checkout, too
It'll need this to check for master branch.

It's all coming together.
2012-10-05 02:05:41 -04:00
Yossef Mendelssohn
e1a5da7a55 Move master? from Config to Checkout
It belongs with sha/changes/dirty?, and you know it.
2012-10-05 02:04:17 -04:00
Yossef Mendelssohn
988c9803bb Report failure/success of CLI#run
There's some repetition I'm not sure about here. I went with what the
comment said, though.
2012-10-05 01:56:54 -04:00
Yossef Mendelssohn
71edf89ddf Add Reporter to CLI 2012-10-05 01:42:16 -04:00
Yossef Mendelssohn
d9264b31f8 line shortening and cleanup 2012-10-05 00:16:41 -04:00
Yossef Mendelssohn
71fadf88a7 Move sha from Reporter to Checkout 2012-10-04 23:37:45 -04:00
Yossef Mendelssohn
96b8f94111 Add comment when auto-closing issues 2012-10-04 23:32:20 -04:00
Yossef Mendelssohn
9c73e9104d Can label ongoing failures to leave them open 2012-10-04 23:23:42 -04:00
Yossef Mendelssohn
0caeeb14b4 Reporter can also close failures
This refers to the auto-opened failures, so we're looking for open
issues on this repo created by the same user and having the failure
label.
2012-10-04 23:15:14 -04:00
Yossef Mendelssohn
e02a63cdb9 Remove changes/dirty? from Config 2012-10-04 22:45:22 -04:00
Yossef Mendelssohn
821e30aa3a Use changes from Checkout instead of Config 2012-10-04 22:44:33 -04:00
Yossef Mendelssohn
e82f191f7f chdir when checking local changes
This seems like an oversight in the original code.
2012-10-04 22:40:38 -04:00
Yossef Mendelssohn
6926afea96 Add Boxen::Checkout
This class handles the local checkout of the boxen/boxen repo. Y'know,
things like saying whether there are changes.
2012-10-04 22:38:03 -04:00
Yossef Mendelssohn
10ca468bc1 Make failure label customizable 2012-10-04 22:27:56 -04:00
Yossef Mendelssohn
bf97e2b7a4 Add puppet command to failure details
Now the Reporter needs to know about the Puppeteer as well.

I'm not sure how I feel about a method called `command` returning an
array and consumers of that method needing to know to join it. On the
other hand, I don't really want to have a method called
`command_string`. It's kind of a dumb name.

It also makes the mock objects used in the tests more hairy, but those
should be ripped out and replaced with actual objects soon enough.
2012-10-04 17:53:51 -04:00
Yossef Mendelssohn
484e2c9df9 add failure label to created issue
We may want to make this label configurable, and also create it if
necessary.
2012-10-04 16:47:15 -04:00
Yossef Mendelssohn
50ec7f93c2 config ivar → attr_reader 2012-10-04 16:44:11 -04:00
Yossef Mendelssohn
e67995526a Add log to failure details
Adding Reporter#log and tests.
2012-10-04 16:26:05 -04:00
Yossef Mendelssohn
f846c5e7d7 Add changes to failure details 2012-10-04 16:26:05 -04:00
Yossef Mendelssohn
acfe3095ec Add Config#changes and tests for it and #dirty? 2012-10-04 16:26:05 -04:00
Yossef Mendelssohn
cbc429959f Add Reporter#failure_details
Starting this off, more details forthcoming.
2012-10-04 16:26:05 -04:00
Yossef Mendelssohn
b06c33434b Add Reporter#record_failure 2012-10-04 16:26:05 -04:00
John Barnette
4e051a10c4 Start extracting/porting a Boxen::Reporter 2012-10-03 21:59:16 -07:00
John Barnette
d00ea25ee3 Add Config#reponame 2012-10-03 21:36:06 -07:00
John Barnette
bb56d27ab1 Add a boxen_repodir fact 2012-10-03 18:56:06 -07:00
Will Farrington
4b748f3d4e caffeinate puppet run also 2012-10-03 16:56:31 -07:00
Will Farrington
f306153830 Use caffeinate to prevent sleep during run 2012-10-03 16:49:27 -07:00
Will Farrington
663b965a7b force puppet to try to own things with group admin, fixes chicken-egg problem with puppet group 2012-10-03 16:06:41 -07:00
John Barnette
b8fad4b051 Run librarian-puppet if it's relevant 2012-10-03 13:38:55 -07:00
John Barnette
b0944b24e3 Alphabetize 2012-10-03 13:09:54 -07:00
John Barnette
85fbccdc2e Specify multiple libdirs with separate flags 2012-10-03 13:08:51 -07:00
John Barnette
b57c59191d Deal with tokens in the creds preflight 2012-10-03 13:05:30 -07:00
John Barnette
46f8230e3b Always ensure the homedir 2012-10-03 12:44:17 -07:00
John Barnette
2e461a82f3 Add the boxen gem's lib to Puppet's libdir 2012-10-03 12:33:43 -07:00
John Barnette
7821aac009 Add token to Boxen::Config 2012-10-03 12:29:43 -07:00
Will Farrington
1c1e1fe977 first spike 2012-10-03 12:15:43 -07:00
Mike Skalnik
3f73dbc923 Merge pull request #5 from boxen/rvm-preflight
Add RVM preflight check
2012-10-03 11:53:33 -07:00
John Barnette
320bcf281c Module path is modules:shared 2012-10-03 10:49:15 -07:00
Mike Skalnik
6ac25b80e4 Abort if RVM is found 2012-10-03 13:42:53 -04:00
Mike Skalnik
7af8d33f8b Capitalize RVM properly 2012-10-03 12:31:26 -04:00
Mike Skalnik
3b43cb0f8e Add RVM preflight check 2012-10-03 11:36:29 -04:00
John Barnette
32bca15a65 Handle tmpdirs and logfiles a bit better 2012-10-02 18:30:35 -07:00
John Barnette
4894a9ec3a Alphabetize 2012-10-02 17:46:45 -07:00
John Barnette
3b136923da Actually run the stuff with the things 2012-10-02 17:36:27 -07:00
John Barnette
a23736de55 Stub localized puppeteer 2012-10-02 17:23:17 -07:00