From eb31df294035bdf013d06277d605feda22bc7742 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Wed, 4 Mar 2015 08:46:45 -0800 Subject: [PATCH] Rename FakeWindow to BrowserWindowProxy --- atom/renderer/lib/override.coffee | 4 ++-- spec/chromium-spec.coffee | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/atom/renderer/lib/override.coffee b/atom/renderer/lib/override.coffee index 61d476568..bb469711a 100644 --- a/atom/renderer/lib/override.coffee +++ b/atom/renderer/lib/override.coffee @@ -3,7 +3,7 @@ ipc = require 'ipc' remote = require 'remote' # Window object returned by "window.open". -class FakeWindow +class BrowserWindowProxy constructor: (@guestId) -> ipc.on 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_CLOSED', (guestId) => if guestId is @guestId @@ -53,7 +53,7 @@ window.open = (url, frameName='', features='') -> guestId = ipc.sendSync 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_OPEN', url, frameName, options if guestId - new FakeWindow(guestId) + new BrowserWindowProxy(guestId) else console.error 'It is not allowed to open new window from this WebContents' null diff --git a/spec/chromium-spec.coffee b/spec/chromium-spec.coffee index d433672cb..171a02457 100644 --- a/spec/chromium-spec.coffee +++ b/spec/chromium-spec.coffee @@ -32,9 +32,9 @@ describe 'chromium feature', -> assert.notEqual navigator.language, '' describe 'window.open', -> - it 'returns a FakeWindow object', -> + it 'returns a BrowserWindowProxy object', -> b = window.open 'about:blank', 'test', 'show=no' - assert.equal b.constructor.name, 'FakeWindow' + assert.equal b.constructor.name, 'BrowserWindowProxy' b.close() describe 'creating a Uint8Array under browser side', ->