mirror of
https://github.com/HackPlan/atom-shell.git
synced 2026-03-29 16:49:02 +08:00
BrowserWindow.focus() should not make window become visible, fixed #106.
This commit is contained in:
@@ -209,7 +209,10 @@ void NativeWindowMac::Move(const gfx::Rect& pos) {
|
||||
}
|
||||
|
||||
void NativeWindowMac::Focus(bool focus) {
|
||||
if (focus && [window() isVisible]) {
|
||||
if (!IsVisible())
|
||||
return;
|
||||
|
||||
if (focus) {
|
||||
[[NSApplication sharedApplication] activateIgnoringOtherApps:YES];
|
||||
[window() makeKeyAndOrderFront:nil];
|
||||
} else {
|
||||
|
||||
@@ -67,6 +67,14 @@ describe 'window module', ->
|
||||
++count
|
||||
w.loadUrl 'about:blank'
|
||||
|
||||
describe 'BrowserWindow.focus()', ->
|
||||
it 'does not make the window become visible', ->
|
||||
w = new BrowserWindow(show: false)
|
||||
assert.equal w.isVisible(), false
|
||||
w.focus()
|
||||
assert.equal w.isVisible(), false
|
||||
w.close()
|
||||
|
||||
describe 'beforeunload handler', ->
|
||||
it 'returning true would not prevent close', (done) ->
|
||||
w = new BrowserWindow(show: false)
|
||||
|
||||
Reference in New Issue
Block a user