kylefang/angular.js
1
0
Fork 0
mirror of https://github.com/zhigang1992/angular.js.git synced 2026-04-02 09:00:34 +08:00
Code Issues Packages Projects Releases Wiki Activity
5,215 Commits 18 Branches 121 Tags
eff00ea98cf6aebc73fa95c01384ba7c4ee6cb2b
Commit Graph

250 Commits

Author SHA1 Message Date
Vikram Soni
dfd228497b Updated e2e spec to remove warning 
on
element(by.css(.phones li a)).click();

selenium will throw a warning message that more then one element found.

element.all(by.css('.phones li a')).first().click(); fixes the issue
 2014-07-21 16:09:03 -07:00
Trey Hunner
a54d4600b3 style: fix whitespace issues 
Closes #8277
 2014-07-21 14:52:41 -07:00
Bill Neubauer
0a51a05d4e docs(tutorial/step-9): link to list of filters rather than filterProvider 
Closes #8082
 2014-07-06 07:43:21 +01:00
Peter Bacon Darwin
ae0de07a1b docs(tutorial/step-0): remove hyphen and clarify items 
Closes #5953
 2014-07-03 12:49:22 +01:00
Robert Kielty
b7c315558d docs(tutorial/step-7): improve injector information 
I attempted to tighten up the language around the DI overview so that it was clearer
and more explicit. The sole responsibilities sentence was semantically jarring and
I think looks better as a list.  Some minor grammar improvements.

Closes #7099
 2014-07-03 12:22:32 +01:00
Alex Muntada
28e6500a59 docs(tutorial/step-4): fix e2e test 
After a protractor update the test syntax had to be changed.

Closes #7919
 2014-06-20 14:35:57 +01:00
Brian Ford
b21122002a docs(tutorial/step_09): fix link to filter guide 2014-06-10 01:34:41 -07:00
Matt Johansen
c6088da00f docs(tutorial/step_09): note about 'Filter' suffix 
Reminder that 'Filter' is appended to filter names when injected.
Link to Filter guide where this is mentioned.
 2014-06-09 21:44:48 -07:00
Peter Bacon Darwin
560f00860d docs(tutorial): mention additional Debian install step 
Thanks to GSC Leticia (gsc-leticia) for identifying this problem.

Closes #7665
 2014-06-06 21:27:23 +01:00
Juan Manuel Palacios
45fed49abf docs(tutorial/step_12): clarify that jQuery should be loaded first 
jQuery needs to be loaded before *all* AngularJS modules in the app,
because otherwise AngularJS will not detect the presence of jQuery and
animations  will not work as expected.
 2014-06-03 17:40:33 -07:00
Jake Buob
8c02a49bb4 docs(tutorial/step_07): fix typo 2014-06-03 16:37:52 -07:00
Dken
b5d2a2a813 docs(tutorial/index): update requisite version of node 
Not all 0.10.x support `^` in versions in `package.json`
 2014-06-03 16:30:11 -07:00
Anuj More
847b9705cb docs(tutorial/index): fix typo 2014-06-03 15:58:35 -07:00
Caitlin Potter
16aa3aff51 docs(tutorial): fix minor errors in step 11 
I added these when amending the previous commit. My bad ._.
 2014-05-31 17:37:54 -04:00
aschokking
42a367df81 docs(tutorial): add karma config update reference to step 11 
When including the ng-resource module you appear to need to add a reference to the karma config file
as well or the unit tests will fail. This burned me for a while when going through the tutorial.

Closes #7651
 2014-05-31 17:33:03 -04:00
Jan
55818331a8 docs(tutorial): add instructions to make experiment render readably in step 5 
Update step_05.ngdoc

Closes #7653
 2014-05-31 13:19:59 -04:00
dumpweed
10406de450 docs(tutorial/step_05): improve explanation of _-prefix 2014-05-30 17:27:42 -07:00
Firexion
6341224d60 docs(tutorial): make code samples in step 7 match code in angular-phonecat 
Update step_07.ngdoc

Modifying the code snippets provided to match what was on git

Closes #7521
 2014-05-30 09:57:05 -04:00
venticello
4eb9522f90 docs(tutorial/step-12): fix typo 
Closes #7596
 2014-05-27 23:46:05 -07:00
Juan Manuel Palacios
3f365f5238 docs(tutorial): match html from angular-phonecat in step 7 instructions 
Place phoneId binding in a proper HTML node

The code where the phoneId binding in the phone-detail.html template is first explained in step 7
of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test
against the view (also introduced in step 7) fail.

The test acquires the binding right from the view (by.binding('phoneId')), and apparently this
operation fails when the binding is not a child of an HTML node, and therefore the entire test also
fails. As soon as the binding is placed inside a <span></span> tag pair, the binding is found and
the test passes. The code on github for step 7 has it right, the binding is within the span tags,
but in the documentation I'm patching here the span's are missing.

☆.。.：*・゜☆ MERCI ☆.。.：*・゜☆

Closes #7561
 2014-05-23 01:31:46 -04:00
Zorigt Bazarragchaa
f37a2dab7f docs(tutorial/index): explain E2E acronym 
It was confusing to read "end 2 end" as a numeric two. I kept wondering what two end(s).
Later in the tutorial, the text switched to "End to End" which made more sense than numeric two.
 2014-05-22 13:19:40 -07:00
Max Tobias Weber
6e2ab81937 docs(tutorial): update code snippet for step 7 
replaced bootstrap 2 with bootstrap 3 classes

Closes #7433
 2014-05-21 17:10:30 -07:00
Brice
b5fb2d4bec docs(tutorial): improve instructions for causing test failure (step 2) 
Increase readability for test fail line

Closes #6943
 2014-05-21 17:32:04 -04:00
Tim van den Eijnden
d3163ff1cf docs(tutorial): fix controller unit tests to match phonecat / avoid ReferenceError 
fix 'ReferenceError: PhoneDetailCtrl is not defined' & 'ReferenceError: PhoneListCtrl is not defined' in Karma unit tests

Closes #7421
 2014-05-21 16:37:47 -04:00
kalvn
0a3268f106 docs(tutorial): corrected version of jquery installed via bower (step 12) 
Corrected the version of jquery in the text content.

Closes #7441
 2014-05-21 16:29:57 -04:00
Firexion
92f588cd15 docs(tutorial): add <span> to index.html to match phonecat step4 
Add missing <span> to app/index.html to match actual code on github

☆.。.：*・゜☆ Merci beaucoup! ☆.。.：*・゜☆

Closes #7520
 2014-05-21 11:28:17 -04:00
GSC Leticia
ef13820cad docs(tutorial): add instructions for running node in Debian-based distributions 
Specifying command for Debian based distributions, like Ubuntu, Mint, etc.

☆.。.：*・゜☆ Fantastique! ☆.。.：*・゜☆

Closes #7422
 2014-05-21 11:20:20 -04:00
Peter Bacon Darwin
16a7d54351 docs(tutorial/step-5): update image to match code 
Closes #2753
 2014-05-21 13:58:36 +01:00
Gaëtan PRIOUR
f34de0ba35 docs(tutorial): fixed path to controllersSpec.js file 
☆.。.：*・゜☆ DOMO ARIGATO MR ROBOTO ☆.。.：*・゜☆

Closes #7504
 2014-05-20 12:16:27 -04:00
Kebabpizza
d8bc44b7e9 docs(tutorial): fix link to bower in step 12 
Muchas gracias! \o/

Closes #7507
 2014-05-18 20:46:54 -04:00
Peter Bacon Darwin
e0e9ccdb79 docs(tutorial): move bower_components into app folder 2014-05-05 20:54:07 +01:00
Jamie Krug
3f540e3d8a docs(tutorial/step-07): fix typo in route pattern 
One instance of `/phones/:phoneId` erroneously had a singular version,
`/phone/:phoneId`, which does not match what was actually used in the code.

Closes #7313
 2014-05-04 20:52:59 +01:00
Peter Bacon Darwin
e16c6aa31d docs(tutorial/step-3): fix experiments 
Closes https://github.com/angular/angular-phonecat/issues/142
 2014-04-27 10:13:44 +01:00
Peter Bacon Darwin
305696c660 docs(tutorial/step-12): add info about app.css changes 
Closes https://github.com/angular/angular-phonecat/issues/145
 2014-04-27 09:10:10 +01:00
@MizaelGalvez
6ac6621661 docs(tutorial/step_09): fix typos 
phonecatApp module had a dot instead of semicolon
 2014-04-25 00:47:40 +01:00
Mohamed Daif
39335d96d3 docs(tutorial/step_00): add correct description for attributes naming convention 2014-04-25 00:18:25 +01:00
Peter Bacon Darwin
eda00ce23f docs(tutorial): clarify bower usage 2014-04-24 10:59:04 +01:00
nnennajohn
8681276590 docs(tutorial/index): add directions for installing bower 2014-04-22 16:26:19 -07:00
Amin Ogarrio
219648fada docs(tutorial/step-12): correct file path 
Fixed wrong file path:
- angular/angular-animate.js -> angular-animate/angular-animate.js, which meets the code in app/index.html

Closes #7168
 2014-04-21 16:20:22 -07:00
Simon Taranto
2da94a701b docs(tutorial): update step_07.ngdoc 
Closes #7169
 2014-04-21 15:32:23 -07:00
ttam3d0
5ce17efbbd docs(tutorial/step_03): sync markup with angular-phonecat 
Update from Bootstrap 2.3 to 3.1 changed "span" to "col" tags

Closes #7172
 2014-04-21 15:22:58 -07:00
Amin Ogarrio
b1559be5cf docs(tutorial): fix typos in examples 
The phonecatApp and phonecatAnimations modules have a dot where a semicolon should be at the end of the sentence

Closes #7167
 2014-04-21 15:09:04 -07:00
Thomas Junghans
8570585692 docs(tutorial): update step_11.ngdoc 
Change toEqual to toEqualData in the test 'should create "phones" model with 2 phones fetched from xhr'
to make test more consistent.

Closes #7182
 2014-04-21 15:01:55 -07:00
jerryfan
02fcac5e04 docs(tutorial/step_12): fix grammar 2014-04-18 18:38:37 -04:00
expilo
b2e48e61c7 docs(tutorial): specify that ng-repeat goes in markup and not script 
Just to make clear that it should not go to test spec.

Closes #7104
 2014-04-17 12:43:01 -04:00
Thom Allen
d5a2069cd5 docs(tutorial): fix typo in module name 
Fixed a typo in step 2

Closes #7138
 2014-04-16 16:24:14 -04:00
Robert Speicher
66091756b8 docs(tutorial): npm needs "run" keyword for custom script names 
Fix "npm run update-webdriver" command

Closes #7071
 2014-04-10 08:24:16 -04:00
Thomas Wicker
091eb83301 docs(tutorial): fix typo in tutorial index page 
Spelling error, "server" should be "serve"

Closes #7028
 2014-04-07 07:39:54 -04:00
Peter Bacon Darwin
64d404612f docs(tutorial/step-8): fix external link 2014-04-06 18:58:01 +01:00
Yiling Lu
6c7fdd845b docs(tutorial/step-8): link to Protractor rather than ngScenario 
Angular test runner API has been deprecated, Protractor is advised:
http://docs.angularjs.org/guide/e2e-testing
Link is updated to direct reader to Protractor API.

Closes #7001
 2014-04-06 17:34:36 +01:00