Karl Yang
9d6240561b
docs(tutorial): remove index.html from app url
2014-07-23 10:32:58 -07:00
Vikram Soni
c280d5ab02
Updated e2e spec to remove warning
...
on
element(by.css(.phones li a)).click();
selenium will throw a warning message that more then one element found.
element.all(by.css('.phones li a')).first().click(); fixes the issue
2014-07-21 16:10:42 -07:00
Trey Hunner
1c15cdc2d0
style: fix whitespace issues
...
Closes #8277
Conflicts:
docs/content/guide/migration.ngdoc
2014-07-21 14:52:06 -07:00
Bill Neubauer
ecbb374826
docs(tutorial/step-9): link to list of filters rather than filterProvider
...
Closes #8082
2014-07-15 12:40:26 +01:00
Peter Bacon Darwin
1d8e42070a
docs(tutorial/step-0): remove hyphen and clarify items
...
Closes #5953
2014-07-03 12:51:21 +01:00
Robert Kielty
fe6b2fbfc4
docs(tutorial/step-7): improve injector information
...
I attempted to tighten up the language around the DI overview so that it was clearer
and more explicit. The sole responsibilities sentence was semantically jarring and
I think looks better as a list. Some minor grammar improvements.
Closes #7099
2014-07-03 12:24:15 +01:00
Alex Muntada
03777445e8
docs(tutorial/step-4): fix e2e test
...
After a protractor update the test syntax had to be changed.
Closes #7919
2014-06-20 14:36:13 +01:00
Brian Ford
fcfe2b3793
docs(tutorial/step_09): fix link to filter guide
2014-06-10 01:34:58 -07:00
Matt Johansen
286f269753
docs(tutorial/step_09): note about 'Filter' suffix
...
Reminder that 'Filter' is appended to filter names when injected.
Link to Filter guide where this is mentioned.
2014-06-09 22:01:57 -07:00
Peter Bacon Darwin
e906aafb0a
docs(tutorial): mention additional Debian install step
...
Thanks to GSC Leticia (gsc-leticia) for identifying this problem.
Closes #7665
2014-06-06 21:28:13 +01:00
Juan Manuel Palacios
b306babe29
docs(tutorial/step_12): clarify that jQuery should be loaded first
...
jQuery needs to be loaded before *all* AngularJS modules in the app,
because otherwise AngularJS will not detect the presence of jQuery and
animations will not work as expected.
2014-06-03 17:48:18 -07:00
Jake Buob
d9317cde4f
docs(tutorial/step_07): fix typo
2014-06-03 16:41:27 -07:00
Dken
23c8af232f
docs(tutorial/index): update requisite version of node
...
Not all 0.10.x support `^` in versions in `package.json`
2014-06-03 16:36:31 -07:00
Anuj More
369f69d67a
docs(tutorial/index): fix typo
2014-06-03 16:00:00 -07:00
Caitlin Potter
bc2a5aaf05
docs(tutorial): fix minor errors in step 11
...
I added these when amending the previous commit. My bad ._.
2014-05-31 17:38:38 -04:00
aschokking
4547c11dad
docs(tutorial): add karma config update reference to step 11
...
When including the ng-resource module you appear to need to add a reference to the karma config file
as well or the unit tests will fail. This burned me for a while when going through the tutorial.
2014-05-31 17:33:51 -04:00
Jan
c0b360b993
docs(tutorial): add instructions to make experiment render readably in step 5
...
Update step_05.ngdoc
Closes #7653
2014-05-31 13:20:52 -04:00
dumpweed
a659049893
docs(tutorial/step_05): improve explanation of _-prefix
2014-05-30 17:30:58 -07:00
Firexion
199825ec26
docs(tutorial): make code samples in step 7 match code in angular-phonecat
...
Update step_07.ngdoc
Modifying the code snippets provided to match what was on git
2014-05-30 09:58:16 -04:00
venticello
8ff671753c
docs(tutorial/step-12): fix typo
...
Closes #7596
2014-05-28 10:26:18 -07:00
Juan Manuel Palacios
28c0497524
docs(tutorial): match html from angular-phonecat in step 7 instructions
...
Place phoneId binding in a proper HTML node
The code where the phoneId binding in the phone-detail.html template is first explained in step 7
of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test
against the view (also introduced in step 7) fail.
The test acquires the binding right from the view (by.binding('phoneId')), and apparently this
operation fails when the binding is not a child of an HTML node, and therefore the entire test also
fails. As soon as the binding is placed inside a <span></span> tag pair, the binding is found and
the test passes. The code on github for step 7 has it right, the binding is within the span tags,
but in the documentation I'm patching here the span's are missing.
☆.。.:*・゜☆ MERCI ☆.。.:*・゜☆
2014-05-23 01:33:07 -04:00
Zorigt Bazarragchaa
c241a57761
docs(tutorial/index): explain E2E acronym
...
It was confusing to read "end 2 end" as a numeric two. I kept wondering what two end(s).
Later in the tutorial, the text switched to "End to End" which made more sense than numeric two.
2014-05-22 13:21:16 -07:00
Max Tobias Weber
b5391fae8f
docs(tutorial): update code snippet for step 7
...
replaced bootstrap 2 with bootstrap 3 classes
Closes #7433
2014-05-21 15:54:41 -07:00
Brice
78954ffcde
docs(tutorial): improve instructions for causing test failure (step 2)
...
Increase readability for test fail line
Closes #6943
2014-05-21 17:32:31 -04:00
Tim van den Eijnden
c94190139d
docs(tutorial): fix controller unit tests to match phonecat / avoid ReferenceError
...
fix 'ReferenceError: PhoneDetailCtrl is not defined' & 'ReferenceError: PhoneListCtrl is not defined' in Karma unit tests
Closes #7421
2014-05-21 16:38:40 -04:00
kalvn
32bd990eda
docs(tutorial): corrected version of jquery installed via bower (step 12)
...
Corrected the version of jquery in the text content.
2014-05-21 16:31:30 -04:00
Firexion
acaf9be685
docs(tutorial): add <span> to index.html to match phonecat step4
...
Add missing <span> to app/index.html to match actual code on github
☆.。.:*・゜☆ Merci beaucoup! ☆.。.:*・゜☆
2014-05-21 11:29:30 -04:00
GSC Leticia
bdd75c97ad
docs(tutorial): add instructions for running node in Debian-based distributions
...
Specifying command for Debian based distributions, like Ubuntu, Mint, etc.
☆.。.:*・゜☆ Fantastique! ☆.。.:*・゜☆
2014-05-21 11:22:47 -04:00
Peter Bacon Darwin
ccc8ec869b
docs(tutorial/step-5): update image to match code
...
Closes #2753
2014-05-21 13:58:48 +01:00
Gaëtan PRIOUR
c5e39c688b
docs(tutorial): fixed path to controllersSpec.js file
...
☆.。.:*・゜☆ DOMO ARIGATO MR ROBOTO ☆.。.:*・゜☆
2014-05-20 12:19:33 -04:00
Kebabpizza
2866daf7d6
docs(tutorial): fix link to bower in step 12
...
Muchas gracias! \o/
2014-05-18 20:48:40 -04:00
Peter Bacon Darwin
5f5bf07bb8
docs(tutorial): move bower_components into app folder
2014-05-05 20:55:30 +01:00
Peter Bacon Darwin
dcd94a23e1
docs(tutorial/step-3): fix experiments
...
Closes https://github.com/angular/angular-phonecat/issues/142
2014-04-27 10:13:22 +01:00
Peter Bacon Darwin
9b79a00294
docs(tutorial/step-12): add info about app.css changes
...
Closes https://github.com/angular/angular-phonecat/issues/145
2014-04-27 09:11:06 +01:00
Peter Bacon Darwin
a5df2d4e36
docs(tutorial): clarify bower usage
2014-04-24 10:59:17 +01:00
nnennajohn
85ea376da2
docs(tutorial/index): add directions for installing bower
2014-04-22 16:27:06 -07:00
Amin Ogarrio
050aae3ceb
docs(tutorial/step-12): correct file path
...
Fixed wrong file path:
- angular/angular-animate.js -> angular-animate/angular-animate.js, which meets the code in app/index.html
Closes #7168
2014-04-21 16:21:04 -07:00
ttam3d0
2dc2265e4f
docs(tutorial/step_03): sync markup with angular-phonecat
...
Update from Bootstrap 2.3 to 3.1 changed "span" to "col" tags
Closes #7172
2014-04-21 15:46:57 -07:00
Thomas Junghans
9cd33df50c
docs(tutorial): update step_11.ngdoc
...
Change toEqual to toEqualData in the test 'should create "phones" model with 2 phones fetched from xhr'
to make test more consistent.
Closes #7182
2014-04-21 15:46:46 -07:00
Simon Taranto
1db20ce90f
docs(tutorial): update step_07.ngdoc
...
Closes #7169
2014-04-21 15:32:37 -07:00
Amin Ogarrio
76cb5ce7c5
docs(tutorial): fix typos in examples
...
The phonecatApp and phonecatAnimations modules have a dot where a semicolon should be at the end of the sentence
Closes #7167
2014-04-21 15:09:18 -07:00
jerryfan
7839330b40
docs(tutorial/step_12): fix grammar
2014-04-18 18:43:49 -04:00
expilo
b6eb5fdb05
docs(tutorial): specify that ng-repeat goes in markup and not script
...
Just to make clear that it should not go to test spec.
Closes #7104
2014-04-17 12:44:25 -04:00
Thom Allen
5bf6e50b40
docs(tutorial): fix typo in module name
...
Fixed a typo in step 2
Closes #7138
2014-04-16 16:25:33 -04:00
Robert Speicher
2e2d62ca12
docs(tutorial): npm needs "run" keyword for custom script names
...
Fix "npm run update-webdriver" command
Closes #7071
2014-04-10 08:25:12 -04:00
Thomas Wicker
651caffe45
docs(tutorial): fix typo in tutorial index page
...
Spelling error, "server" should be "serve"
Closes #7028
2014-04-07 07:41:02 -04:00
Peter Bacon Darwin
feb54d68d2
docs(tutorial/step-8): fix external link
2014-04-06 18:58:28 +01:00
Yiling Lu
2d0f6037f7
docs(tutorial/step-8): link to Protractor rather than ngScenario
...
Angular test runner API has been deprecated, Protractor is advised:
http://docs.angularjs.org/guide/e2e-testing
Link is updated to direct reader to Protractor API.
Closes #7001
2014-04-06 17:34:57 +01:00
Joseph Orbegoso Pea
cf8ed01c6e
docs(tutorial/step-5): clarify inline annotations
...
Closes #6998
2014-04-06 15:22:48 +01:00
Peter Bacon Darwin
c352b92c40
docs(tutorial/step-7): clarify the new files & modules
...
Closes #6996
2014-04-06 14:57:19 +01:00